Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-81313

Revert 80338, which overzealously applies encoding to URL fragments

XMLWordPrintable

    • 1
    • Team Alpha - Sprint 3 I1-2024

      As in the title. revert MDL-80338. See also: https://stackoverflow.com/questions/26088849/url-fragment-allowed-characters, which links to the RFC and breaks it down a bit.

      Basically, in a nutshell, if I have:
      https://example.com#some/thing/123

      those slashes in the fragment should not be encoded. With the current change, they are being encoded.

      This has the potential to entirely break areas of code which expect valid fragments to remain stable, such as when comparing them to stored values, as in auth flows like LTI launches.

            jaked Jake Dallimore
            jaked Jake Dallimore
            Andrew Lyons Andrew Lyons
            Jun Pataleta Jun Pataleta
            CiBoT CiBoT
            Votes:
            1 Vote for this issue
            Watchers:
            5 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 hour, 30 minutes
                1h 30m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.