Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-81318

Download all submissions generate html file for online text even if nothing has been submitted

Details

    • Bug
    • Resolution: Unresolved
    • Minor
    • None
    • 4.1.10, 4.2.7, 4.3.4, 4.4
    • Assignment
    • MOODLE_401_STABLE, MOODLE_402_STABLE, MOODLE_403_STABLE, MOODLE_404_STABLE
    • MDL-81318-403
    • MDL-81318-404
    • Hide
      1. Log in as admin
      2. Create two new users
        • User 1
        • User 2
      3. Create a course
      4. Enrol both users as students
      5. Add an Assignment activity to the course
        • Submission types: Online text & File submissions
      6. Log out
      7. Log in as User 1
      8. Navigate to course assignment and press Add submission
        • Leave Online text field empty
        • Upload a file to File submissions
        • Save changes
      9. Log out
      10. Log in as User 2
      11. Navigate to course assignment and press Add submission
        • Enter some text in the Online text field
        • Upload a file to File submissions
        • Save changes
      12. Log out
      13. Log in as admin
      14. Navigate to course assignment and press View all submissions
      15. Select all users
      16. Select Download selected submissions and press Go
      17. Confirm the downloaded zip file contains:
        • Only file submission for User 1
        • Both file and onlinetext submission for User 2
      Show
      Log in as admin Create two new users User 1 User 2 Create a course Enrol both users as students Add an Assignment activity to the course Submission types: Online text & File submissions Log out Log in as User 1 Navigate to course assignment and press Add submission Leave Online text field empty Upload a file to File submissions Save changes Log out Log in as User 2 Navigate to course assignment and press Add submission Enter some text in the Online text field Upload a file to File submissions Save changes Log out Log in as admin Navigate to course assignment and press View all submissions Select all users Select Download selected submissions and press Go Confirm the downloaded zip file contains: Only file submission for User 1 Both file and onlinetext submission for User 2

    Description

      Discovered by rajeshwar.shanigarapu@moodle.com while testing MDLQA-18886 during the 4.4 QA cycle.

      The problem happens when you have an assignment with both 'Online text' and 'File submissions' submission types enabled and a student submit only a file and not text, if you download all submissions the zip file will contain a onlinetext.html with some html code, even tough the student hasn't submitted any text.

      Steps to reproduce
      1. As teacher, create a new Assignment with both online and file submission type
      2. As student, go to the assignment submit it with only file (Don't provide any text)
      3. As teacher go to the assignment > view all submissions and then click "Download all submissions"
      Expected result

      The zip file contains just the file submitted by the student.

      Actual results

      The zip file contains both the file and a onlinetext.html with html tags in it (probably coming from the editor)

      Attachments

        Issue Links

          Activity

            People

              pholden Paul Holden
              lameze Simey Lameze
              Mihail Geshoski Mihail Geshoski
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:

                Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 12 minutes
                  12m

                  Clockify

                    Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.