Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-81319

Update upgrade_stale_php_files_present() before 4.4 release

XMLWordPrintable

    • Icon: Task Task
    • Resolution: Fixed
    • Icon: Minor Minor
    • 4.4
    • 4.4
    • Installation
    • MOODLE_404_STABLE
    • MOODLE_404_STABLE
    • Hide

      Note: TARGET for this issue is:

      1. main

      web

      1. Create/check out a 4.3.x site. For example: 

        git checkout v4.3.3

      2. Install the site.
      3. Check out the TARGET branch 

        git checkout TARGET

      4. Create any of the following files that are being detected by the patch. (e.g. on Linux, use the "touch" command):
        • README.txt 

          touch README.txt

        • lib/dataformatlib.php 

          touch lib/dataformatlib.php

        • lib/horde/readme_moodle.txt 

          touch lib/horde/readme_moodle.txt

        • ...
      5. Open your Moodle instance on your browser.
      6. Log in as admin and proceed with the upgrade.
      7. Verify that a notice ("Mixed Moodle versions detected....") is displayed saying that there are problems upgrading and a proper procedure for upgrading to a major release.
      8. Delete the touched file(s) in point 4.
      9. Click "Reload".
      10. Verify that the upgrade now proceeds ok.

      cli

      1. Repeat points 1-4 from the "web" instructions.
      2. Run the CLI upgrade 

        php admin/cli/upgrade.php

      3. Verify that a text ("Mixed Moodle versions detected....") is displayed saying that there are problems upgrading and a proper procedure for upgrading to a major release.
      4. Delete the touched file(s) in point web - 4.
      5. Run the CLI upgrade again 

        php admin/cli/upgrade.php

      6. Verify that now the process runs ok, with a prompt asking you for confirmation and then a number of upgrade steps and settings being setup.
      7. Verify that the process ends with a text like this (the numbers are not important), the "successfully" is.:

        Command line upgrade from XXXXX (Build: XXXXX) (XXXXX) to XXXXX (Build: XXXXX) (XXXXX) completed successfully.

      Show
      Note: TARGET for this issue is: main web Create/check out a 4.3.x site. For example: git checkout v4.3.3 Install the site. Check out the TARGET branch git checkout TARGET Create any of the following files that are being detected by the patch. (e.g. on Linux, use the " touch " command): README.txt touch README.txt lib/dataformatlib.php touch lib/dataformatlib.php lib/horde/readme_moodle.txt touch lib/horde/readme_moodle.txt ... Open your Moodle instance on your browser. Log in as admin and proceed with the upgrade. Verify that a notice ("Mixed Moodle versions detected....") is displayed saying that there are problems upgrading and a proper procedure for upgrading to a major release. Delete the touched file(s) in point 4. Click " Reload ". Verify that the upgrade now proceeds ok. cli Repeat points 1-4 from the "web" instructions. Run the CLI upgrade php admin/cli/upgrade.php Verify that a text ("Mixed Moodle versions detected....") is displayed saying that there are problems upgrading and a proper procedure for upgrading to a major release. Delete the touched file(s) in point web - 4. Run the CLI upgrade again php admin/cli/upgrade.php Verify that now the process runs ok, with a prompt asking you for confirmation and then a number of upgrade steps and settings being setup. Verify that the process ends with a text like this (the numbers are not important), the "successfully" is.: Command line upgrade from XXXXX (Build: XXXXX) (XXXXX) to XXXXX (Build: XXXXX) (XXXXX) completed successfully.

      Simply verify we have a number (4-5) of files for the next major release. They all must be files deleted since last stable version (403) and current main.

      git diff --name-status MOODLE_XX_STABLE..main | grep ^D

      And, then, simply, add them to upgrade_stale_php_files_present().

      Note that it's better not to pick any plugin file that maybe reinstalled manually (exception being forum files because that plugin is mandatory).

      Note: (to avoid forgetting it in next iteration of this issue). Don't forget the leading slashes in the paths.

        1. (1) 10 Passed -- (Main)MDL-81319.png
          (1) 10 Passed -- (Main)MDL-81319.png
          71 kB
        2. (1) 7 Passed -- (Main)MDL-81319.png
          (1) 7 Passed -- (Main)MDL-81319.png
          90 kB
        3. (2) 3 Passed -- (Main)MDL-81319.png
          (2) 3 Passed -- (Main)MDL-81319.png
          82 kB
        4. (2) 6 Passed -- (Main)MDL-81319.png
          (2) 6 Passed -- (Main)MDL-81319.png
          93 kB
        5. (2) 7 Passed -- (Main)MDL-81319.png
          (2) 7 Passed -- (Main)MDL-81319.png
          203 kB

            stronk7 Eloy Lafuente (stronk7)
            stronk7 Eloy Lafuente (stronk7)
            Paul Holden Paul Holden
            Ilya Tregubov Ilya Tregubov
            Kim Jared Lucas Kim Jared Lucas
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 hour, 29 minutes
                1h 29m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.