Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-81339

Modal factory no longer respects template defined in registry

Details

    • MOODLE_403_STABLE
    • MDL-81339-main
    • Hide

      1. Download the `test-81339.php` file and place it at the root of your Moodle install.
      2. Access it via the browser
      3. A modal will open
      4. Confirm the "Save changes" button is not visible

      Show
      1. Download the `test-81339.php` file and place it at the root of your Moodle install. 2. Access it via the browser 3. A modal will open 4. Confirm the "Save changes" button is not visible

    Description

      Prior to MDL-78324, a modal type could be registered with the registry like so:

      ModalRegistry.register('block_gearup_form', ModalSaveCancel, 'block_gearup/modal_form');
      

      This informed the registry that the core module ModalSaveCancel could be used while the template for the modal should be another one. I used the above to augment the modal forms and include a delete button in their footer.

      The factory no longer respects the declaration of the template when creating the modal, despite the template being a compulsory argument when declaring a modal with the registry.

      Attachments

        Issue Links

          Activity

            People

              Unassigned Unassigned
              fred Frédéric Massart
              Stevani Andolo Stevani Andolo
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 16 minutes
                  16m

                  Clockify

                    Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.