Discovered by rajeshwar.shanigarapu@moodle.com while testing MDLQA-18707.

As student on a quiz with password and browser security set to 'Full screen pop-up with some JavaScript security' the user is required to enter the password in the 'Start attempt' modal which then opens a pop up window which asks for the password again.

Steps to replicate

1. Login as a teacher, edit the settings for the quiz and set
   • Time limit to 1 min
   • Require password to Passw0rd
   • Browser security to 'Full screen pop-up with some JavaScript security'.
2. Login as a student, go to the Quiz and click the Start attempt button.
3. Verify that a JavaScript modal dialogue appears, warning you about the time limit, and asking you to supply the password.
4. Type in the correct password and click Start attempt.

Expected behavior

1. The pop-up window will open full screen with the attempt page.

Current behavior

The attempt page is not opened, instead the user is requested to enter the password again.

Note: lameze's testing foudn the bug did not happen in 4.1.x, so it regression from something.