Loading...

XML

Word

Printable

Type: Bug
Resolution: Fixed
Priority: Minor
Fix Version/s: 4.4.5, 4.5.1
Affects Version/s: 4.2.6, 4.3.3, 4.4.2, 4.5
Component/s: Email, Forum
Labels:
- ci
- hqteam_alpha
- mebis
- patch
- release_notes
- triaged

Affected Branches:
MOODLE_402_STABLE, MOODLE_403_STABLE, MOODLE_404_STABLE, MOODLE_405_STABLE
Fixed Branches:
MOODLE_404_STABLE, MOODLE_405_STABLE
Pull from Repository:
https://github.com/PhMemmel/moodle
Pull 4.4 Branch:
~~MDL-81450~~-MOODLE_404_STABLE
Pull 4.4 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_404_STABLE...PhMemmel:MDL-81450-MOODLE_404_STABLE
Pull 4.5 Branch:
~~MDL-81450~~-MOODLE_405_STABLE
Pull 4.5 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_405_STABLE...PhMemmel:MDL-81450-MOODLE_405_STABLE
Pull Main Branch:
~~MDL-81450~~-main
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/main...PhMemmel:MDL-81450-main
Testing Instructions:
Hide

Set up

Using Mailpit or Mailhog, set "$CFG->smtphosts = 'localhost:1025';"

As admin, create a course

Enrol a student

Test

Create a forum activity with Subscription mode -> "Forced subscription"

Click "Add discussion topic"

Click "Advanced"

Enable "Send forum post notifications with no editing-time delay"

Upload a PDF document as attachment

Send the post

Run cron

Verify that the mailbox of the student user has a new mail

Verify that the PDF icon is an inline icon left to the link to the attachment
Show
Set up Using Mailpit or Mailhog, set " $CFG->smtphosts = 'localhost:1025'; " As admin, create a course Enrol a student Test Create a forum activity with Subscription mode -> "Forced subscription" Click "Add discussion topic" Click "Advanced" Enable "Send forum post notifications with no editing-time delay" Upload a PDF document as attachment Send the post Run cron Verify that the mailbox of the student user has a new mail Verify that the PDF icon is an inline icon left to the link to the attachment
Pre-check results:
Hide

Code verified against automated checks.

Checked ~~MDL-81450~~ using repository: https://github.com/PhMemmel/moodle

MOODLE_404_STABLE (0 errors / 0 warnings) [branch: MDL-81450-MOODLE_404_STABLE | CI Job]

MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-81450-MOODLE_405_STABLE | CI Job]

main (0 errors / 0 warnings) [branch: MDL-81450-main | CI Job]

_{More information about this report}

Built on: Wed 16 Oct 2024 12:53:16 PM UTC
Show
Code verified against automated checks. Checked MDL-81450 using repository: https://github.com/PhMemmel/moodle MOODLE_404_STABLE (0 errors / 0 warnings) [branch: MDL-81450-MOODLE_404_STABLE | CI Job ] MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-81450-MOODLE_405_STABLE | CI Job ] main (0 errors / 0 warnings) [branch: MDL-81450-main | CI Job ] More information about this report Built on: Wed 16 Oct 2024 12:53:16 PM UTC
Automated test results:
Hide

Launching automatic jobs for branch ~~MDL-81450~~-MOODLE_404_STABLE

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17008/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/57938/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/57939/ Behat (Firefox - boost)

Launching automatic jobs for branch ~~MDL-81450~~-MOODLE_405_STABLE

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17009/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/57940/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/57941/ Behat (Firefox - boost)

Launching automatic jobs for branch ~~MDL-81450~~-main

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17010/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/57942/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/57943/ Behat (Firefox - boost)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/57944/ Behat (Firefox - classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/57945/ App tests (stable app version)

Built on: Wed Oct 16 10:25:18 AM UTC 2024
Show
Launching automatic jobs for branch MDL-81450 -MOODLE_404_STABLE https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17008/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/57938/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/57939/ Behat (Firefox - boost) Launching automatic jobs for branch MDL-81450 -MOODLE_405_STABLE https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17009/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/57940/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/57941/ Behat (Firefox - boost) Launching automatic jobs for branch MDL-81450 -main https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17010/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/57942/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/57943/ Behat (Firefox - boost) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/57944/ Behat (Firefox - classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/57945/ App tests (stable app version) Built on: Wed Oct 16 10:25:18 AM UTC 2024

When using Outlook, when you open an email coming from a forum post, and that forum post has an attachment, the attachment icon is displayed at an incorrect size, as shown in the attached image.

As far as I can tell, the problem is that the icon is an SVG, and has no intrinsic dimensions. In that case Outlook relies on CSS or image attributes to set the dimensions of the image, but it seems like the message doesn't include any CSS that targets the icon class. Failing that, Outlook renders the icon at the width of the container (in this case, the table cell it is in) so, the wider the message, the bigger the icon is displayed.

It is not a problem in Gmail, since it just doesn't display the image and falls back to the alt text.

Found in Moodle 4.3.3 (Build: 20240212) with the Boost theme.

- - Sort By Name
  - Sort By Date
  - Ascending
  - Descending
  - Thumbnails
  - List
  - Download All

(1) 8 Passed -- (Main)MDL-81450.png
66 kB
17/Oct/24 2:55 PM
(1) 9 Passed -- (Main)MDL-81450.png
65 kB
17/Oct/24 2:55 PM
Moodle Outlook Forum email.jpg
46 kB
05/Apr/24 9:51 PM

has been marked as being related by

MDL-81360 Big Icon file document type in forum email notifications

Closed

is duplicated by

MDL-83207 mod_forum: Huge file icon in HTML forum post mails

Closed

Assignee:: PhMemmel

Reporter:: Xavier Giró

Peer reviewer:: Tobias Garske

Integrator:: Jun Pataleta

Tester:: Kim Jared Lucas

Participants:: CiBoT, Jun Pataleta, Kim Jared Lucas, Mateusz Walczak, Mihail Geshoski, PhMemmel, Tobias Garske, Xavier Giró

Votes:: 3 Vote for this issue

Watchers:: 13 Start watching this issue

Created:: 05/Apr/24 9:51 PM

Updated:: 03/Dec/24 10:18 PM

Resolved:: 18/Oct/24 9:38 PM

Estimated:

Remaining:

Logged:

21m

Details

Set up

Test

Description

Attachments

Attachments

Issue Links

Activity

People

Dates

Time Tracking

Clockify