Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-81461

Bugs with admin_setting_configiplist with ipv6 addresses

XMLWordPrintable

    • MOODLE_403_STABLE
    • Easy

      There is a fairly robust and tested library here for validating ipv4 and ipv6 addresses:

      https://github.com/moodle/moodle/blob/main/lib/classes/ip_utils.php

      but the admin_setting_configiplist predates this and hand rolls its own validation using a regex which is not working:

      https://github.com/moodle/moodle/blob/main/lib/adminlib.php#L4229-L4232

      Reproduction steps:

      1) Visit /admin/settings.php?section=ipblocker

      2) Enter any valid ip6v address egĀ 2001:db8:3333:4444:5555:6666:7777:8888 and save

      3) This produces a validation error

            Unassigned Unassigned
            brendanheywood Brendan Heywood
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.