Loading...

XML

Word

Printable

Type: Bug
Resolution: Fixed
Priority: Blocker
Fix Version/s: 4.4
Affects Version/s: 4.4
Component/s: Administration, Themes
Labels:

Affected Branches:
MOODLE_404_STABLE
Fixed Branches:
MOODLE_404_STABLE
Pull from Repository:
https://github.com/mickhawkins/moodle.git
Pull Main Branch:
~~MDL-81512~~-main
Pull Main Diff URL:
https://github.com/mickhawkins/moodle/compare/8cf14f6e70...MDL-81512-main
Testing Instructions:
Hide

Test 1

From site administration access the "Appearance" page.

Verify you do not see a "Custom theme settings" section.

Within "Appearance", click on "Themes".

Verify that clicking on the settings cog within both Boost and Classic takes you to the expected theme's settings page.

Install the following plugins:

Adaptable: https://moodle.org/plugins/theme_adaptable/403.1.4/31629 (unzip the plugin to the theme/adaptable folder).

Eguru: https://moodle.org/plugins/download.php/29725/theme_eguru_moodle42_2023080101.zip (unzip the plugin to the theme/eguru folder).

Visit site administration and run through the upgrade process so the above are installed.

Verify that the upgrade process is done without any errors.

From site administration access the "Appearance" page.

Verify you do not see any errors.

Verify you can see a new section called "Custom theme settings".

Verify that you see both Adapatable and Eguru listed within the Custom theme settings section on the page.

Verify Eguru is not listed in the Appearance section of the page.

Click on "Adaptable" theme and verify you do not see any error.

Click on "Settings" and "Import / export settings" and verify you don't see any error.

Navigate to Site administration > Appearance > Themes and click "Select theme" on the "Adaptable" theme. Verify you do not see any error.
Show
Test 1 From site administration access the "Appearance" page. Verify you do not see a "Custom theme settings" section. Within "Appearance", click on "Themes". Verify that clicking on the settings cog within both Boost and Classic takes you to the expected theme's settings page. Install the following plugins: Adaptable: https://moodle.org/plugins/theme_adaptable/403.1.4/31629 (unzip the plugin to the theme/adaptable folder). Eguru: https://moodle.org/plugins/download.php/29725/theme_eguru_moodle42_2023080101.zip (unzip the plugin to the theme/eguru folder). Visit site administration and run through the upgrade process so the above are installed. Verify that the upgrade process is done without any errors. From site administration access the "Appearance" page. Verify you do not see any errors. Verify you can see a new section called "Custom theme settings". Verify that you see both Adapatable and Eguru listed within the Custom theme settings section on the page. Verify Eguru is not listed in the Appearance section of the page. Click on "Adaptable" theme and verify you do not see any error. Click on "Settings" and "Import / export settings" and verify you don't see any error. Navigate to Site administration > Appearance > Themes and click "Select theme" on the "Adaptable" theme. Verify you do not see any error.

Sprint:
Team Hedgehog 2024 Sprint 1.4

Probably related to with ~~MDL-78426~~ and/or ~~MDL-78425~~

For testing I've used this plugin: https://moodle.org/plugins/theme_adaptable/versions

Specifically 403.1.4 (2023111805)
https://moodle.org/plugins/download.php/31629/theme_adaptable_moodle43_2023111805.zip

Post installation, when reaching the upgrade settings page:

parent does not exist!

    line 948 of /lib/adminlib.php: call to debugging()

    line 81 of /theme/adaptable/settings.php: call to admin_category->add()

    line 357 of /admin/settings/appearance.php: call to include()

    line 8855 of /lib/adminlib.php: call to require()

    line 22 of /admin/upgradesettings.php: call to admin_get_root()

Repeated 6 times

The same is also subsequently repeated 6 times on every page load (without yet enabling the theme)

I navigate to Appearance > Themes and press the settings cog for the Adaptable theme:

Section error!

More information about this error

Debug info:

Error code: sectionerror

Stack trace:

    line 26 of /admin/settings.php: moodle_exception thrown

Errors. I can't configure it The same parent does not exist is also spammed across the page

I to back to Appearance themes and select the Adaptable theme

My page has errors everywhere

"parent does not exist" - except now they're errors instead of debugging

Now the following too:

Warning: Undefined property: stdClass::$blockicons in /var/www/html/theme/adaptable/classes/output/core_renderer_layout.php on line 114

Warning: Undefined property: stdClass::$blockside in /var/www/html/theme/adaptable/classes/output/core_renderer_layout.php on line 124

Warning: Undefined property: stdClass::$maincolor in /var/www/html/theme/adaptable/classes/output/core_renderer_layout.php on line 450

Skip to main content

Blocks

Skip Navigation

Navigation

    Dashboard

        Site home

        Site pages

        My courses

        Courses

Skip Administration

Administration

    Site administration

        Notifications

        Registration

        Feedback settings

        Advanced features

        Users

        Courses

        Grades

        Analytics

        Competencies

        Badges

H5P

        Licence

        Power users generator

        Location

        Language

        Messaging

        Payments

        Plugins

        Security

        Appearance

            Logos

            Course card colours

            Calendar

            Blog

            Navigation

            HTML settings

            Moodle Docs

            Default Dashboard page

            Default profile page

            Courses

            AJAX and Javascript

            Manage tags

            Additional HTML

            Templates

            Advanced theme settings

            Themes

            User tours

        Site home

        Server

        Reports

        Development

        MoodleNet

        Site admin presets

Search in settings

Skip Admin bookmarks

Admin bookmarks

Bookmark this page

Warning

: Undefined property: stdClass::$showusername in

/var/www/html/theme/adaptable/classes/output/core_renderer_layout.php

on line

Warning

: Undefined property: stdClass::$sitetitle in

/var/www/html/theme/adaptable/classes/output/core_renderer_toolbox.php

on line

Warning

: Undefined property: stdClass::$editsettingsbutton in

/var/www/html/theme/adaptable/classes/output/core_renderer_layout.php

on line

Warning

: Undefined property: stdClass::$enablezoom in

/var/www/html/theme/adaptable/classes/output/core_renderer_layout.php

on line

Warning

: Undefined property: stdClass::$responsiveheader in

/var/www/html/theme/adaptable/classes/output/core_renderer_layout.php

on line

- - Sort By Name
  - Sort By Date
  - Ascending
  - Descending
  - Thumbnails
  - List
  - Download All

boost union-1.png
268 kB
15/Apr/24 1:36 PM
boost union-2.png
293 kB
15/Apr/24 1:37 PM
MDL-81463.png
570 kB
18/Apr/24 3:47 PM
MDL-81512.png
64 kB
12/Apr/24 8:11 PM
MDL-81512-1.png
2.08 MB
18/Apr/24 5:00 PM
Screenshot from 2024-04-12 17-07-14.png
67 kB
12/Apr/24 11:07 PM

has a non-specific relationship to

MDL-81554 Add support for multiple theme settings sections in the new theme selector format

Open

is a regression caused by

MDL-78425 Theme Selector: Improve UI

Closed

MDL-78426 Theme Selector: Settings UI

Closed

Assignee:: Michael Hawkins

Reporter:: Paul Holden

Peer reviewer:: David Woloszyn

Integrator:: Huong Nguyen

Tester:: Ron Carl Alfon Yu

Participants:: Alexander Bias, CiBoT, David Woloszyn, Huong Nguyen, Luca Bösch, Marina Glancy, Mary Cooch, Matt Porritt, Michael Hawkins, Paul Holden, Raquel Ortega, Ron Carl Alfon Yu

Votes:: 2 Vote for this issue

Watchers:: 17 Start watching this issue

Created:: 12/Apr/24 4:18 PM

Updated:: 24/Apr/24 7:55 PM

Resolved:: 19/Apr/24 6:59 PM

Estimated:

Not Specified

Remaining:

Logged:

1d 6h 47m

Details

Test 1

Description

Attachments

Attachments

Issue Links

Activity

People

Dates

Time Tracking

Clockify