Loading...

XML

Word

Printable

Type: Improvement
Resolution: Fixed
Priority: Minor
Fix Version/s: 4.1.16, 4.3.10, 4.4.6, 4.5.2
Affects Version/s: 4.1.15, 4.3.9, 4.4.5, 4.5.1, 5.0
Component/s: Unit tests
Labels:

Affected Branches:
MOODLE_401_STABLE, MOODLE_403_STABLE, MOODLE_404_STABLE, MOODLE_405_STABLE, MOODLE_500_STABLE
Fixed Branches:
MOODLE_401_STABLE, MOODLE_403_STABLE, MOODLE_404_STABLE, MOODLE_405_STABLE
Epic Link:
Migrate to PHPUnit 11
Pull from Repository:
https://github.com/andrewnicols/moodle.git
Pull 4.1 Branch:
~~MDL-81520~~-401
Pull 4.1 Diff URL:
https://github.com/andrewnicols/moodle/compare/3d7496dacd...MDL-81520-401?w=1
Pull 4.3 Branch:
~~MDL-81520~~-403
Pull 4.3 Diff URL:
https://github.com/andrewnicols/moodle/compare/9dbf9e9829...MDL-81520-403?w=1
Pull 4.4 Branch:
~~MDL-81520~~-404
Pull 4.4 Diff URL:
https://github.com/andrewnicols/moodle/compare/02e8cebdd2...MDL-81520-404?w=1
Pull 4.5 Branch:
~~MDL-81520~~-405
Pull 4.5 Diff URL:
https://github.com/andrewnicols/moodle/compare/4bd3217ce8...MDL-81520-405?w=1
Pull Main Branch:
~~MDL-81520~~-main
Pull Main Diff URL:
https://github.com/andrewnicols/moodle/compare/0888a6d324...MDL-81520-main?w=1
Testing Instructions:
Hide

Setup

Install PHPCodeSniffer on your machine

Test

Confirm that no tests remain that need to be fixed:

phpcs --sniffs=moodle.PHPUnit.TestClassesFinal --parallel=100 -s -p .
Show
Setup Install PHPCodeSniffer on your machine Test Confirm that no tests remain that need to be fixed: phpcs --sniffs=moodle.PHPUnit.TestClassesFinal --parallel=100 -s -p .
Pre-check results:
Hide

Fails against automated checks.

Checked ~~MDL-81520~~ using repository: https://github.com/andrewnicols/moodle.git

MOODLE_401_STABLE (30 errors / 123 warnings) [branch: MDL-81520-401 | CI Job]

overview (0/0), phplint (0/0), phpcs (30/123), js (0/0), css (0/0), phpdoc (0/0), commit (0/0), savepoint (0/0), thirdparty (0/0), externalbackup (0/0), grunt (0/0), shifter (0/0), mustache (0/0), gherkin (0/0),

MOODLE_403_STABLE (29 errors / 128 warnings) [branch: MDL-81520-403 | CI Job]

overview (0/0), phplint (0/0), phpcs (29/128), js (0/0), css (0/0), phpdoc (0/0), commit (0/0), savepoint (0/0), thirdparty (0/0), externalbackup (0/0), grunt (0/0), shifter (0/0), mustache (0/0), gherkin (0/0),

MOODLE_404_STABLE (31 errors / 59 warnings) [branch: MDL-81520-404 | CI Job]

overview (0/0), phplint (0/0), phpcs (31/59), js (0/0), css (0/0), phpdoc (0/0), commit (0/0), savepoint (0/0), thirdparty (0/0), externalbackup (0/0), grunt (0/0), shifter (0/0), mustache (0/0), gherkin (0/0),

MOODLE_405_STABLE (30 errors / 58 warnings) [branch: MDL-81520-405 | CI Job]

overview (0/0), phplint (0/0), phpcs (30/58), js (0/0), css (0/0), phpdoc (0/0), commit (0/0), savepoint (0/0), thirdparty (0/0), externalbackup (0/0), grunt (0/0), shifter (0/0), mustache (0/0), gherkin (0/0),

main (30 errors / 58 warnings) [branch: MDL-81520-main | CI Job]

overview (0/0), phplint (0/0), phpcs (30/58), js (0/0), css (0/0), phpdoc (0/0), commit (0/0), savepoint (0/0), thirdparty (0/0), externalbackup (0/0), grunt (0/0), shifter (0/0), mustache (0/0), gherkin (0/0),

Should these errors be fixed?

Built on: Tue 10 Dec 2024 07:03:45 AM UTC
Show
Fails against automated checks. Checked MDL-81520 using repository: https://github.com/andrewnicols/moodle.git MOODLE_401_STABLE (30 errors / 123 warnings) [branch: MDL-81520-401 | CI Job ] overview (0/0) , phplint (0/0) , phpcs (30/123) , js (0/0) , css (0/0) , phpdoc (0/0) , commit (0/0) , savepoint (0/0) , thirdparty (0/0) , externalbackup (0/0) , grunt (0/0) , shifter (0/0) , mustache (0/0) , gherkin (0/0) , MOODLE_403_STABLE (29 errors / 128 warnings) [branch: MDL-81520-403 | CI Job ] overview (0/0) , phplint (0/0) , phpcs (29/128) , js (0/0) , css (0/0) , phpdoc (0/0) , commit (0/0) , savepoint (0/0) , thirdparty (0/0) , externalbackup (0/0) , grunt (0/0) , shifter (0/0) , mustache (0/0) , gherkin (0/0) , MOODLE_404_STABLE (31 errors / 59 warnings) [branch: MDL-81520-404 | CI Job ] overview (0/0) , phplint (0/0) , phpcs (31/59) , js (0/0) , css (0/0) , phpdoc (0/0) , commit (0/0) , savepoint (0/0) , thirdparty (0/0) , externalbackup (0/0) , grunt (0/0) , shifter (0/0) , mustache (0/0) , gherkin (0/0) , MOODLE_405_STABLE (30 errors / 58 warnings) [branch: MDL-81520-405 | CI Job ] overview (0/0) , phplint (0/0) , phpcs (30/58) , js (0/0) , css (0/0) , phpdoc (0/0) , commit (0/0) , savepoint (0/0) , thirdparty (0/0) , externalbackup (0/0) , grunt (0/0) , shifter (0/0) , mustache (0/0) , gherkin (0/0) , main (30 errors / 58 warnings) [branch: MDL-81520-main | CI Job ] overview (0/0) , phplint (0/0) , phpcs (30/58) , js (0/0) , css (0/0) , phpdoc (0/0) , commit (0/0) , savepoint (0/0) , thirdparty (0/0) , externalbackup (0/0) , grunt (0/0) , shifter (0/0) , mustache (0/0) , gherkin (0/0) , Should these errors be fixed? Built on: Tue 10 Dec 2024 07:03:45 AM UTC
Automated test results:
Hide

Launching automatic jobs for branch ~~MDL-81520~~-401

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17693/ PHPUnit (sqlsrv / --filter test_badge_activity_criteria_with_a_huge_number_of_coursemodules)

Launching automatic jobs for branch ~~MDL-81520~~-403

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17694/ PHPUnit (sqlsrv / --filter test_badge_activity_criteria_with_a_huge_number_of_coursemodules)

Launching automatic jobs for branch ~~MDL-81520~~-404

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17695/ PHPUnit (sqlsrv / --filter test_badge_activity_criteria_with_a_huge_number_of_coursemodules)

Launching automatic jobs for branch ~~MDL-81520~~-405

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17696/ PHPUnit (sqlsrv / --filter test_badge_activity_criteria_with_a_huge_number_of_coursemodules)

Launching automatic jobs for branch ~~MDL-81520~~-main

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17697/ PHPUnit (sqlsrv / --filter test_badge_activity_criteria_with_a_huge_number_of_coursemodules)

Built on: Wed Dec 11 04:31:57 AM UTC 2024
Show
Launching automatic jobs for branch MDL-81520 -401 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17693/ PHPUnit (sqlsrv / --filter test_badge_activity_criteria_with_a_huge_number_of_coursemodules) Launching automatic jobs for branch MDL-81520 -403 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17694/ PHPUnit (sqlsrv / --filter test_badge_activity_criteria_with_a_huge_number_of_coursemodules) Launching automatic jobs for branch MDL-81520 -404 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17695/ PHPUnit (sqlsrv / --filter test_badge_activity_criteria_with_a_huge_number_of_coursemodules) Launching automatic jobs for branch MDL-81520 -405 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17696/ PHPUnit (sqlsrv / --filter test_badge_activity_criteria_with_a_huge_number_of_coursemodules) Launching automatic jobs for branch MDL-81520 -main https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17697/ PHPUnit (sqlsrv / --filter test_badge_activity_criteria_with_a_huge_number_of_coursemodules) Built on: Wed Dec 11 04:31:57 AM UTC 2024

Update existing unit tests to be final to prevent people from extending them when they should be writing a testcase.

- - Sort By Name
  - Sort By Date
  - Ascending
  - Descending
  - Thumbnails
  - List
  - Download All

MDL-81520.png
165 kB
11/Dec/24 3:06 PM

blocks

MDL-83468 Bump to PHPUnit 11

Closed

caused a regression

MDL-84018 phpunit test error Class "externallib_advanced_testcase" not found

Closed

has been marked as being related by

MDL-85241 mod/assign base_test. Please do not make base classes final

Closed

has to be done after

MDL-80927 attempt_walkthrough_from_csv_test is extended by other tests

Open

MDL-83305 Add missing docblocks to unit tests

Closed

is blocked by

MDL-81521 Make all data provider static

Closed

will help resolve

MDL-63670 Message unit tests cause duplicate tests

Closed

(1 is blocked by, 1 will help resolve)

Assignee:: Andrew Lyons

Reporter:: Andrew Lyons

Peer reviewer:: Angelia Dela Cruz

Integrator:: Simey Lameze

Tester:: Ron Carl Alfon Yu

Participants:: Alistair Spark, Andrew Lyons, Angelia Dela Cruz, CiBoT, Daniel Ziegenberg, Jun Pataleta, Ron Carl Alfon Yu, Simey Lameze

Votes:: 0 Vote for this issue

Watchers:: 8 Start watching this issue

Created:: 13/Apr/24 1:33 PM

Updated:: 22/Apr/25 10:11 AM

Resolved:: 13/Dec/24 10:41 AM

Estimated:

Not Specified

Remaining:

Logged:

2d 40m

Details

Setup

Test

Description

Attachments

Attachments

Issue Links

Activity

People

Dates

Time Tracking

Clockify