Loading...

XML

Word

Printable

Type: Improvement
Resolution: Fixed
Priority: Major
Fix Version/s: 4.1.15, 4.3.9, 4.4.5, 4.5.1
Affects Version/s: 4.1.14, 4.3.8, 4.4.4, 4.5
Component/s: Unit tests
Labels:

Affected Branches:
MOODLE_401_STABLE, MOODLE_403_STABLE, MOODLE_404_STABLE, MOODLE_405_STABLE
Fixed Branches:
MOODLE_401_STABLE, MOODLE_403_STABLE, MOODLE_404_STABLE, MOODLE_405_STABLE
Epic Link:
Migrate to PHPUnit 11
Pull from Repository:
https://github.com/andrewnicols/moodle.git
Pull 4.1 Branch:
~~MDL-81521~~-401
Pull 4.1 Diff URL:
https://github.com/andrewnicols/moodle/compare/eaa25cf51b...MDL-81521-401?w=1
Pull 4.3 Branch:
~~MDL-81521~~-403
Pull 4.3 Diff URL:
https://github.com/andrewnicols/moodle/compare/ba7e9f33ed...MDL-81521-403?w=1
Pull 4.4 Branch:
~~MDL-81521~~-404
Pull 4.4 Diff URL:
https://github.com/andrewnicols/moodle/compare/63205f03bb...MDL-81521-404?w=1
Pull 4.5 Branch:
~~MDL-81521~~-405
Pull 4.5 Diff URL:
https://github.com/andrewnicols/moodle/compare/e1d05182a6...MDL-81521-405?w=1
Pull Main Branch:
~~MDL-81521~~-main
Pull Main Diff URL:
https://github.com/andrewnicols/moodle/compare/269a8a8a1b...MDL-81521-main?w=1
Testing Instructions:
Hide

Setup

Ensure you have the codechecker plugin in your moodle "/local" dir.

Ensure the plugin dependencies are up-to-date: composer update

Testing

Run phpcbf against the moodle.PHPUnit.TestCaseProvider sniff:

phpcbf --sniffs=moodle.PHPUnit.TestCaseProvider .

Confirm no changes

Please note: phpcbf is located in local/codechecker/vendor/bin, so alternatively you can run the command: local/codechecker/vendor/bin/phpcbf --sniffs=moodle.PHPUnit.TestCaseProvider .
Show
Setup Ensure you have the codechecker plugin in your moodle "/local" dir. Ensure the plugin dependencies are up-to-date: composer update Testing Run phpcbf against the moodle.PHPUnit.TestCaseProvider sniff: phpcbf --sniffs=moodle.PHPUnit.TestCaseProvider . Confirm no changes Please note: phpcbf is located in local/codechecker/vendor/bin , so alternatively you can run the command: local/codechecker/vendor/bin/phpcbf --sniffs=moodle.PHPUnit.TestCaseProvider .
Pre-check results:
Hide

Fails against automated checks.

Checked ~~MDL-81521~~ using repository: https://github.com/andrewnicols/moodle.git

MOODLE_401_STABLE (12 errors / 48 warnings) [branch: MDL-81521-401 | CI Job]

overview (0/0), phplint (1/0), phpcs (11/48), js (0/0), css (0/0), phpdoc (0/0), commit (0/0), savepoint (0/0), thirdparty (0/0), externalbackup (0/0), grunt (0/0), shifter (0/0), mustache (0/0), gherkin (0/0),

MOODLE_403_STABLE (10 errors / 27 warnings) [branch: MDL-81521-403 | CI Job]

overview (0/0), phplint (0/0), phpcs (10/27), js (0/0), css (0/0), phpdoc (0/0), commit (0/0), savepoint (0/0), thirdparty (0/0), externalbackup (0/0), grunt (0/0), shifter (0/0), mustache (0/0), gherkin (0/0),

MOODLE_404_STABLE (10 errors / 23 warnings) [branch: MDL-81521-404 | CI Job]

overview (0/0), phplint (0/0), phpcs (10/23), js (0/0), css (0/0), phpdoc (0/0), commit (0/0), savepoint (0/0), thirdparty (0/0), externalbackup (0/0), grunt (0/0), shifter (0/0), mustache (0/0), gherkin (0/0),

MOODLE_405_STABLE (9 errors / 21 warnings) [branch: MDL-81521-405 | CI Job]

overview (0/0), phplint (0/0), phpcs (9/21), js (0/0), css (0/0), phpdoc (0/0), commit (0/0), savepoint (0/0), thirdparty (0/0), externalbackup (0/0), grunt (0/0), shifter (0/0), mustache (0/0), gherkin (0/0),

main (8 errors / 19 warnings) [branch: MDL-81521-main | CI Job]

overview (0/0), phplint (0/0), phpcs (5/19), js (0/0), css (0/0), phpdoc (3/0), commit (0/0), savepoint (0/0), thirdparty (0/0), externalbackup (0/0), grunt (0/0), shifter (0/0), mustache (0/0), gherkin (0/0),

Should these errors be fixed?

Built on: Mon 18 Nov 2024 05:07:02 AM UTC
Show
Fails against automated checks. Checked MDL-81521 using repository: https://github.com/andrewnicols/moodle.git MOODLE_401_STABLE (12 errors / 48 warnings) [branch: MDL-81521-401 | CI Job ] overview (0/0) , phplint (1/0) , phpcs (11/48) , js (0/0) , css (0/0) , phpdoc (0/0) , commit (0/0) , savepoint (0/0) , thirdparty (0/0) , externalbackup (0/0) , grunt (0/0) , shifter (0/0) , mustache (0/0) , gherkin (0/0) , MOODLE_403_STABLE (10 errors / 27 warnings) [branch: MDL-81521-403 | CI Job ] overview (0/0) , phplint (0/0) , phpcs (10/27) , js (0/0) , css (0/0) , phpdoc (0/0) , commit (0/0) , savepoint (0/0) , thirdparty (0/0) , externalbackup (0/0) , grunt (0/0) , shifter (0/0) , mustache (0/0) , gherkin (0/0) , MOODLE_404_STABLE (10 errors / 23 warnings) [branch: MDL-81521-404 | CI Job ] overview (0/0) , phplint (0/0) , phpcs (10/23) , js (0/0) , css (0/0) , phpdoc (0/0) , commit (0/0) , savepoint (0/0) , thirdparty (0/0) , externalbackup (0/0) , grunt (0/0) , shifter (0/0) , mustache (0/0) , gherkin (0/0) , MOODLE_405_STABLE (9 errors / 21 warnings) [branch: MDL-81521-405 | CI Job ] overview (0/0) , phplint (0/0) , phpcs (9/21) , js (0/0) , css (0/0) , phpdoc (0/0) , commit (0/0) , savepoint (0/0) , thirdparty (0/0) , externalbackup (0/0) , grunt (0/0) , shifter (0/0) , mustache (0/0) , gherkin (0/0) , main (8 errors / 19 warnings) [branch: MDL-81521-main | CI Job ] overview (0/0) , phplint (0/0) , phpcs (5/19) , js (0/0) , css (0/0) , phpdoc (3/0) , commit (0/0) , savepoint (0/0) , thirdparty (0/0) , externalbackup (0/0) , grunt (0/0) , shifter (0/0) , mustache (0/0) , gherkin (0/0) , Should these errors be fixed? Built on: Mon 18 Nov 2024 05:07:02 AM UTC
Automated test results:
Hide

Launching automatic jobs for branch ~~MDL-81521~~-401

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17356/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59234/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59235/ Behat (Firefox - boost)

Launching automatic jobs for branch ~~MDL-81521~~-403

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17357/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59236/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59237/ Behat (Firefox - boost)

Launching automatic jobs for branch ~~MDL-81521~~-404

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17358/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59238/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59239/ Behat (Firefox - boost)

Launching automatic jobs for branch ~~MDL-81521~~-405

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17359/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59240/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59241/ Behat (Firefox - boost)

Launching automatic jobs for branch ~~MDL-81521~~-main

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17360/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59242/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59243/ Behat (Firefox - boost)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59244/ Behat (Firefox - classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59245/ App tests (stable app version)

Built on: Fri Nov 15 10:26:17 UTC 2024
Show
Launching automatic jobs for branch MDL-81521 -401 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17356/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59234/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59235/ Behat (Firefox - boost) Launching automatic jobs for branch MDL-81521 -403 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17357/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59236/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59237/ Behat (Firefox - boost) Launching automatic jobs for branch MDL-81521 -404 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17358/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59238/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59239/ Behat (Firefox - boost) Launching automatic jobs for branch MDL-81521 -405 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17359/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59240/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59241/ Behat (Firefox - boost) Launching automatic jobs for branch MDL-81521 -main https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17360/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59242/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59243/ Behat (Firefox - boost) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59244/ Behat (Firefox - classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59245/ App tests (stable app version) Built on: Fri Nov 15 10:26:17 UTC 2024

PHPUnit 10 requires that data providers be static. We already have a Sniff for this.

As a first pass we should auto fix with this sniff, and then raise a followup issue for any provider which cannot be automatically fixed.

- - Sort By Name
  - Sort By Date
  - Ascending
  - Descending
  - Thumbnails
  - List
  - Download All

(1) 1 Passed -- (Main)MDL-81521.png
36 kB
20/Nov/24 1:56 PM

blocks

MDL-81520 Update existing unit tests to be final

Closed

MDL-83468 Bump to PHPUnit 11

Closed

caused a regression

MDL-84152 URLs generated by getExternalTestFileUrl() now contain double forward slash

Closed

Assignee:: Andrew Lyons

Reporter:: Andrew Lyons

Peer reviewer:: Meirza

Integrator:: Simey Lameze

Tester:: Kim Jared Lucas

Participants:: Andrew Lyons, CiBoT, Daniel Ziegenberg, Jake Dallimore, Jun Pataleta, Kim Jared Lucas, Meirza, Simey Lameze, Tim Hunt

Votes:: 0 Vote for this issue

Watchers:: 9 Start watching this issue

Created:: 13/Apr/24 1:34 PM

Updated:: 10/Jan/25 2:28 PM

Resolved:: 22/Nov/24 10:56 PM

Estimated:

Not Specified

Remaining:

Logged:

1d 5h 26m

Details

Setup

Testing

Description

Attachments

Attachments

Issue Links

Activity

People

Dates

Time Tracking

Clockify