Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-81525

Hooks overview page is all over the place

XMLWordPrintable

      I was just looking at the Site administration>Development>Hooks overview page and it's just so weird...

      1. Some tags have comma in the end
      2. Class core\hook\di_configuration is listed but it is not a hook
      3. Tags are just all over the place, the tag 'user' is missing in the hooks that clearly work with users, and also there are some weird tags 'cm_name_edited' and 'tool_usertours'
      4. the verbs have different tense, i.e. before_user_deleted and before_user_update
      5. There are two hooks core\hook\output\before_standard_head_html_generation and core\hook\output\before_standard_top_of_body_html_generation that both say that they deprecate before_standard_html_head callback (the second one actually deprecates a different callback). They also have the same description
      6. Hooks mod_quiz\hook\attempt_state_changed and mod_quiz\hook\structure_modified should not list anything in the "deprecated lib.php callbacks" because they don't deprecate any callbacks, when they are emitted they do not try to call any legacy lib.php callbacks

      And finally, there are core_user\hook\extend_bulk_user_actions and core\hook\user\after_complete_login that are in different namespaces but really should be both under core_user. I guess it's late to change now because MDL-80332 was backported to 4.3

      For your consideration

            dobedobedoh Andrew Lyons
            marina Marina Glancy
            Huong Nguyen Huong Nguyen
            Jun Pataleta Jun Pataleta
            Jun Pataleta Jun Pataleta
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 day, 46 minutes
                1d 46m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.