Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-81549

Bump all versions, requires and dependencies near 4.4 release

XMLWordPrintable

    • Icon: Task Task
    • Resolution: Fixed
    • Icon: Minor Minor
    • 4.4
    • 4.4
    • General, Installation
    • MOODLE_404_STABLE
    • MOODLE_404_STABLE
    • MDL-81549-main
    • Hide

      A) Definition: "VERSION" == 2024042200 (planned release version/date)
      B) Definition: "REQUIRE" == 2024041600 (current Beta/RCX) - set to RC1

      export VERSION=2024042200
      		 
      export REQUIRE=2024041600

      0) TEST: Verify that CiBoT is completely green in this issue, specifically no lines having comments and missing full-stops should be reported.

      Only master needs to be tested with the following points:

      1) TEST: Visually verify that all the changes in the patch point to the correct "VERSION" versions and all the requires and dependencies point to the correct "REQUIRE" and nothing else is changed.

      • Note main version.php file must be >= "REQUIRE". Any dependency using the ANY_VERSION constant should remain unchanged by the patch.
      • Note that some lines may have comments with a final full-stop added if previously missing.

      2) Upgrade from 4.4dev version using the web interface

      • TEST: In the plugins screen ALL the plugins are showing "to upgrade" (or removed).
      • TEST: All the target versions show "VERSION" and all the dependencies show the "REQUIRE" version along the whole page.
      • TEST: Run upgrade. Ends without error.

      3) Verify that there isn't any plugin version.php file missing the "VERSION". Something like this should do the trick (ignore main version.php, that's ok, will be updated on release day):

      find . -name version.php | grep -v fixtures | xargs grep -L $VERSION

      4) Verify that there isn't any plugin version.php containing a comment with anything looking like a numeric version. Can be verified by checking that there aren't cases returned by:

      find . -name version.php | xargs grep -P '; *\/.*[0-9.]{3}'

      5) Verify that there isn't any plugin->release in core, it's no sense there. Can be verified running:

      find . -name version.php | xargs grep -P '>release' | grep -v fixtures

      6) TEST: To integrators, minutes after integration, verify the "Check version.php files (main)" job in the integration server ends without error, that everything points to "VERSION" / "REQUIRE" versions and that the report does not include any "ERROR" looking to the generated "versions_check_set.txt" file in the workspace. Note some "WARN" can exist. But that's not relevant for this issue.

      Show
      A) Definition: "VERSION" == 2024042200 (planned release version/date) B) Definition: "REQUIRE" == 2024041600 (current Beta/RCX) - set to RC1 export VERSION=2024042200 export REQUIRE=2024041600 0) TEST: Verify that CiBoT is completely green in this issue, specifically no lines having comments and missing full-stops should be reported. Only master needs to be tested with the following points: 1) TEST: Visually verify that all the changes in the patch point to the correct "VERSION" versions and all the requires and dependencies point to the correct "REQUIRE" and nothing else is changed. Note main version.php file must be >= "REQUIRE". Any dependency using the ANY_VERSION constant should remain unchanged by the patch. Note that some lines may have comments with a final full-stop added if previously missing. 2) Upgrade from 4.4dev version using the web interface TEST: In the plugins screen ALL the plugins are showing "to upgrade" (or removed). TEST: All the target versions show "VERSION" and all the dependencies show the "REQUIRE" version along the whole page. TEST: Run upgrade. Ends without error. 3) Verify that there isn't any plugin version.php file missing the "VERSION". Something like this should do the trick (ignore main version.php, that's ok, will be updated on release day): find . -name version.php | grep -v fixtures | xargs grep -L $VERSION 4) Verify that there isn't any plugin version.php containing a comment with anything looking like a numeric version. Can be verified by checking that there aren't cases returned by: find . -name version.php | xargs grep -P '; *\/.*[0-9.]{3}' 5) Verify that there isn't any plugin->release in core, it's no sense there. Can be verified running: find . -name version.php | xargs grep -P '>release' | grep -v fixtures 6) TEST: To integrators, minutes after integration, verify the "Check version.php files (main)" job in the integration server ends without error, that everything points to "VERSION" / "REQUIRE" versions and that the report does not include any "ERROR" looking to the generated "versions_check_set.txt" file in the workspace. Note some "WARN" can exist. But that's not relevant for this issue.

      This task corresponds to point #3 of:

      https://moodledev.io/general/development/process/release#1-week-prior

      And it's achieved in a semi-automated way with the "versions_check_set.sh" script available @ https://github.com/moodlehq/moodle-local_ci/blob/master/versions_check_set/versions_check_set.sh

      1) In a git, working, dev branch to be released site with the ci local plugin installed. Note that you may need to completely remove Composer's "vendor" directory and any non-core plugin.

      2) Define and export all the env variables required by the script.

      • $WORKSPACE: Path to the directory where test reults will be sent (/tmp)
      • $phpcmd: Path to the PHP CLI executable (/usr/bin/php)
      • $gitdir: Directory containing git repo (the dirroot of the git, working site)
      • $setversion: 10digits (YYYYMMDD00) to set all versions to. Empty = not set. Since Moodle 2.7 it has been agreed to perform the bump to the planned release version. For easier automated checks later in stable-land.
      • $setrequires: 10 digits (YYYYMMDD00) to set all required values. Empty = default to $setversion. Since Moodle 2.7, it has been agreed to perform the required bump to the current master version (usually an RC one).

      3) Run it. With errors, they will be reported and fixing will be necessary. (look for ERROR in the $WORKSPACE/versions_check_set.txt file and/or check exit status of the script)

      4) Without errors, all the versions, requires and dependencies will be bumped.

      5) Commit

      6) Note that the main version file is NOT updated at all. One extra commit bumping it may be necessary (to anything >= requires version).

      7) Run the checker again to verify that there are no errors and no more changes are performed.

      Note the checker is also run periodically by the ci server and also as part of the "remote_branch_checker", so normally all the version.php files should be under control.

      (This issue will be cloned for each major release).

      Ciao

        1. (1) 3 Passed -- (Main)MDL-81549.png
          (1) 3 Passed -- (Main)MDL-81549.png
          239 kB
        2. (1) 4 Passed -- (Main)MDL-81549.png
          (1) 4 Passed -- (Main)MDL-81549.png
          30 kB
        3. (1) 5 Passed -- (Main)MDL-81549.png
          (1) 5 Passed -- (Main)MDL-81549.png
          25 kB
        4. versions_check_set.txt
          176 kB

            jpataleta Jun Pataleta
            jpataleta Jun Pataleta
            Ilya Tregubov Ilya Tregubov
            Huong Nguyen Huong Nguyen
            Kim Jared Lucas Kim Jared Lucas
            Votes:
            1 Vote for this issue
            Watchers:
            7 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 3 hours
                3h

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.