Loading...

XML

Word

Printable

Type: Bug
Resolution: Fixed
Priority: Minor
Fix Version/s: 4.2.7, 4.3.4
Affects Version/s: 4.4
Component/s: Repositories
Labels:
- ci

Affected Branches:
MOODLE_404_STABLE
Fixed Branches:
MOODLE_402_STABLE, MOODLE_403_STABLE
Pull from Repository:
https://github.com/junpataleta/moodle.git
Pull 4.3 Branch:
~~MDL-81552~~-403
Pull 4.3 Diff URL:
https://github.com/junpataleta/moodle/compare/d706265b8e...MDL-81552-403
Pull Main Branch:
~~MDL-81552~~-main
Pull Main Diff URL:
https://github.com/junpataleta/moodle/compare/8cf14f6e70...MDL-81552-main
Testing Instructions:

Hide

Perform the tests described in ~~MDLQA-18745~~ and confirm it is passing.

Show
Perform the tests described in MDLQA-18745 and confirm it is passing.

Discovered by laurent.david@moodle.com while testing ~~MDLQA-18745~~.

The reason for this is likely the use of _user and user, password and _password:

In the constructor : https://github.com/moodle/moodle/blob/main/lib/webdavlib.php#L122
The use of the unitialized _user and _password here: https://github.com/moodle/moodle/blob/main/lib/webdavlib.php#L1357

- - Sort By Name
  - Sort By Date
  - Ascending
  - Descending
  - Thumbnails
  - List
  - Download All

screenshot-1.png
31 kB
17/Apr/24 2:57 PM

Discovered while testing

MDLQA-18745 CLONE - A user can access WebDav repository with basic authentication

Passed

has a non-specific relationship to

MDL-78159 PHP 8.2: Dynamic Properties are deprecated for core libraries

Closed

Assignee:: Jun Pataleta

Reporter:: Simey Lameze

Peer reviewer:: Laurent David

Integrator:: Huong Nguyen

Tester:: Laurent David

Participants:: CiBoT, Huong Nguyen, Jun Pataleta, Laurent David, Simey Lameze

Votes:: 0 Vote for this issue

Watchers:: 3 Start watching this issue

Created:: 16/Apr/24 8:35 AM

Updated:: 19/Apr/24 7:04 PM

Resolved:: 19/Apr/24 6:59 PM

Estimated:

0m

Remaining:

0m

Logged:

2h