Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-81569

Some core tests fail if add-on plugins define custom roles

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • 4.4
    • 4.4
    • Repositories

      Our Workplace plugins add some roles on installation. Starting from Moodle 4.4 we have the failures like this:

      1) repository_equella\lib_test::test_repository_is_created
      coding_exception: Coding error detected, it must be fixed by a programmer: equella_tool_tenant_manager_shareid must be present in testing_repository_generator::create_instance() $record
       
      /var/www/html/lib/testing/generator/repository_generator.php:140
      /var/www/html/repository/equella/tests/lib_test.php:80
      /var/www/html/repository/equella/tests/lib_test.php:236
      /var/www/html/repository/equella/tests/lib_test.php:91
      /var/www/html/lib/phpunit/classes/advanced_testcase.php:72
      

      I can see that in MDL-79959 list of the standard roles was hardcoded in the repository_equela generator.

      1) tool_uploadcourse\course_test::test_invalid_role
      Failed asserting that true is false.
       
      /var/www/html/admin/tool/uploadcourse/tests/course_test.php:270
      /var/www/html/lib/phpunit/classes/advanced_testcase.php:72
      

      Added in MDL-43056

            marina Marina Glancy
            marina Marina Glancy
            Carlos Castillo Carlos Castillo
            Ilya Tregubov Ilya Tregubov
            CiBoT CiBoT
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 hour, 25 minutes
                1h 25m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.