Loading...

XML

Word

Printable

Affected Branches:
MOODLE_404_STABLE
Fixed Branches:
MOODLE_405_STABLE
Pull from Repository:
https://github.com/paulholden/moodle.git
Pull Main Branch:
~~MDL-81572~~
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/main...paulholden:MDL-81572
Documentation link:
https://github.com/moodle/devdocs/pull/1034
Testing Instructions:
Hide

Log in as admin

Navigate to own profile

Press Edit profile

In the Description field editor, press Help > Help

Press Plugins

Confirm presence of Moodle TinyMCE plugins, e.g.

Accessibility checker

Tiny autosave

Tiny equation editor

etc...

Execute the following:

$ git grep -B1 helplinktext

Confirm all references in language string files are preceded by the following line:

// Deprecated since Moodle 4.5.
Show
Log in as admin Navigate to own profile Press Edit profile In the Description field editor, press Help > Help Press Plugins Confirm presence of Moodle TinyMCE plugins, e.g. Accessibility checker Tiny autosave Tiny equation editor etc... Execute the following: $ git grep -B1 helplinktext Confirm all references in language string files are preceded by the following line: // Deprecated since Moodle 4.5.

See related issues where we never define the 'helplinktext' language string: ~~MDL-81570~~, ~~MDL-79237~~, ~~MDL-79089~~, ~~MDL-77874~~

It's shown here (Help > Help > Plugins in the editor):

It seems like half the time we append the word "helper" and half the time we use the original plugin name:

$ git grep -I helplinktext

lib/editor/tiny/amd/src/utils.js:    const name = await getString('helplinktext', component);

lib/editor/tiny/plugins/accessibilitychecker/lang/en/tiny_accessibilitychecker.php:$string['helplinktext'] = 'Accessibility helper';

lib/editor/tiny/plugins/autosave/lang/en/tiny_autosave.php:$string['helplinktext'] = 'Autosave';

lib/editor/tiny/plugins/equation/lang/en/tiny_equation.php:$string['helplinktext'] = 'Equation helper';

lib/editor/tiny/plugins/h5p/lang/en/tiny_h5p.php:$string['helplinktext'] = 'H5P helper';

lib/editor/tiny/plugins/html/lang/en/tiny_html.php:$string['helplinktext'] = 'HTML format helper';

lib/editor/tiny/plugins/link/lang/en/tiny_link.php:$string['helplinktext'] = 'Link';

lib/editor/tiny/plugins/media/lang/en/tiny_media.php:$string['helplinktext'] = 'Media helper';

lib/editor/tiny/plugins/noautolink/lang/en/tiny_noautolink.php:$string['helplinktext'] = 'No auto-link helper';

lib/editor/tiny/plugins/recordrtc/lang/en/tiny_recordrtc.php:$string['helplinktext'] = 'RecordRTC';

I propose we re-use the 'pluginname' language string, that will always exist

has been marked as being related by

MDL-81570 Tiny editor "Premium" plugin missing language string debugging

Participants:: Andrew Lyons, CiBoT, Helen Foster, Jun Pataleta, Kim Jared Lucas, Paul Holden, Sara Arjona (@sarjona)

Estimated:

Remaining:

Logged:

40m