Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-81572

Re-use native plugin name for TinyMCE instead of custom "helper" version

Details

    • Improvement
    • Resolution: Unresolved
    • Minor
    • None
    • 4.4
    • Text editor TinyMCE
    • MOODLE_404_STABLE
    • Hide
      1. Log in as admin
      2. Navigate to own profile
      3. Press Edit profile
      4. In the Description field editor, press Help > Help
      5. Press Plugins
      6. Confirm presence of Moodle TinyMCE plugins, e.g.

        Accessibility checker
        Tiny autosave
        Tiny equation editor
        etc...
        

      7. Execute the following:

        $ git grep -B1 helplinktext
        

      8. Confirm all references in language string files are preceded by the following line:

        // Deprecated since Moodle 4.5.
        

      Show
      Log in as admin Navigate to own profile Press Edit profile In the Description field editor, press Help > Help Press Plugins Confirm presence of Moodle TinyMCE plugins, e.g. Accessibility checker Tiny autosave Tiny equation editor etc... Execute the following: $ git grep -B1 helplinktext Confirm all references in language string files are preceded by the following line: // Deprecated since Moodle 4.5.

    Description

      See related issues where we never define the 'helplinktext' language string: MDL-81570, MDL-79237, MDL-79089, MDL-77874

      It's shown here (Help > Help > Plugins in the editor):

      It seems like half the time we append the word "helper" and half the time we use the original plugin name:

      $ git grep -I helplinktext
      lib/editor/tiny/amd/src/utils.js:    const name = await getString('helplinktext', component);
      lib/editor/tiny/plugins/accessibilitychecker/lang/en/tiny_accessibilitychecker.php:$string['helplinktext'] = 'Accessibility helper';
      lib/editor/tiny/plugins/autosave/lang/en/tiny_autosave.php:$string['helplinktext'] = 'Autosave';
      lib/editor/tiny/plugins/equation/lang/en/tiny_equation.php:$string['helplinktext'] = 'Equation helper';
      lib/editor/tiny/plugins/h5p/lang/en/tiny_h5p.php:$string['helplinktext'] = 'H5P helper';
      lib/editor/tiny/plugins/html/lang/en/tiny_html.php:$string['helplinktext'] = 'HTML format helper';
      lib/editor/tiny/plugins/link/lang/en/tiny_link.php:$string['helplinktext'] = 'Link';
      lib/editor/tiny/plugins/media/lang/en/tiny_media.php:$string['helplinktext'] = 'Media helper';
      lib/editor/tiny/plugins/noautolink/lang/en/tiny_noautolink.php:$string['helplinktext'] = 'No auto-link helper';
      lib/editor/tiny/plugins/recordrtc/lang/en/tiny_recordrtc.php:$string['helplinktext'] = 'RecordRTC';
      

      I propose we re-use the 'pluginname' language string, that will always exist

      Attachments

        1. Editor plugins.png
          Editor plugins.png
          67 kB
        2. TinyMCE Plugins.png
          TinyMCE Plugins.png
          84 kB
        3. tinypluginshelp.png
          tinypluginshelp.png
          18 kB

        Issue Links

          Activity

            People

              pholden Paul Holden
              pholden Paul Holden
              Sara Arjona (@sarjona) Sara Arjona (@sarjona)
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated:

                Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 20 minutes
                  20m

                  Clockify

                    Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.