Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-81590

Windows zipwriter_test phpunit failures

XMLWordPrintable

    • MOODLE_404_STABLE
    • MOODLE_403_STABLE, MOODLE_404_STABLE
    • MDL-81590-403
    • MDL-81590-404
    • MDL-81590-main
    • Hide
      1. Log in as admin
      2. Go to Site administration / Course / Download course content.
      3. Enable the "Download course content feature available" setting.
      4. Save the changes
      5. Download and restore this course backup: TestForCourseDownload.mbz
        • If the asynchronous backup is turned on, you may need to run cron to complete the course restore.
      6. Edit the course's settings and set "Enabled download course content" to Yes if it's not enabled. Save the changes.
      7. Go to the course homepage
      8. Open the More menu and select "Download course content" and confirm the download.
      9. Extract the downloaded zip file
      10. Open index.html on your browser.
      11. Confirm that you can explore the course contents.
        • Note: If you test this on Windows without the patch, the HTML file will be full of broken links. This is fixed with this patch.
      Show
      Log in as admin Go to Site administration / Course / Download course content. Enable the " Download course content feature available " setting. Save the changes Download and restore this course backup: TestForCourseDownload.mbz If the asynchronous backup is turned on, you may need to run cron to complete the course restore. Edit the course's settings and set " Enabled download course content " to Yes if it's not enabled. Save the changes. Go to the course homepage Open the More menu and select " Download course content " and confirm the download. Extract the downloaded zip file Open index.html on your browser. Confirm that you can explore the course contents. Note: If you test this on Windows without the patch, the HTML file will be full of broken links. This is fixed with this patch.

      For 4.4 and up we are getting two consistent failures with PHPUnit and Windows:

      1) core\content\export\zipwriter_test::test_add_file_from_stored_file
      Failed asserting that false matches expected 'image contents'.
       
      C:\Users\stronk7\git_moodle\integration\lib\tests\content\export\zipwriter_test.php:73
      C:\Users\stronk7\git_moodle\integration\lib\phpunit\classes\advanced_testcase.php:74
       
      2) core\content\export\zipwriter_test::test_add_file_from_string
      Failed asserting that false matches expected 'Zippidy do dah'.
      

      Worth noting that they passing ok in previous branches (403, 402, ...).

            jpataleta Jun Pataleta
            stronk7 Eloy Lafuente (stronk7)
            Safat Shahin Safat Shahin
            Shamim Rezaie Shamim Rezaie
            Ron Carl Alfon Yu Ron Carl Alfon Yu
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 7 hours, 29 minutes
                7h 29m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.