Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-81683

Add subsections to the move activity modal.

XMLWordPrintable

    • MOODLE_405_STABLE
    • MOODLE_405_STABLE
    • MDL-81683-main
    • Hide

      Setup:

      1. Go to "site administration -> plugins -> activity plugins" and enable subsection plugin
      2. Create a course C1 with:
      3. 3 sections
      4. One subsection Sub1 in section 1
      5. One assignment A1 in Sub1
      6. One assignment A2 in section 2
      7. One subsection Sub2 in section 2

      Move modal test and accessibility:

      1. Go on the Subsection Sub1 page and select the "Move" action in the contextual menu
      2. Ensure that you see the full tree with the 3 section and the subsection as well as A1 and A2
      3. Ensure that the layout and style matches the MDL-81684 mockup
      4. Click within the Move Activity dialog and hit the tab key
      5. Ensure that the keyboard navigation works : items should expand /collapse, and the focus goes from one item to the other

      Subsection move test and accessibility:

      1. Go to C1
      2. Select the "Move" action in the Sub1 contextual menu
      3. Ensure you cannot move Sub1 over itself (or any activity inside Sub1)
      4. Ensure you cannot move Sub1 over Sub2 (or any activity inside Sub2)
      5. Close the dialog
      6. Select the "Move" action in the A1 contextual menu{}
      7. Ensure you can move A1 in Sub2

      Subsection expansion:

      1. Go to Subsection S1 page
      2. Select the "Move" action on the activity present in Sub1 (normally A1, but any should do)
      3. Ensure that the tree expands right to the activity selected (A1) and that the subsection folder is expanded recursively (Section 1 > Subsection > Activity)
      Show
      Setup: Go to "site administration -> plugins -> activity plugins" and enable subsection plugin Create a course C1 with: 3 sections One subsection Sub1 in section 1 One assignment A1 in Sub1 One assignment A2 in section 2 One subsection Sub2 in section 2 Move modal test and accessibility: Go on the Subsection Sub1 page and select the "Move" action in the contextual menu Ensure that you see the full tree with the 3 section and the subsection as well as A1 and A2 Ensure that the layout and style matches the MDL-81684 mockup Click within the Move Activity dialog and hit the tab key Ensure that the keyboard navigation works : items should expand /collapse, and the focus goes from one item to the other Subsection move test and accessibility: Go to C1 Select the "Move" action in the Sub1 contextual menu Ensure you cannot move Sub1 over itself (or any activity inside Sub1) Ensure you cannot move Sub1 over Sub2 (or any activity inside Sub2) Close the dialog Select the "Move" action in the A1 contextual menu { } Ensure you can move A1 in Sub2 Subsection expansion: Go to Subsection S1 page Select the "Move" action on the activity present in Sub1 (normally A1, but any should do) Ensure that the tree expands right to the activity selected (A1) and that the subsection folder is expanded recursively (Section 1 > Subsection > Activity)
    • 5
    • HQ 2024 Sprint I2.3 Moppies

      This issue is part of the course hierarch project.

      Issue goals

      Once activities can act as subsections (mod_subsection), the move activity modal should also display that kind of activity.

      This mean:

      • Any activity with a delegated section integration must be displayed as a tree node with all subactivities listed under it.
      • Clicking the mod_subsection will move the activity on top of the subsection. However, this has a limitation because there is no way to way to indicate you want the activity just under the subsection. This will require a UX review (there is a larger explanation on that in the next section).
      • Validate the keyboard navigation still works as expected.

      Ux review required

      The current modal has the following behaviour:

      • Clicking on a section moves the element on top of that section
      • Clicking on an activity moves the element under the activity

      This approach was the best for a single-level hierarchy because the user can move the activity anywhere in the course without limitation. However, the mod_subsection will act as both a section and an activity, creating a problem.

      If mod_subsection acts only as a section, moving an element just below the subsection is impossible. Similarly, if it acts as an activity, moving an element on top of the subsection is impossible.

      There are a couple of approaches I can think of:

      1. Assume that limitation and implement only the most useful one. This will force some movements to use twice the move action to get some specific positions.
      2. Add a new link in the modal to cover those particular cases. For example, adding a "move under" next to the mod_subsection name or a "move on top" just under the mod_subsection name. In the end, it implies adding an extra "move here" link for the locations that are not selectable.

      Future issues

      For accessibility reasons, activities must be moved using a click UI rather than drag and drop, so this issue must be resolved before integrating the mod_subsection into the core.

       

        1. MDL-81683-1.png
          MDL-81683-1.png
          145 kB
        2. MDL-81683 - 2.png
          MDL-81683 - 2.png
          206 kB
        3. MDL-81683 -3.png
          MDL-81683 -3.png
          144 kB
        4. Move modal.png
          Move modal.png
          256 kB
        5. screenshot-1.png
          screenshot-1.png
          24 kB

            laurent.david@moodle.com Laurent David
            tusefomal Ferran Recio
            Mikel Martín Corrales Mikel Martín Corrales
            Ferran Recio Ferran Recio
            Ron Carl Alfon Yu Ron Carl Alfon Yu
            Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 3 days, 30 minutes
                3d 30m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.