Loading...

XML

Word

Printable

Type: Bug
Resolution: Unresolved
Priority: Minor
Fix Version/s: None
Affects Version/s: 4.3.3, 4.4.5, 4.5
Component/s: Communication
Labels:

Affected Branches:
MOODLE_403_STABLE, MOODLE_404_STABLE, MOODLE_405_STABLE
Pull from Repository:
https://github.com/mark-webster-catalyst/moodle
Pull 4.4 Branch:
MDL-81685_matrix_homeserver_name_404
Pull 4.4 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_404_STABLE...mark-webster-catalyst:moodle:MDL-81685_matrix_homeserver_name_404
Pull 4.5 Branch:
MDL-81685_matrix_homeserver_name_405
Pull 4.5 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_405_STABLE...mark-webster-catalyst:moodle:MDL-81685_matrix_homeserver_name_405
Pull Main Branch:
MDL-81685_matrix_homeserver_name_main
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/main...mark-webster-catalyst:moodle:MDL-81685_matrix_homeserver_name_main
Testing Instructions:

Hide

Set up the matrix integration with a homeserver whose name is set to be different than the URL.

Observe, that when setting communication_matrix/matrixhomeservername is set, usernames are generated correctly based on the homeservername, rather than the URL

Show
Set up the matrix integration with a homeserver whose name is set to be different than the URL. Observe, that when setting communication_matrix/matrixhomeservername is set, usernames are generated correctly based on the homeservername, rather than the URL
Pre-check results:
Hide

Code verified against automated checks with warnings.

Checked MDL-81685 using repository: https://github.com/mark-webster-catalyst/moodle

MOODLE_404_STABLE (0 errors / 1 warnings) [branch: MDL-81685_matrix_homeserver_name_404 | CI Job]

overview (0/0), phplint (0/0), phpcs (0/1), js (0/0), css (0/0), phpdoc (0/0), commit (0/0), savepoint (0/0), thirdparty (0/0), externalbackup (0/0), grunt (0/0), shifter (0/0), mustache (0/0), gherkin (0/0),

MOODLE_405_STABLE (0 errors / 1 warnings) [branch: MDL-81685_matrix_homeserver_name_405 | CI Job]

overview (0/0), phplint (0/0), phpcs (0/1), js (0/0), css (0/0), phpdoc (0/0), commit (0/0), savepoint (0/0), thirdparty (0/0), externalbackup (0/0), grunt (0/0), shifter (0/0), mustache (0/0), gherkin (0/0),

main (0 errors / 1 warnings) [branch: MDL-81685_matrix_homeserver_name_main | CI Job]

overview (0/0), phplint (0/0), phpcs (0/1), js (0/0), css (0/0), phpdoc (0/0), commit (0/0), savepoint (0/0), thirdparty (0/0), externalbackup (0/0), grunt (0/0), shifter (0/0), mustache (0/0), gherkin (0/0),

Should these errors be fixed?

Built on: Fri 15 Nov 2024 08:58:26 AM UTC
Show
Code verified against automated checks with warnings. Checked MDL-81685 using repository: https://github.com/mark-webster-catalyst/moodle MOODLE_404_STABLE (0 errors / 1 warnings) [branch: MDL-81685_matrix_homeserver_name_404 | CI Job ] overview (0/0) , phplint (0/0) , phpcs (0/1) , js (0/0) , css (0/0) , phpdoc (0/0) , commit (0/0) , savepoint (0/0) , thirdparty (0/0) , externalbackup (0/0) , grunt (0/0) , shifter (0/0) , mustache (0/0) , gherkin (0/0) , MOODLE_405_STABLE (0 errors / 1 warnings) [branch: MDL-81685_matrix_homeserver_name_405 | CI Job ] overview (0/0) , phplint (0/0) , phpcs (0/1) , js (0/0) , css (0/0) , phpdoc (0/0) , commit (0/0) , savepoint (0/0) , thirdparty (0/0) , externalbackup (0/0) , grunt (0/0) , shifter (0/0) , mustache (0/0) , gherkin (0/0) , main (0 errors / 1 warnings) [branch: MDL-81685_matrix_homeserver_name_main | CI Job ] overview (0/0) , phplint (0/0) , phpcs (0/1) , js (0/0) , css (0/0) , phpdoc (0/0) , commit (0/0) , savepoint (0/0) , thirdparty (0/0) , externalbackup (0/0) , grunt (0/0) , shifter (0/0) , mustache (0/0) , gherkin (0/0) , Should these errors be fixed? Built on: Fri 15 Nov 2024 08:58:26 AM UTC
Automated test results:
Hide

Launching automatic jobs for branch MDL-81685_matrix_homeserver_name_404

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17361/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59246/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59247/ Behat (Firefox - boost)

Launching automatic jobs for branch MDL-81685_matrix_homeserver_name_405

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17362/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59248/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59249/ Behat (Firefox - boost)

Launching automatic jobs for branch MDL-81685_matrix_homeserver_name_main

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17363/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59250/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59251/ Behat (Firefox - boost)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59252/ Behat (Firefox - classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59253/ App tests (stable app version)

Built on: Fri Nov 15 10:27:16 UTC 2024
Show
Launching automatic jobs for branch MDL-81685 _matrix_homeserver_name_404 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17361/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59246/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59247/ Behat (Firefox - boost) Launching automatic jobs for branch MDL-81685 _matrix_homeserver_name_405 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17362/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59248/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59249/ Behat (Firefox - boost) Launching automatic jobs for branch MDL-81685 _matrix_homeserver_name_main https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17363/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59250/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59251/ Behat (Firefox - boost) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59252/ Behat (Firefox - classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59253/ App tests (stable app version) Built on: Fri Nov 15 10:27:16 UTC 2024

When configuring a Matrix server a matrixhomeserverurl of "https://matrix.example.com" Moodle assumes that the Matrix userid should be "@user:matrix.example.com".
This is often not the case, though.
On our Matrix instance the userids look like "@user:example.com", though the server is "https://matrixserver.example.com".

The relevant function is:

get_formatted_matrix_userid()

in:

communication/provider/matrix/classes/matrix_user_manager.php

I would suggest to add a configuration option to define the userid format.

has a non-specific relationship to

MDL-83771 Matrix integration can create incorrect usernames for logging in via SAML

Open

Assignee:: Mark Webster

Reporter:: Tobias Marx

Peer reviewer:: Mark Johnson

Participants:: Mark Johnson, Mark Webster, Michael Hawkins, Tobias Marx

Votes:: 1 Vote for this issue

Watchers:: 4 Start watching this issue

Created:: 25/Apr/24 6:01 PM

Updated:: 20/Nov/24 7:44 PM

Details

Description

Attachments

Issue Links

Activity

People

Dates

Clockify