Loading...

XML

Word

Printable

Type: Improvement
Resolution: Fixed
Priority: Minor
Fix Version/s: 5.0
Affects Version/s: 4.5
Component/s: Themes
Labels:

Affected Branches:
MOODLE_405_STABLE
Fixed Branches:
MOODLE_500_STABLE
Epic Link:
Bootstrap 5.x Upgrade
Pull from Repository:
https://github.com/roland04/moodle.git
Pull Main Branch:
~~MDL-81825~~-main
Pull Main Diff URL:
https://github.com/roland04/moodle/compare/0888a6d324...MDL-81825-main
Documentation link:
https://github.com/moodle/devdocs/pull/1182
Testing Instructions:
Hide

Test

Make sure you clear caches (browser + moodle)

Login as administrator

Go to the dashboard page

Confirm "Skip to main content" element is NOT displayed at the top left corner

Press Tab key

Confirm "Skip to main content" element IS displayed at the top left corner

Open the browser developer tools

Search for "Skip to main content" text

Confirm that the <a> element has "visually-hidden" and "visually-hidden-focusable"classes
Show
Test Make sure you clear caches (browser + moodle) Login as administrator Go to the dashboard page Confirm "Skip to main content" element is NOT displayed at the top left corner Press Tab key Confirm "Skip to main content" element IS displayed at the top left corner Open the browser developer tools Search for "Skip to main content" text Confirm that the <a> element has "visually-hidden" and "visually-hidden-focusable"classes
Pre-check results:
Hide

Code verified against automated checks with warnings.

Checked ~~MDL-81825~~ using repository: https://github.com/roland04/moodle.git

main (0 errors / 121 warnings) [branch: MDL-81825-main | CI Job]

overview (0/0), phplint (0/0), phpcs (0/0), js (0/0), css (0/0), phpdoc (0/0), commit (0/0), savepoint (0/0), thirdparty (0/0), externalbackup (0/0), grunt (0/0), shifter (0/0), mustache (0/121), gherkin (0/0),

Should these errors be fixed?

Built on: Mon 18 Nov 2024 08:32:57 PM UTC
Show
Code verified against automated checks with warnings. Checked MDL-81825 using repository: https://github.com/roland04/moodle.git main (0 errors / 121 warnings) [branch: MDL-81825-main | CI Job ] overview (0/0) , phplint (0/0) , phpcs (0/0) , js (0/0) , css (0/0) , phpdoc (0/0) , commit (0/0) , savepoint (0/0) , thirdparty (0/0) , externalbackup (0/0) , grunt (0/0) , shifter (0/0) , mustache (0/121) , gherkin (0/0) , Should these errors be fixed? Built on: Mon 18 Nov 2024 08:32:57 PM UTC
Automated test results:
Hide

Launching automatic jobs for branch ~~MDL-81825~~-main

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17382/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59322/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59323/ Behat (Firefox - boost)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59324/ Behat (Firefox - classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59325/ App tests (stable app version)

Built on: Mon Nov 18 08:25:14 PM UTC 2024
Show
Launching automatic jobs for branch MDL-81825 -main https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17382/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59322/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59323/ Behat (Firefox - boost) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59324/ Behat (Firefox - classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59325/ App tests (stable app version) Built on: Mon Nov 18 08:25:14 PM UTC 2024

Story Points:
3
Sprint:
HQ 2024 Sprint I4.1 Moppies

In BS5 the"Screen reader" classes and functions have been renamed.

Generate the needed SCSS code in bs5bridge.scss (so we can start using BS5 syntax) and refactor all the occurrences in the codebase.

https://getbootstrap.com/docs/5.2/migration/:

"Screen reader" classes are now "visually hidden" classes.

Changed the Sass file from scss/helpers/_screenreaders.scss to scss/helpers/_visually-hidden.scss

Renamed .sr-only and .sr-only-focusable to .visually-hidden and .visually-hidden-focusable

Renamed sr-only() and sr-only-focusable() mixins to visually-hidden() and visually-hidden-focusable().

This issue should also be included in the BS4 compatibility layer in MDL-80519

- - Sort By Name
  - Sort By Date
  - Ascending
  - Descending
  - Thumbnails
  - List
  - Download All

(1) 4 Passed -- (Main)MDL-81825.png
97 kB
11/Dec/24 2:48 PM
(1) 6 Passed -- (Main)MDL-81825.png
76 kB
11/Dec/24 2:48 PM
(1) 9 Passed -- (Main)MDL-81825.png
153 kB
11/Dec/24 2:48 PM
screenshot-1.png
37 kB
11/Nov/24 8:30 PM
screenshot-2.png
41 kB
11/Nov/24 8:30 PM
screenshot-3.png
256 kB
11/Nov/24 8:32 PM

has to be done before

MOBILE-4598 Support some of the features included in the Bootstrap 5 bridge

Closed

MDL-83671 Final removal of core_renderer::sr_text

Open

is child of

MDL-79917 Investigate the creation of a Bootstrap v5 SCSS "bridge" before the full upgrade

Closed

mentioned in: Page Loading...

Assignee:: Mikel Martín Corrales

Reporter:: Mikel Martín Corrales

Peer reviewer:: Laurent David

Integrator:: Ferran Recio

Tester:: Kim Jared Lucas

Participants:: CiBoT, Ferran Recio, Huong Nguyen, Kim Jared Lucas, Laurent David, Mikel Martín Corrales

Votes:: 0 Vote for this issue

Watchers:: 8 Start watching this issue

Created:: 07/May/24 10:38 PM

Updated:: 13/Dec/24 10:41 AM

Resolved:: 13/Dec/24 10:41 AM

Estimated:

Not Specified

Remaining:

Logged:

1h 5m

Details

Test

Description

Attachments

Attachments

Issue Links

Activity

People

Dates

Time Tracking

Clockify