Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-81867

Remove phantom question bank plugin created by MDL-81380

XMLWordPrintable

    • MOODLE_403_STABLE, MOODLE_404_STABLE
    • MOODLE_403_STABLE, MOODLE_404_STABLE
    • MDL-81867-403
    • MDL-81867-404
    • Hide
      1. Check out a version prior to MDL-81380, e.g. the weekly prior: 

        $ git checkout 792698af000c3fb598b15f4d048fa76e02fbef50 # main

      2. Install site
      3. Check out the latest weekly release after MDL-81380 and before this patch: 

        $ git checkout 67b2c43225285ddc63ee17fa05b03e4f339cf2af # main

      4. Run upgrade
      5. Log in as admin
      6. Navigate to Plugins > Plugins overview in site administration
      7. Note the presence of qbank_qbank_columnsortorder plugin (Missing from disk)
      8. Check out the branch with this patch applied: 

        $ git checkout main

      9. Run upgrade
      10. Navigate back to Plugins > Plugins overview in site administration
      11. Confirm that qbank_qbank_columnsortorder plugin is no longer present
      Show
      Check out a version prior to MDL-81380 , e.g. the weekly prior: $ git checkout 792698af000c3fb598b15f4d048fa76e02fbef50 # main Install site Check out the latest weekly release after MDL-81380 and before this patch: $ git checkout 67b2c43225285ddc63ee17fa05b03e4f339cf2af # main Run upgrade Log in as admin Navigate to Plugins > Plugins overview in site administration Note the presence of qbank_qbank_columnsortorder plugin (Missing from disk) Check out the branch with this patch applied: $ git checkout main Run upgrade Navigate back to Plugins > Plugins overview in site administration Confirm that qbank_qbank_columnsortorder plugin is no longer present

      The arguments passed in the plugin savepoint call: https://github.com/moodle/moodle/commit/5ced156252d5341efd6738c1dfaf5307f94f499c#diff-61c017a10caf3c9e97bd8a302cadaae5f40549954ff28e37f7e228eee7974eb2R70 from MDL-81380 end up create a plugin entry for a non-existing plugin (qbank_qbank_columnsortorder):

      This creates a problem when you subsequently upgrade to the next weekly release:

      & also shows as a phantom plugin in the overview page:

      We should fix the original code, and cleanup the plugin entry (we've fixed similar in MDL-77774 before)

        1. MDL-81867.png
          MDL-81867.png
          370 kB
        2. Screenshot 2024-05-10 at 08-33-28 Plugins check Moodle Master.png
          Screenshot 2024-05-10 at 08-33-28 Plugins check Moodle Master.png
          42 kB
        3. Screenshot 2024-05-10 at 08-49-09 Plugins overview Plugins Administration Moodle 4.3.png
          Screenshot 2024-05-10 at 08-49-09 Plugins overview Plugins Administration Moodle 4.3.png
          44 kB

            pholden Paul Holden
            pholden Paul Holden
            Huong Nguyen Huong Nguyen
            Tim Hunt Tim Hunt
            Ron Carl Alfon Yu Ron Carl Alfon Yu
            Votes:
            0 Vote for this issue
            Watchers:
            11 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 hour, 33 minutes
                1h 33m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.