Moodle
  1. Moodle
  2. MDL-8187

new mnet code does not use SITEID to find out if course is site

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Won't Fix
    • Affects Version/s: 1.8, 2.3.1
    • Fix Version/s: None
    • Component/s: MNet
    • Labels:
      None
    • Affected Branches:
      MOODLE_18_STABLE, MOODLE_23_STABLE
    • Rank:
      1043

      Description

      around line 117 in course/report/log/lib.php
      if (1 == $cc->course) {
      does not seem to be correct because site course is not guarateed to have id 1

      I am going to commit fix for if($cc->category) which was obsoleted loong ago, correct way is to compare course id with SITEID, the problem is I do not know how to find out the correct SITEID from remote site...

        Issue Links

          Activity

          Petr Škoda created issue -
          Martín Langhoff made changes -
          Field Original Value New Value
          Component/s Networking [ 10162 ]
          Component/s General [ 10049 ]
          Petr Škoda made changes -
          Fix Version/s 1.8.1 [ 10213 ]
          Martin Dougiamas made changes -
          Fix Version/s 1.8.2 [ 10220 ]
          Fix Version/s 1.8.1 [ 10213 ]
          Martin Dougiamas made changes -
          Fix Version/s 1.8.3 [ 10230 ]
          Fix Version/s 1.8.2 [ 10220 ]
          Donal McMullan made changes -
          Assignee Martín Langhoff [ martinlanghoff ] Donal McMullan [ donal@catalyst.net.nz ]
          Martin Dougiamas made changes -
          Fix Version/s 1.8.4 [ 10242 ]
          Fix Version/s 1.8.3 [ 10230 ]
          Martin Dougiamas made changes -
          Fix Version/s 1.8.5 [ 10252 ]
          Fix Version/s 1.8.4 [ 10242 ]
          Eloy Lafuente (stronk7) made changes -
          Fix Version/s 1.8.6 [ 10270 ]
          Fix Version/s 1.8.5 [ 10252 ]
          Petr Škoda made changes -
          Fix Version/s 1.9.3 [ 10290 ]
          Fix Version/s 1.8.6 [ 10270 ]
          Martin Dougiamas made changes -
          Assignee Donal McMullan [ donal@catalyst.net.nz ] Nobody [ nobody ]
          Martin Dougiamas made changes -
          Fix Version/s 1.9.4 [ 10300 ]
          Fix Version/s 1.9.3 [ 10290 ]
          Petr Škoda made changes -
          Fix Version/s 1.9.5 [ 10320 ]
          Fix Version/s 1.9.4 [ 10300 ]
          Petr Škoda made changes -
          Fix Version/s 1.9.6 [ 10340 ]
          Fix Version/s 1.9.5 [ 10320 ]
          Martin Dougiamas made changes -
          Fix Version/s 1.9.7 [ 10360 ]
          Fix Version/s 1.9.6 [ 10340 ]
          Eloy Lafuente (stronk7) made changes -
          Fix Version/s 1.9.8 [ 10400 ]
          Fix Version/s 1.9.7 [ 10360 ]
          Penny Leach made changes -
          Link This issue will help resolve MDL-21260 [ MDL-21260 ]
          Martin Dougiamas made changes -
          Fix Version/s 1.9.9 [ 10405 ]
          Fix Version/s 1.9.8 [ 10400 ]
          Martin Dougiamas made changes -
          Fix Version/s 1.9.10 [ 10407 ]
          Fix Version/s 1.9.9 [ 10405 ]
          Martin Dougiamas made changes -
          Fix Version/s 1.9.11 [ 10410 ]
          Fix Version/s 1.9.10 [ 10407 ]
          Martin Dougiamas made changes -
          Workflow jira [ 19087 ] MDL Workflow [ 41936 ]
          Martin Dougiamas made changes -
          Fix Version/s 1.9.12 [ 10536 ]
          Fix Version/s 1.9.11 [ 10410 ]
          Martin Dougiamas made changes -
          Workflow MDL Workflow [ 41936 ] MDL Full Workflow [ 70370 ]
          Martin Dougiamas made changes -
          Fix Version/s STABLE backlog [ 10463 ]
          Fix Version/s 1.9.12 [ 10536 ]
          Dan Poltawski made changes -
          Affects Version/s 2.3.1 [ 12253 ]
          David Mudrak made changes -
          Status Open [ 1 ] Closed [ 6 ]
          Fix Version/s STABLE backlog [ 10463 ]
          Resolution Won't Fix [ 2 ]

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: