Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-8187

new mnet code does not use SITEID to find out if course is site

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Won't Fix
    • Affects Version/s: 1.8, 2.3.1
    • Fix Version/s: None
    • Component/s: MNet
    • Labels:
      None
    • Affected Branches:
      MOODLE_18_STABLE, MOODLE_23_STABLE

      Description

      around line 117 in course/report/log/lib.php
      if (1 == $cc->course) {
      does not seem to be correct because site course is not guarateed to have id 1

      I am going to commit fix for if($cc->category) which was obsoleted loong ago, correct way is to compare course id with SITEID, the problem is I do not know how to find out the correct SITEID from remote site...

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

              skodak Petr Skoda created issue -
              martinlanghoff Martín Langhoff made changes -
              Field Original Value New Value
              Component/s Networking [ 10162 ]
              Component/s General [ 10049 ]
              skodak Petr Skoda made changes -
              Fix Version/s 1.8.1 [ 10213 ]
              dougiamas Martin Dougiamas made changes -
              Fix Version/s 1.8.2 [ 10220 ]
              Fix Version/s 1.8.1 [ 10213 ]
              dougiamas Martin Dougiamas made changes -
              Fix Version/s 1.8.3 [ 10230 ]
              Fix Version/s 1.8.2 [ 10220 ]
              donal@catalyst.net.nz Donal McMullan made changes -
              Assignee Martín Langhoff [ martinlanghoff ] Donal McMullan [ donal@catalyst.net.nz ]
              dougiamas Martin Dougiamas made changes -
              Fix Version/s 1.8.4 [ 10242 ]
              Fix Version/s 1.8.3 [ 10230 ]
              dougiamas Martin Dougiamas made changes -
              Fix Version/s 1.8.5 [ 10252 ]
              Fix Version/s 1.8.4 [ 10242 ]
              stronk7 Eloy Lafuente (stronk7) made changes -
              Fix Version/s 1.8.6 [ 10270 ]
              Fix Version/s 1.8.5 [ 10252 ]
              skodak Petr Skoda made changes -
              Fix Version/s 1.9.3 [ 10290 ]
              Fix Version/s 1.8.6 [ 10270 ]
              dougiamas Martin Dougiamas made changes -
              Assignee Donal McMullan [ donal@catalyst.net.nz ] Nobody [ nobody ]
              dougiamas Martin Dougiamas made changes -
              Fix Version/s 1.9.4 [ 10300 ]
              Fix Version/s 1.9.3 [ 10290 ]
              skodak Petr Skoda made changes -
              Fix Version/s 1.9.5 [ 10320 ]
              Fix Version/s 1.9.4 [ 10300 ]
              skodak Petr Skoda made changes -
              Fix Version/s 1.9.6 [ 10340 ]
              Fix Version/s 1.9.5 [ 10320 ]
              dougiamas Martin Dougiamas made changes -
              Fix Version/s 1.9.7 [ 10360 ]
              Fix Version/s 1.9.6 [ 10340 ]
              stronk7 Eloy Lafuente (stronk7) made changes -
              Fix Version/s 1.9.8 [ 10400 ]
              Fix Version/s 1.9.7 [ 10360 ]
              mjollnir Penny Leach made changes -
              Link This issue will help resolve MDL-21260 [ MDL-21260 ]
              dougiamas Martin Dougiamas made changes -
              Fix Version/s 1.9.9 [ 10405 ]
              Fix Version/s 1.9.8 [ 10400 ]
              dougiamas Martin Dougiamas made changes -
              Fix Version/s 1.9.10 [ 10407 ]
              Fix Version/s 1.9.9 [ 10405 ]
              dougiamas Martin Dougiamas made changes -
              Fix Version/s 1.9.11 [ 10410 ]
              Fix Version/s 1.9.10 [ 10407 ]
              dougiamas Martin Dougiamas made changes -
              Workflow jira [ 19087 ] MDL Workflow [ 41936 ]
              dougiamas Martin Dougiamas made changes -
              Fix Version/s 1.9.12 [ 10536 ]
              Fix Version/s 1.9.11 [ 10410 ]
              dougiamas Martin Dougiamas made changes -
              Workflow MDL Workflow [ 41936 ] MDL Full Workflow [ 70370 ]
              dougiamas Martin Dougiamas made changes -
              Fix Version/s STABLE backlog [ 10463 ]
              Fix Version/s 1.9.12 [ 10536 ]
              poltawski Dan Poltawski made changes -
              Affects Version/s 2.3.1 [ 12253 ]
              mudrd8mz David Mudrák made changes -
              Status Open [ 1 ] Closed [ 6 ]
              Fix Version/s STABLE backlog [ 10463 ]
              Resolution Won't Fix [ 2 ]

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  2 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: