Moodle
  1. Moodle
  2. MDL-8188

MOODLE_17_STABLE missing file moodle/pix/i/approve.gif used by database module

    Details

    • Affected Branches:
      MOODLE_17_STABLE, MOODLE_18_STABLE, MOODLE_19_STABLE
    • Fixed Branches:
      MOODLE_17_STABLE, MOODLE_18_STABLE, MOODLE_19_STABLE
    • Rank:
      29293

      Description

      MOODLE_17_STABLE missing file moodle/pix/i/approve.gif used by database module.

      This makes it impossible to approve database entries in safari, which apparently doesn't fall back to the alt text appropriately, and makes firefox display the string "approve" rather than the image approve.gif.

        Issue Links

          Activity

          Hide
          James Ballard added a comment -

          This is still missing from 1.8 and 1.9 as well.

          It needs a new icon in the right location or I guess pix/t/clear.gif may be suitable.

          In mod/data/lib.php:

          $patterns[]='##approve##';
          if (has_capability('mod/data:approve', $context) && ($data->approval) && (!$record->approved))

          { $replacement[] = '<a href="'.$CFG->wwwroot.'/mod/data/view.php?d='.$data->id.'&approve='.$record->id.'&sesskey='.sesskey().'"><img src="'.$CFG->pixpath.'/i/approve.gif" class="iconsmall" alt="'.get_string('approve').'" /></a>'; }

          else

          { $replacement[] = ''; }

          Could be:

          $patterns[]='##approve##';
          if (has_capability('mod/data:approve', $context) && ($data->approval) && (!$record->approved)){ $replacement[] = '<a href="'.$CFG->wwwroot.'/mod/data/view.php?d='.$data->id.'&approve='.$record->id.'&sesskey='.sesskey().'"><img src="'.$CFG->pixpath.'/t/clear.gif" class="iconsmall" alt="'.get_string('approve').'" /></a>'; } else { $replacement[] = ''; }

          I added a green tick, approve.gif to the folder instead.

          Yours
          James

          Show
          James Ballard added a comment - This is still missing from 1.8 and 1.9 as well. It needs a new icon in the right location or I guess pix/t/clear.gif may be suitable. In mod/data/lib.php: $patterns[]='##approve##'; if (has_capability('mod/data:approve', $context) && ($data->approval) && (!$record->approved)) { $replacement[] = '<a href="'.$CFG->wwwroot.'/mod/data/view.php?d='.$data->id.'&approve='.$record->id.'&sesskey='.sesskey().'"><img src="'.$CFG->pixpath.'/i/approve.gif" class="iconsmall" alt="'.get_string('approve').'" /></a>'; } else { $replacement[] = ''; } Could be: $patterns[]='##approve##'; if (has_capability('mod/data:approve', $context) && ($data->approval) && (!$record->approved)){ $replacement[] = '<a href="'.$CFG->wwwroot.'/mod/data/view.php?d='.$data->id.'&approve='.$record->id.'&sesskey='.sesskey().'"><img src="'.$CFG->pixpath.'/t/clear.gif" class="iconsmall" alt="'.get_string('approve').'" /></a>'; } else { $replacement[] = ''; } I added a green tick, approve.gif to the folder instead. Yours James
          Hide
          James Ballard added a comment -

          A file for those who want it.

          Show
          James Ballard added a comment - A file for those who want it.
          Hide
          Stephen Bourget added a comment -

          This seems to also affect both Moodle 1.8 and Moodle 1.9

          Show
          Stephen Bourget added a comment - This seems to also affect both Moodle 1.8 and Moodle 1.9
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Confirmed... assigning to DC:

          1) There is one "check.gif" icon in the glossary module.
          2) There is another alternative here, courtesy of James Ballard. B-)
          3) Please confirm with MD what one to use.

          In any case I would propose to (confirm with MD too).

          1) Move the decided icon to pix/i/approve.gif (17_STABLE to HEAD)
          2) Move glossary usages of mod/glossary/check.gif to pix/i/approve.gif (19_STABLE and HEAD)
          3) Test both modules icon appearance.

          Ciao

          Show
          Eloy Lafuente (stronk7) added a comment - Confirmed... assigning to DC: 1) There is one "check.gif" icon in the glossary module. 2) There is another alternative here, courtesy of James Ballard. B-) 3) Please confirm with MD what one to use. In any case I would propose to (confirm with MD too). 1) Move the decided icon to pix/i/approve.gif (17_STABLE to HEAD) 2) Move glossary usages of mod/glossary/check.gif to pix/i/approve.gif (19_STABLE and HEAD) 3) Test both modules icon appearance. Ciao
          Hide
          Dongsheng Cai added a comment -

          For Branch 1.7 and 1.8
          a new approve.gif was added
          For Branch 1.9 and HEAD
          check.gif in mod/glossary was moved to pix/i/approve.gif, the usages of check.gif was changed to pix/i/approve.gif

          Show
          Dongsheng Cai added a comment - For Branch 1.7 and 1.8 a new approve.gif was added For Branch 1.9 and HEAD check.gif in mod/glossary was moved to pix/i/approve.gif, the usages of check.gif was changed to pix/i/approve.gif
          Hide
          Stephen Bourget added a comment -

          The fix seems to be incomplete as it is still broken in the chameleon theme under Moodle 1.9.
          (The chameleon theme has it's own set of icons see http://cvs.moodle.org/moodle/theme/chameleon/pix/i/)

          Show
          Stephen Bourget added a comment - The fix seems to be incomplete as it is still broken in the chameleon theme under Moodle 1.9. (The chameleon theme has it's own set of icons see http://cvs.moodle.org/moodle/theme/chameleon/pix/i/ )
          Hide
          Dongsheng Cai added a comment -

          Add approve.gif file to chameleon them, I dug a little deeper, find this:
          $CFG->pixpath = $CFG->themewww .'/'. $theme .'/pix';
          $CFG->modpixpath = $CFG->themewww .'/'. $theme .'/pix/mod';
          $CFG->pixpath may be different when we use different them.

          Show
          Dongsheng Cai added a comment - Add approve.gif file to chameleon them, I dug a little deeper, find this: $CFG->pixpath = $CFG->themewww .'/'. $theme .'/pix'; $CFG->modpixpath = $CFG->themewww .'/'. $theme .'/pix/mod'; $CFG->pixpath may be different when we use different them.
          Hide
          Mathieu Petit-Clair added a comment -

          QA-Tuesday: made sure no other core theme needed it... Closed.

          Show
          Mathieu Petit-Clair added a comment - QA-Tuesday: made sure no other core theme needed it... Closed.

            People

            • Votes:
              1 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: