-
Improvement
-
Resolution: Unresolved
-
Minor
-
None
-
4.5
-
MOODLE_405_STABLE
Noted by davidcarrillo in discussion of MDL-81434 - however that's a bug fix, so proposing the following as a separate improvement (main-only)
- Column field alias ("c");
- Column param names ("p");
- Condition param names ("c");
- Filter param names ("f")
The purpose of each of these is to ensure uniqueness within a report, for parameter names when used in conjunction with the following helpers:
- generate_alias[es](...)
- generate_param_name[s](...)
Uniqueness still being the primary purpose of all these methods/values, it's also useful when using the report SQL debug tool to have helpfully named values too - which we can evaluate here (David has some suggestions) and improve
My suggestion:
Params: p => col; c => con; f => fil
|
Columns: c => col
|
Alias: rbalias => rba
|
Param: rbparam => rbp
|
- Discovered while testing
-
MDL-81434 Applying the same condition/filter to custom report can throw DML exceptions
- Closed