Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-81909

test_attempt_reopen_method_untilpass marks the first submission twice

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • 4.3.8, 4.4.4
    • 4.3.1, 4.4.1
    • Assignment

      There's a logical error in the test_attempt_reopen_method_untilpass() function.

      Instead of marking the second submission as passing, it reverts to marking the first submission again.

      The test appeared to pass because the second submission by the student wasn't graded at all. Consequently, the student didn't see the button to submit a new attempt. However, our intention was to verify that once a student receives a passing grade, they shouldn't be able to submit additional attempts. Although the test passed, it did so erroneously because it failed to properly assess the expected behavior. It succeeded simply because it didn't evaluate the second submission of the student.

            rezaie9 Shamim Rezaie
            rezaie9 Shamim Rezaie
            Paul Holden Paul Holden
            Mihail Geshoski Mihail Geshoski
            CiBoT CiBoT
            Votes:
            1 Vote for this issue
            Watchers:
            7 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 hour, 51 minutes
                1h 51m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.