Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-81929

Bulk actions selector should go back to "Choose..." when used

XMLWordPrintable

    • MOODLE_404_STABLE
    • MOODLE_404_STABLE
    • MDL-81929-404
    • Hide
      1. Install demo plugin, e.g.

        $ git clone https://github.com/paulholden/moodle-tool_bulkactiondemo.git admin/tool/bulkactiondemo
        

      2. Log in as admin
      3. Create some users (use Make test course generator to quickly populate them)
      4. Navigate to Users > Accounts > Browse list of users in site administration
      5. Select two of the users
      6. Choose Suspend users from the With selected users... menu
      7. Press Yes in the subsequent dialogue
      8. Confirm the With selected users... menu shows Choose... again
      9. Select two more users
      10. Choose Suspend users from the With selected users... menu
      11. Confirm you can reuse the same bulk action again
      Show
      Install demo plugin, e.g. $ git clone https://github.com/paulholden/moodle-tool_bulkactiondemo.git admin/tool/bulkactiondemo Log in as admin Create some users (use Make test course generator to quickly populate them) Navigate to Users > Accounts > Browse list of users in site administration Select two of the users Choose Suspend users from the With selected users... menu Press Yes in the subsequent dialogue Confirm the With selected users... menu shows Choose... again Select two more users Choose Suspend users from the With selected users... menu Confirm you can reuse the same bulk action again

      We have implemented some functionality on top of the "Browse list of users" report in Workplace where our actions use modals instead of changing pages. By default when a bulk action is used the dropdown selector remains with the same option set. This should be fixed and be reset to the "Choose" option instead.

      Example

      There are two avenues we can take in approaches to fix this:

      1. Have every bulk user action implemented as JS reset the selected value themselves (easy to forget, and not really the responsibility of these modules); or
      2. Fix it in the same core JS module that is also responsible for enabling/disabling the bulk user selector element (at the point the element is disabled)

      https://github.com/paulholden/moodle-tool_bulkactiondemo can be used to test this (there aren't currently any JS bulk actions implemented in Moodle itself, but we have lots in Workplace - e.g. the above screencast)

        1. MDL-81929.gif
          MDL-81929.gif
          297 kB
        2. MDL-81929.png
          MDL-81929.png
          617 kB

            pholden Paul Holden
            davidcarrillo David Carrillo
            Carlos Castillo Carlos Castillo
            Huong Nguyen Huong Nguyen
            Ron Carl Alfon Yu Ron Carl Alfon Yu
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 2 hours, 24 minutes
                2h 24m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.