Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-81932

Communication provider change not limiting room name update to newly set provider

XMLWordPrintable

    • MOODLE_403_STABLE, MOODLE_404_STABLE
    • MOODLE_403_STABLE, MOODLE_404_STABLE
    • MDL-81932-403
    • MDL-81932-404
    • MDL-81932-main
    • Hide

      (Tests are also covered by behat)

      Setup

       # Clone the helper repository:

      git clone https://github.com/andrewnicols/moodle-synapse
      		 
      cd moodle-synapse
      		 
      chmod 777 *_data

       # Run the docker-compose up command:

      docker compose up -d

       # Wait for about 10 seconds for the first run to complete
       # Run the setup script:

      ./setup.sh

       # Copy the command it outputs
       # Change into your Moodle directory
       # Paste in the command, for EXAMPLE:

      cd path/to/moodle
      		 
      sed -i '/^require_once.*lib.*setup.php.*$/i require_once("/Users/nicols/git/moodlehq/synapse/moodle-config.php");' config.php
      		 
      cd -

       # If you have not done so already, edit your /etc/hosts file to add:

      127.0.0.1 element.container.docker.internal element
      		 
      127.0.0.1 synapse.container.docker.internal synapse
      		 
      127.0.0.1 keycloak.container.docker.internal keycloak

       # Follow the instructions at https://github.com/andrewnicols/moodle-synapse#trusting to trust the root CA that is used for this.

       

      Test Scenario

      1. Create a new course.
      2. Go to More > Communication.
      3. Set the Provider to 'Matrix'.
      4. Set Room name to 'Matrix room'.
      5. Set the Room topic to 'Matrix topic'.
      6. Save changes.
      7. Go to More > Communication.
      8. Set the Provider to 'Custom link'.
      9. Set Room name to 'Custom link room'.
      10. Set the Custom link URL to "https://moodle.org".
      11. Save changes.
      12. Go to More > Communication.
      13. Set the Provider to 'Matrix'.
      14. Confirm that the Room name is "Matrix room".
      15. Confirm that the Room topic is "Matrix topic".
      16. Set the Provider to 'Custom link'.
      17. Confirm that the Room name is "Custom link room".
      18. Confirm that the Custom link URL is "https://moodle.org".

       

      Show
      (Tests are also covered by behat) Setup  # Clone the helper repository: git clone https://github.com/andrewnicols/moodle-synapse cd moodle-synapse chmod 777 *_data  # Run the docker-compose up command: docker compose up -d  # Wait for about 10 seconds for the first run to complete  # Run the setup script: ./setup.sh  # Copy the command it outputs  # Change into your Moodle directory  # Paste in the command, for EXAMPLE : cd path/to/moodle sed -i '/^require_once.*lib.*setup.php.*$/i require_once("/Users/nicols/git/moodlehq/synapse/moodle-config.php");' config.php cd -  # If you have not done so already, edit your /etc/hosts file to add: 127.0.0.1 element.container.docker.internal element 127.0.0.1 synapse.container.docker.internal synapse 127.0.0.1 keycloak.container.docker.internal keycloak  # Follow the instructions at https://github.com/andrewnicols/moodle-synapse#trusting to trust the root CA that is used for this.   Test Scenario Create a new course. Go to More > Communication. Set the Provider to 'Matrix'. Set Room name to 'Matrix room'. Set the Room topic to 'Matrix topic'. Save changes. Go to More > Communication. Set the Provider to 'Custom link'. Set Room name to 'Custom link room'. Set the Custom link URL to "https://moodle.org". Save changes. Go to More > Communication. Set the Provider to 'Matrix'. Confirm that the Room name is "Matrix room". Confirm that the Room topic is "Matrix topic". Set the Provider to 'Custom link'. Confirm that the Room name is "Custom link room". Confirm that the Custom link URL is "https://moodle.org".  
    • 6
    • Team Hedgehog 2024 Sprint 2.1, Team Hedgehog 2024 Sprint 2.2, Team Hedgehog 2024 Sprint 2.3, Team Hedgehog 2024 Review 2

      When you switch communication providers, the room name set on the "new" provider should only be saved for that provider, currently it is also overwriting the room name for the previous provider. For example:

      1. In a new course, navigate to More > Communication and enable the custom link provider: Set the room name to "Custom link name" and the URL to moodle.org, then save.
      2. Return to the communication provider settings, switch the provider to Matrix, set the room name to "Matrix name" and save.
      3. Again return to the communication provider settings, switch back to the custom link provider.
      4. Expected: room name is now "Custom link name". Actual: Room name is now "Matrix name".

      This should also be verifiable by checking the room name stored in the database at each stage.

        1. MDL-81932.png
          MDL-81932.png
          230 kB
        2. mform_issue.webm
          5.48 MB

            safat.shahin@moodle.com Safat Shahin
            michaelh Michael Hawkins
            Raquel Ortega Raquel Ortega
            Andrew Lyons Andrew Lyons
            Ron Carl Alfon Yu Ron Carl Alfon Yu
            Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 3 days, 4 hours, 46 minutes
                3d 4h 46m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.