Loading...

XML

Word

Printable

Type: Bug
Resolution: Fixed
Priority: Minor
Fix Version/s: 4.4.6, 4.5.2
Affects Version/s: 4.5
Component/s: Questions
Labels:
- ci
- release_notes
- triaged

Affected Branches:
MOODLE_405_STABLE
Fixed Branches:
MOODLE_404_STABLE, MOODLE_405_STABLE
Epic Link:
Quiz and Question bank in Moodle 5.0
Pull from Repository:
https://github.com/srobotta/moodle.git
Pull 4.4 Branch:
~~MDL-81952~~-404
Pull 4.4 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_404_STABLE...srobotta:moodle:MDL-81952-404
Pull 4.5 Branch:
~~MDL-81952~~-405
Pull 4.5 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_405_STABLE...srobotta:moodle:MDL-81952-405
Pull Main Branch:
~~MDL-81952~~-main
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/main...srobotta:moodle:MDL-81952-main
Testing Instructions:
Hide

Covered by behat tests.

----------------------------------------

For manual tests:

Prerequisites:

In your Moodle installation enable all PHP error levels (including warnings), the typical set on a dev system.

Test instructions:

Login as admin/teacher in Moodle.

Go to a course and in the course to the question bank.

Create a new question from type cloze.

Save the question and return to the list of questions.

In the selector nav above choose "Export"

Select "Moodle XML", choose the correct category where you have put your question and hit the "Export question to file" button.

Before the patch of this MDL is applied:

The new page loads but soon after a splash screen with the error message from the description is shown. No file is downloaded.

After the patch of this MDL is applied:

The new page loads and shortly after you see the XML file being downloaded.

Proposal for a cloze question text, see comment below.
Show
Covered by behat tests. ---------------------------------------- For manual tests: Prerequisites: In your Moodle installation enable all PHP error levels (including warnings), the typical set on a dev system. Test instructions: Login as admin/teacher in Moodle. Go to a course and in the course to the question bank. Create a new question from type cloze. Save the question and return to the list of questions. In the selector nav above choose "Export" Select "Moodle XML", choose the correct category where you have put your question and hit the "Export question to file" button. Before the patch of this MDL is applied: The new page loads but soon after a splash screen with the error message from the description is shown. No file is downloaded. After the patch of this MDL is applied: The new page loads and shortly after you see the XML file being downloaded. Proposal for a cloze question text, see comment below.
Pre-check results:
Hide

Code verified against automated checks.

Checked ~~MDL-81952~~ using repository: https://github.com/srobotta/moodle.git

MOODLE_404_STABLE (0 errors / 0 warnings) [branch: MDL-81952-404 | CI Job]

MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-81952-405 | CI Job]

main (0 errors / 0 warnings) [branch: MDL-81952-main | CI Job]

_{More information about this report}

Built on: Sat Dec 14 12:48:11 PM UTC 2024
Show
Code verified against automated checks. Checked MDL-81952 using repository: https://github.com/srobotta/moodle.git MOODLE_404_STABLE (0 errors / 0 warnings) [branch: MDL-81952-404 | CI Job ] MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-81952-405 | CI Job ] main (0 errors / 0 warnings) [branch: MDL-81952-main | CI Job ] More information about this report Built on: Sat Dec 14 12:48:11 PM UTC 2024
Automated test results:
Hide

Launching automatic jobs for branch ~~MDL-81952~~-404

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17722/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60352/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60353/ Behat (Firefox - boost)

Launching automatic jobs for branch ~~MDL-81952~~-405

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17723/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60354/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60355/ Behat (Firefox - boost)

Launching automatic jobs for branch ~~MDL-81952~~-main

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17724/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60356/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60357/ Behat (Firefox - boost)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60358/ Behat (Firefox - classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60359/ App tests (stable app version)

Built on: Sat Dec 14 12:25:26 PM UTC 2024
Show
Launching automatic jobs for branch MDL-81952 -404 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17722/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60352/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60353/ Behat (Firefox - boost) Launching automatic jobs for branch MDL-81952 -405 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17723/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60354/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60355/ Behat (Firefox - boost) Launching automatic jobs for branch MDL-81952 -main https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17724/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60356/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60357/ Behat (Firefox - boost) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60358/ Behat (Firefox - classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60359/ App tests (stable app version) Built on: Sat Dec 14 12:25:26 PM UTC 2024

When exporting a cloze question inside a category from the question bank a warning is issued (using PHP 8.2):

Undefined property: stdClass::$categoryobjectStack frames (7)
6 Whoops\Exception\ErrorException
…/question/type/multianswer/questiontype.php:149

5 default_error_handler
…/question/type/multianswer/questiontype.php:149

4 qtype_multianswer get_question_options
…/question/editlib.php:109

3 get_questions_category
…/question/format.php:937

2 qformat_default exportprocess
…/lib/questionlib.php:1815

1 question_pluginfile
…/lib/filelib.php:5140

0 file_pluginfile…/pluginfile.php:44

This is probably because subquestion parts have a parent id and therefore do not exist independent from the parent. Only the parent needs the category.

duplicates

MDL-75015 Warning when exporting for multi-answer questions as GIFT

Closed

Assignee:: Stephan Robotta

Reporter:: Stephan Robotta

Peer reviewer:: Luca Bösch

Integrator:: Sara Arjona (@sarjona)

Tester:: CiBoT

Participants:: CiBoT, Glyn (Mathew) May, Joseph Rézeau, Luca Bösch, Sara Arjona (@sarjona), Stephan Robotta, Tim Hunt

Votes:: 2 Vote for this issue

Watchers:: 9 Start watching this issue

Created:: 17/May/24 3:50 PM

Updated:: 04/Feb/25 1:54 PM

Resolved:: 19/Dec/24 8:28 PM

Estimated:

Remaining:

Logged:

6h 5m

Details

Description

Attachments

Issue Links

Activity

People

Dates

Time Tracking

Clockify