Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-81992

Question bank: 'Create a new question ...' button can be slow to initialise, and clicking too soon gives an error

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • 4.3.5, 4.4.1
    • 4.3.4, 4.4
    • Questions
    • MOODLE_403_STABLE, MOODLE_404_STABLE
    • MOODLE_403_STABLE, MOODLE_404_STABLE
    • MDL-81992_403
    • MDL-81992_404
    • Hide
      1. Create a course or use an existing one.
      2. Open the browser developer tool and switch to the Network tab.
      3. Set the Throttling to Fast 3G or Slow 3G.
      4. Go to the question bank page of the course, and watch the 'Create a new question ...' button closely.
      5. Verify that when the page first loads, the button is disabled, but then becomes enabled.
      6. Verify that when the page finishes loading, the button is enabled
      7. Verify that clicking the button works (chooser dialogue opens, you can select a question type and start creating it.)
      Show
      Create a course or use an existing one. Open the browser developer tool and switch to the Network tab. Set the Throttling to Fast 3G or Slow 3G . Go to the question bank page of the course, and watch the 'Create a new question ...' button closely. Verify that when the page first loads, the button is disabled, but then becomes enabled. Verify that when the page finishes loading, the button is enabled Verify that clicking the button works (chooser dialogue opens, you can select a question type and start creating it.)

      Steps to repoduce:

      1. In a place with a lot of questions, go to the question bank.
      2. As soon as the page has finished loading, click the 'Create a new question ...' button.

      Expected result: a dialogue opens to let you chose the question type to create.

      Actual result, you end up on the script question/addquestion.php with the error You must select a question type.

      Even though this is most easy to reproduce with a large question bank, where the delay can be 10+ seconds I can reproduce it at https://qa.moodledemo.net/question/edit.php?courseid=2 if I click fast enough.

      This change is a quick fix, to make the button disabled until it is ready to be clicked, which is quite a big usability win. I have created MDL-81994 to do a bigger investigation about why it is slow, but that will take longer.

        1. (1) 5 Passed -- (Main)MDL-81992.png
          (1) 5 Passed -- (Main)MDL-81992.png
          186 kB
        2. (1) 6 Passed -- (Main)MDL-81992.png
          (1) 6 Passed -- (Main)MDL-81992.png
          254 kB
        3. (1) 7 Passed -- (Main)MDL-81992.png
          (1) 7 Passed -- (Main)MDL-81992.png
          346 kB

            timhunt Tim Hunt
            timhunt Tim Hunt
            Anupama Sarjoshi Anupama Sarjoshi
            Huong Nguyen Huong Nguyen
            Kim Jared Lucas Kim Jared Lucas
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 hour, 11 minutes
                1h 11m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.