Loading...

XML

Word

Printable

Type: Bug
Resolution: Fixed
Priority: Minor
Fix Version/s: 4.3.5, 4.4.1
Affects Version/s: 4.3.1, 4.4
Component/s: Assignment
Labels:
- ci
- triaged

Affected Branches:
MOODLE_403_STABLE, MOODLE_404_STABLE
Fixed Branches:
MOODLE_403_STABLE, MOODLE_404_STABLE
Pull from Repository:
https://github.com/paulholden/moodle
Pull 4.3 Branch:
~~MDL-82004~~-403
Pull 4.3 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_403_STABLE...paulholden:MDL-82004-403
Pull 4.4 Branch:
~~MDL-82004~~-404
Pull 4.4 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_404_STABLE...paulholden:MDL-82004-404
Pull Main Branch:
~~MDL-82004~~
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/main...paulholden:MDL-82004
Testing Instructions:
Hide

Confirm language strings in changed file contain no string concatenation, e.g.

$string['x'] = 'foo ' . 'bar';
Show
Confirm language strings in changed file contain no string concatenation, e.g. $string['x'] = 'foo ' . 'bar';

Something mentioned by timhunt here referring to ~~MDLSITE-2719~~ & https://github.com/moodlehq/moodle-cs/issues/164

Given we have policy to disallow this, we should remove these two occurrences

Assignee:: Paul Holden

Reporter:: Paul Holden

Peer reviewer:: Tim Hunt

Integrator:: Mathew May

Tester:: Andrew Lyons

Participants:: Andrew Lyons, CiBoT, Mathew May, Paul Holden, Tim Hunt

Votes:: 0 Vote for this issue

Watchers:: 5 Start watching this issue

Created:: 23/May/24 8:03 PM

Updated:: 30/May/24 11:58 PM

Resolved:: 30/May/24 11:58 PM

Estimated:

Not Specified

Remaining:

0m

Logged:

35m