Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-82047

Remove broken 32-bit checks of Analytics max time constant

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • 4.3.5, 4.4.1
    • 4.2.7, 4.3.4, 4.4.1
    • Analytics

      Per dobedobedoh's review of MDL-81282, commented here:

      Now that we require 64-bit php we don't need to do this.

      We've required 64-bit PHP since MDL-74905 and documented in 4.2 release notes

      In fact looking at that line from MDL-72359 it seems it can't ever work on 32-bit systems as is anyway, because it compares PHP_INT_MAX and then tries to use PHP_MAX_INT

            pholden Paul Holden
            pholden Paul Holden
            Huong Nguyen Huong Nguyen
            Andrew Lyons Andrew Lyons
            CiBoT CiBoT
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 3 hours, 24 minutes
                3h 24m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.