Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-82160

Breaking theme API change causes exceptions in third-party themes

XMLWordPrintable

    • 1
    • HQ 2024 Sprint I2.2 Moppies

      This is a regression due to breaking API changes that landed in the 4.4.1 release (yesterday) as part of MDL-81597. There's a comment from that issue alluding to this possibility

      The problematic change is this removal (I haven't looked at other potential breakages, nor have I checked how prevalent this problem may be elsewhere)

      In Workplace specifically, we encountered the following with our theme, on all pages (see WP-4895):

      Error
       
      Exception - Call to undefined method theme_workplace\output\core_renderer::render_context_header()
       
      Debug info:
       
      Error code: generalexceptionmessage
       
      Stack trace:
       
         line 287 of /theme/workplace/classes/output/core_renderer.php: Error thrown
         line 4659 of /lib/outputrenderers.php: call to theme_workplace\output\core_renderer->context_header()
         line 219 of /lib/mustache/src/Mustache/Context.php: call to core_renderer->full_header()
         line 138 of /lib/mustache/src/Mustache/Context.php: call to Mustache_Context->findVariableInStack()
         line 62 of /var/www/behatdata/run/behatrun3/localcache/mustache/1718048990/workplace/__Mustache_4aa1b29b14b62e9eb02cc88038b79589.php: call to Mustache_Context->findDot()
         line 66 of /lib/mustache/src/Mustache/Template.php: call to __Mustache_4aa1b29b14b62e9eb02cc88038b79589->renderInternal()
         line 216 of /lib/outputrenderers.php: call to Mustache_Template->render()
         line 127 of /theme/workplace/layout/drawers.php: call to renderer_base->render_from_template()
         line 1483 of /lib/outputrenderers.php: call to include()
         line 1408 of /lib/outputrenderers.php: call to core_renderer->render_page_layout()
         line 182 of /my/index.php: call to core_renderer->header()
      

      The same problem is also affecting our demo sites which receive early builds

        1. MDL-82160.png
          MDL-82160.png
          557 kB
        2. MDL-82160-test.patch
          0.7 kB
        3. screenshot-1.png
          screenshot-1.png
          38 kB
        4. screenshot-2.png
          screenshot-2.png
          35 kB

            mikelmartíncorrales Mikel Martín Corrales
            pholden Paul Holden
            Paul Holden Paul Holden
            Sara Arjona (@sarjona) Sara Arjona (@sarjona)
            Ron Carl Alfon Yu Ron Carl Alfon Yu
            Votes:
            0 Vote for this issue
            Watchers:
            10 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 2 hours, 41 minutes
                2h 41m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.