Loading...

XML

Word

Printable

Type: Bug
Resolution: Fixed
Priority: Minor
Fix Version/s: 4.4.7, 4.5.3
Affects Version/s: 4.3.5, 4.4.1, 4.4.7, 4.5.3
Component/s: User management
Labels:
- ci
- triaged

Affected Branches:
MOODLE_403_STABLE, MOODLE_404_STABLE, MOODLE_405_STABLE
Fixed Branches:
MOODLE_404_STABLE, MOODLE_405_STABLE
Pull from Repository:
https://github.com/paulholden/moodle.git
Pull 4.4 Branch:
~~MDL-82170~~-404
Pull 4.4 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_404_STABLE...paulholden:MDL-82170-404
Pull 4.5 Branch:
~~MDL-82170~~-405
Pull 4.5 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_405_STABLE...paulholden:MDL-82170-405
Pull Main Branch:
~~MDL-82170~~
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/main...paulholden:MDL-82170
Testing Instructions:
1. Covered by automated tests
Pre-check results:
Hide

Code verified against automated checks with warnings.

Checked ~~MDL-82170~~ using repository: https://github.com/paulholden/moodle.git

MOODLE_404_STABLE (0 errors / 1 warnings) [branch: MDL-82170-404 | CI Job]

overview (0/1), phplint (0/0), phpcs (0/0), js (0/0), css (0/0), phpdoc (0/0), commit (0/0), savepoint (0/0), thirdparty (0/0), externalbackup (0/0), grunt (0/0), shifter (0/0), mustache (0/0), gherkin (0/0),

Warn: The ~~MDL-82170~~-404 branch at https://github.com/paulholden/moodle.git has not been rebased recently (>20 days ago).

MOODLE_405_STABLE (0 errors / 1 warnings) [branch: MDL-82170-405 | CI Job]

overview (0/1), phplint (0/0), phpcs (0/0), js (0/0), css (0/0), phpdoc (0/0), commit (0/0), savepoint (0/0), thirdparty (0/0), externalbackup (0/0), grunt (0/0), shifter (0/0), mustache (0/0), gherkin (0/0),

Warn: The ~~MDL-82170~~-405 branch at https://github.com/paulholden/moodle.git has not been rebased recently (>20 days ago).

main (0 errors / 1 warnings) [branch: MDL-82170 | CI Job]

overview (0/1), phplint (0/0), phpcs (0/0), js (0/0), css (0/0), phpdoc (0/0), commit (0/0), savepoint (0/0), thirdparty (0/0), externalbackup (0/0), grunt (0/0), shifter (0/0), mustache (0/0), gherkin (0/0),

Warn: The ~~MDL-82170~~ branch at https://github.com/paulholden/moodle.git has not been rebased recently (>20 days ago).

Should these errors be fixed?

Built on: Tue Mar 4 05:46:12 UTC 2025
Show
Code verified against automated checks with warnings. Checked MDL-82170 using repository: https://github.com/paulholden/moodle.git MOODLE_404_STABLE (0 errors / 1 warnings) [branch: MDL-82170-404 | CI Job ] overview (0/1) , phplint (0/0) , phpcs (0/0) , js (0/0) , css (0/0) , phpdoc (0/0) , commit (0/0) , savepoint (0/0) , thirdparty (0/0) , externalbackup (0/0) , grunt (0/0) , shifter (0/0) , mustache (0/0) , gherkin (0/0) , Warn: The MDL-82170 -404 branch at https://github.com/paulholden/moodle.git has not been rebased recently (>20 days ago). MOODLE_405_STABLE (0 errors / 1 warnings) [branch: MDL-82170-405 | CI Job ] overview (0/1) , phplint (0/0) , phpcs (0/0) , js (0/0) , css (0/0) , phpdoc (0/0) , commit (0/0) , savepoint (0/0) , thirdparty (0/0) , externalbackup (0/0) , grunt (0/0) , shifter (0/0) , mustache (0/0) , gherkin (0/0) , Warn: The MDL-82170 -405 branch at https://github.com/paulholden/moodle.git has not been rebased recently (>20 days ago). main (0 errors / 1 warnings) [branch: MDL-82170 | CI Job ] overview (0/1) , phplint (0/0) , phpcs (0/0) , js (0/0) , css (0/0) , phpdoc (0/0) , commit (0/0) , savepoint (0/0) , thirdparty (0/0) , externalbackup (0/0) , grunt (0/0) , shifter (0/0) , mustache (0/0) , gherkin (0/0) , Warn: The MDL-82170 branch at https://github.com/paulholden/moodle.git has not been rebased recently (>20 days ago). Should these errors be fixed? Built on: Tue Mar 4 05:46:12 UTC 2025
Automated test results:
Hide

Launching automatic jobs for branch ~~MDL-82170~~-404

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18335/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62725/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62726/ Behat (Firefox - boost)

Launching automatic jobs for branch ~~MDL-82170~~-405

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18336/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62727/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62728/ Behat (Firefox - boost)

Launching automatic jobs for branch ~~MDL-82170~~

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18337/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62729/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62730/ Behat (Firefox - boost)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62731/ Behat (Firefox - classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62732/ App tests (stable app version) --> unrelated failures, please ignore.

Built on: Mon Feb 24 10:25:20 AM UTC 2025
Show
Launching automatic jobs for branch MDL-82170 -404 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18335/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62725/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62726/ Behat (Firefox - boost) Launching automatic jobs for branch MDL-82170 -405 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18336/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62727/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62728/ Behat (Firefox - boost) Launching automatic jobs for branch MDL-82170 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18337/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62729/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62730/ Behat (Firefox - boost) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62731/ Behat (Firefox - classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/62732/ App tests (stable app version) --> unrelated failures, please ignore. Built on: Mon Feb 24 10:25:20 AM UTC 2025

See explanation from original issue: ~~MDL-80119~~ (I classed this one as a bug too)

We have a similar case here: https://github.com/moodle/moodle/blob/d3ae1391abea2d7730a36904cbb9256d25d89d77/lib/datalib.php#L385-L391 in users_order_by_sql(...)

We can simplify that code by removing the increment operator altogether, because we already have enough data to create unique parameter names in the subsequent loop

Discovered while testing

MDL-81996 Alphabetize the list of names appearing in a block generated by the block_mentees plugin.

Closed

will help resolve

MDL-80119 PHP 8.3: Path to saner inc/dec operators

Closed

Assignee:: Paul Holden

Reporter:: Paul Holden

Peer reviewer:: Daniel Ziegenberg

Integrator:: Andrew Lyons

Tester:: CiBoT

Participants:: Andrew Lyons, CiBoT, Daniel Ziegenberg, Jun Pataleta, Paul Holden

Votes:: 0 Vote for this issue

Watchers:: 4 Start watching this issue

Created:: 12/Jun/24 4:57 AM

Updated:: 08/Mar/25 12:17 PM

Resolved:: 08/Mar/25 12:17 PM

Details

Description

Attachments

Issue Links

Activity

People

Dates

Clockify