Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-82175

Get rid of the task log popup window and make it a normal page

XMLWordPrintable

    • MOODLE_405_STABLE
    • MDL-82175-cron-logs
    • Easy
    • Hide

      1) Install this admin tool to help with testing:

      https://github.com/catalyst/moodle-tool_testtasks

      Checkout this exact commit (later code has broken code for testing another tracker which hasn't landed yet)

      git checkout d1966cea4742741bf7304d9946736b529a8eac4c

      2) Run cron so we have some task logs

      3) Visit /admin/tasklogs.php

      4) Confirm each task name is linked

      5) For a log click on the cog, then Download, save the file and confirm the raw logs are correct

      6) Click any task and confirm you get a full normal page instead of a popup and it is styled in white on black (identical to when you run a task manually in the UI)

      7) Find the logs for \tool_testtasks\task\mtrace_task, or to make it easy run this task again:

      php admin/cli/scheduled_task.php --execute='\tool_testtasks\task\mtrace_task'

      8) Click into the logs and confirm that emails and urls in the task output are html links

      9) From the log detail page click download and confirm the raw logs are correct

      Show
      1) Install this admin tool to help with testing: https://github.com/catalyst/moodle-tool_testtasks Checkout this exact commit (later code has broken code for testing another tracker which hasn't landed yet) git checkout d1966cea4742741bf7304d9946736b529a8eac4c 2) Run cron so we have some task logs 3) Visit /admin/tasklogs.php 4) Confirm each task name is linked 5) For a log click on the cog, then Download, save the file and confirm the raw logs are correct 6) Click any task and confirm you get a full normal page instead of a popup and it is styled in white on black (identical to when you run a task manually in the UI) 7) Find the logs for \tool_testtasks\task\mtrace_task, or to make it easy run this task again: php admin/cli/scheduled_task.php --execute='\tool_testtasks\task\mtrace_task' 8) Click into the logs and confirm that emails and urls in the task output are html links 9) From the log detail page click download and confirm the raw logs are correct

      At the moment to see the logs you click the cog, then 'View' and you get a little popup page. It would be much nicer and simpler if the main row in the table was clickable and took you to a full screen normal moodle report page with the task logs, and styled consistently with how the logs look if you had run run the task manually.

            brendanheywood Brendan Heywood
            brendanheywood Brendan Heywood
            Paul Holden Paul Holden
            Huong Nguyen Huong Nguyen
            Kim Jared Lucas Kim Jared Lucas
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 3 hours, 2 minutes
                3h 2m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.