Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-8223

require_(course)_login() cleanup

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.7.1
    • Fix Version/s: 1.8
    • Component/s: General
    • Labels:
      None
    • Affected Branches:
      MOODLE_17_STABLE
    • Fixed Branches:
      MOODLE_18_STABLE

      Description

      require_login issues:

      • does not accept $course object as parameter - see require_course_obejct()
      • always uses global $course even when courseid empty
      • overrides global $course - problem it contains something else than $course object

      require_course_login issues:

      • does not accept courseid as parameter
      • does not pass $cm to require_login when forced login to site - not a major issue because there are extra visibility checks in modules - we can remove them now

        Attachments

          Activity

            People

            Assignee:
            skodak Petr Skoda
            Reporter:
            skodak Petr Skoda
            Tester:
            Nobody
            Participants:
            Component watchers:
            Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              31/Mar/07