Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-82270

Broken markup in moodle.org consent popup

XMLWordPrintable

    • MOODLE_404_STABLE
    • MOODLE_404_STABLE
    • MDL-82270-extra_backslash-404
    • MDL-82270-extra_backslash
    • Hide

      Setup

      1. Log in as admin
      2. Navigate to Users > Privacy and policies > Policy settings in site administration
      3. Change Site policy handler to Policies (tool_policy)
      4. Navigate to Users > Privacy and policies > Manage policies in site administration
      5. Create new policy
        • Name: For guests
        • User consent: Guests
        • Summary: Hello
        • Full policy: Is it me you're looking for?
      6. After saving, press Actions > Set status to "Active" in the Policies and agreements table
      7. Press Activate in the confirmation dialog
      8. Logout

      Test

      1. In the page footer, under If you condition browsing... text, right click "Guests" and open in a new browser tab/window
      2. Confirm the new tab/window correctly shows the "Guests" policy you just created
      Show
      Setup Log in as admin Navigate to Users > Privacy and policies > Policy settings in site administration Change Site policy handler to Policies (tool_policy) Navigate to Users > Privacy and policies > Manage policies in site administration Create new policy Name: For guests User consent: Guests Summary: Hello Full policy: Is it me you're looking for? After saving, press Actions > Set status to "Active" in the Policies and agreements table Press Activate in the confirmation dialog Logout Test In the page footer, under If you condition browsing... text, right click "Guests" and open in a new browser tab/window Confirm the new tab/window correctly shows the "Guests" policy you just created

      Consent popup contains invalid markup with an extra backslash:

      Line 64 of guestcontent.mustache actually contains this extra backslash : https://github.com/moodle/moodle/commit/c6d406620101463b12993c4c879b1b5c130ea43c#diff-256ca99c577d0008c4fbeb622d92d5a998f5bc030706248afa7751740ec2a7e4

        1. MDL-82270.png
          368 kB
          Ron Carl Alfon Yu

            mathieu.bruyen Mathieu Bruyen
            mathieu.bruyen Mathieu Bruyen
            Paul Holden Paul Holden
            Safat Shahin Safat Shahin
            Ron Carl Alfon Yu Ron Carl Alfon Yu
            Votes:
            0 Vote for this issue
            Watchers:
            8 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 46 minutes
                46m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.