Loading...

XML

Word

Printable

Type: Improvement
Resolution: Unresolved
Priority: Minor
Fix Version/s: None
Affects Version/s: 4.4.2, 4.5
Component/s: Database activity module
Labels:
- ci
- docs_required
- patch
- triaged

Affected Branches:
MOODLE_404_STABLE, MOODLE_405_STABLE
Pull from Repository:
https://github.com/mackensen/moodle
Pull Main Branch:
MDL-82313-main
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/main...mackensen:moodle:MDL-82313-main
Testing Instructions:
Hide

Before applying the patch, do the following:

Create a database activity and add some core fields (text, url, etc).

Navigate to the Fields list and verify that the icons display correctly.

Install the UUID field plugin (https://github.com/LafColITS/moodle-datafield_uuid).

Navigate to the Fields list and verify that there is no icon displaying for the UUID field.

Apply the patch, and then do the following:

Navigate to the Fields list for the database activity you created previously. Verify that all icons are displaying correctly, for both core and contrib datafield plugins.
Show
Before applying the patch, do the following: Create a database activity and add some core fields (text, url, etc). Navigate to the Fields list and verify that the icons display correctly. Install the UUID field plugin ( https://github.com/LafColITS/moodle-datafield_uuid ). Navigate to the Fields list and verify that there is no icon displaying for the UUID field. Apply the patch, and then do the following: Navigate to the Fields list for the database activity you created previously. Verify that all icons are displaying correctly, for both core and contrib datafield plugins.
Pre-check results:
Hide

Code verified against automated checks.

Checked MDL-82313 using repository: https://github.com/mackensen/moodle

main (0 errors / 0 warnings) [branch: MDL-82313-main | CI Job]

_{More information about this report}

Built on: Wed 13 Nov 2024 11:23:45 AM UTC
Show
Code verified against automated checks. Checked MDL-82313 using repository: https://github.com/mackensen/moodle main (0 errors / 0 warnings) [branch: MDL-82313-main | CI Job ] More information about this report Built on: Wed 13 Nov 2024 11:23:45 AM UTC
Automated test results:
Hide

Launching automatic jobs for branch MDL-82313-main

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17330/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59127/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59128/ Behat (Firefox - boost)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59129/ Behat (Firefox - classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59130/ App tests (stable app version)

Built on: Wed Nov 13 10:27:11 UTC 2024
Show
Launching automatic jobs for branch MDL-82313 -main https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17330/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59127/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59128/ Behat (Firefox - boost) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59129/ Behat (Firefox - classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59130/ App tests (stable app version) Built on: Wed Nov 13 10:27:11 UTC 2024

Reviving ~~MDL-57067~~; this is still broken in Moodle 4.4. Original report:

As per the title of this issue, the icon for a database_field is only displayed if it is in the /mod/data/pix/field folder. But since this is outside of the plugin structure, it won't be installed there with the plugin. It leaves an ugly broken image link on the page, and everyone blames the plugin dev.

I suppose I could copy the icon to the correct folder using an install.php script, but it seems kind of wrong. It would be much nicer if the custom plugin icons were detected and displayed as are other subplugins.

has to be done before

MDL-83465 Remove icons deprecated in Moodle versions <= 5.2

Open

is duplicated by

MDL-57067 non core database activity field icons not displaying in field type column

Closed

Assignee:: Charles Fulton

Reporter:: Charles Fulton

Peer reviewer:: Laurent David

Participants:: Amaia Anabitarte, Charles Fulton, CiBoT, Laurent David, Sara Arjona (@sarjona)

Votes:: 0 Vote for this issue

Watchers:: 4 Start watching this issue

Created:: 27/Jun/24 9:33 AM

Updated:: 13/Nov/24 8:30 PM

Estimated:

Remaining:

Logged:

Details

Description

Attachments

Issue Links

Activity

People

Dates

Time Tracking

Clockify