Loading...

XML

Word

Printable

Type: Bug
Resolution: Fixed
Priority: Minor
Fix Version/s: 4.4.5, 4.5.1
Affects Version/s: 4.4.1
Component/s: Quiz
Labels:
- ci

Affected Branches:
MOODLE_404_STABLE
Fixed Branches:
MOODLE_404_STABLE, MOODLE_405_STABLE
Pull from Repository:
https://github.com/AnupamaSarjoshi/moodle.git
Pull 4.4 Branch:
~~MDL-82335~~_404
Pull 4.4 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_404_STABLE...AnupamaSarjoshi:moodle:MDL-82335_404
Pull 4.5 Branch:
~~MDL-82335~~_405
Pull 4.5 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_405_STABLE...AnupamaSarjoshi:moodle:MDL-82335_405
Pull Main Branch:
~~MDL-82335~~
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/main...AnupamaSarjoshi:moodle:MDL-82335
Testing Instructions:
Hide

To test this, you need to be able to create a Moodle install from a particular version in git, and then update to other versions.

Test the code to fix up corrupt sites.

Install MOODLE_403_STABLE branch without this fix.

Go to Custom Sort Order [https://[[moodleroot]]/question/bank/columnsortorder/sortcolumns.php?section=columnsortorde].

Update Column width (pixels) for any of the columns.

Verify the config_plugins setting (qbank_columnsortorder, colsize) in the database has valid values.

Upgrade to a point on the MOODLE_404_STABLE branch before this fix has been applied.

Verify the config_plugins setting (qbank_columnsortorder, colsize) in the database. It has a corrupted value like e.g., ‘"width":"30"}~~"width":"30"},"width":"180"}~~"width":"180"}…

Also, navigating to question bank shows this error: Exception - qbank_columnsortorder\column_manager::setup_property()

Now install MOODLE_404_STABLE or later branch with this fix

Verify in the database that there is no setting for (qbank_columnsortorder, colsize) in the config_plugins table, as the corrupted data would be deleted.

Navigate to Question bank and verify that it is accessible.

Test the code for doing an upgrade now with no corruption

Install MOODLE_403_STABLE branch without this fix.

Go to Custom Sort Order [https://[[moodleroot]]/question/bank/columnsortorder/sortcolumns.php?section=columnsortorde].

Update Column width (pixels) for any of the columns.

Verify the config_plugins setting (qbank_columnsortorder, colsize) in the database has valid values.

Upgrading to MOODLE_404_STABLE branch with the fix

Verify in the database that there is a setting for (qbank_columnsortorder, colsize) in the config_plugins table.

Navigate to Question bank and verify that it is accessible.
Show
To test this, you need to be able to create a Moodle install from a particular version in git, and then update to other versions. Test the code to fix up corrupt sites. Install MOODLE_403_STABLE branch without this fix. Go to Custom Sort Order [https://[[moodleroot]]/question/bank/columnsortorder/sortcolumns.php?section=columnsortorde]. Update Column width (pixels) for any of the columns. Verify the config_plugins setting (qbank_columnsortorder, colsize) in the database has valid values. Upgrade to a point on the MOODLE_404_STABLE branch before this fix has been applied. Verify the config_plugins setting (qbank_columnsortorder, colsize) in the database. It has a corrupted value like e.g., ‘"width":"30"} "width":"30"},"width":"180"} "width":"180"}… Also, navigating to question bank shows this error: Exception - qbank_columnsortorder\column_manager::setup_property() Now install MOODLE_404_STABLE or later branch with this fix Verify in the database that there is no setting for (qbank_columnsortorder, colsize) in the config_plugins table, as the corrupted data would be deleted. Navigate to Question bank and verify that it is accessible. Test the code for doing an upgrade now with no corruption Install MOODLE_403_STABLE branch without this fix. Go to Custom Sort Order [https://[[moodleroot]]/question/bank/columnsortorder/sortcolumns.php?section=columnsortorde]. Update Column width (pixels) for any of the columns. Verify the config_plugins setting (qbank_columnsortorder, colsize) in the database has valid values. Upgrading to MOODLE_404_STABLE branch with the fix Verify in the database that there is a setting for (qbank_columnsortorder, colsize) in the config_plugins table. Navigate to Question bank and verify that it is accessible.
Pre-check results:
Hide

Fails against automated checks.

Checked ~~MDL-82335~~ using repository: https://github.com/AnupamaSarjoshi/moodle.git

MOODLE_404_STABLE (2 errors / 0 warnings) [branch: MDL-82335_404 | CI Job]

overview (0/0), phplint (0/0), phpcs (0/0), js (0/0), css (0/0), phpdoc (0/0), commit (0/0), savepoint (2/0), thirdparty (0/0), externalbackup (0/0), grunt (0/0), shifter (0/0), mustache (0/0), gherkin (0/0),

MOODLE_405_STABLE (2 errors / 0 warnings) [branch: MDL-82335_405 | CI Job]

overview (0/0), phplint (0/0), phpcs (0/0), js (0/0), css (0/0), phpdoc (0/0), commit (0/0), savepoint (2/0), thirdparty (0/0), externalbackup (0/0), grunt (0/0), shifter (0/0), mustache (0/0), gherkin (0/0),

main (2 errors / 0 warnings) [branch: MDL-82335 | CI Job]

overview (0/0), phplint (0/0), phpcs (0/0), js (0/0), css (0/0), phpdoc (0/0), commit (0/0), savepoint (2/0), thirdparty (0/0), externalbackup (0/0), grunt (0/0), shifter (0/0), mustache (0/0), gherkin (0/0),

Should these errors be fixed?

Built on: Wed 06 Nov 2024 05:58:21 PM UTC
Show
Fails against automated checks. Checked MDL-82335 using repository: https://github.com/AnupamaSarjoshi/moodle.git MOODLE_404_STABLE (2 errors / 0 warnings) [branch: MDL-82335_404 | CI Job ] overview (0/0) , phplint (0/0) , phpcs (0/0) , js (0/0) , css (0/0) , phpdoc (0/0) , commit (0/0) , savepoint (2/0) , thirdparty (0/0) , externalbackup (0/0) , grunt (0/0) , shifter (0/0) , mustache (0/0) , gherkin (0/0) , MOODLE_405_STABLE (2 errors / 0 warnings) [branch: MDL-82335_405 | CI Job ] overview (0/0) , phplint (0/0) , phpcs (0/0) , js (0/0) , css (0/0) , phpdoc (0/0) , commit (0/0) , savepoint (2/0) , thirdparty (0/0) , externalbackup (0/0) , grunt (0/0) , shifter (0/0) , mustache (0/0) , gherkin (0/0) , main (2 errors / 0 warnings) [branch: MDL-82335 | CI Job ] overview (0/0) , phplint (0/0) , phpcs (0/0) , js (0/0) , css (0/0) , phpdoc (0/0) , commit (0/0) , savepoint (2/0) , thirdparty (0/0) , externalbackup (0/0) , grunt (0/0) , shifter (0/0) , mustache (0/0) , gherkin (0/0) , Should these errors be fixed? Built on: Wed 06 Nov 2024 05:58:21 PM UTC
Automated test results:
Hide

Launching automatic jobs for branch ~~MDL-82335~~_404

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17270/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/58845/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/58846/ Behat (Firefox - boost)

Launching automatic jobs for branch ~~MDL-82335~~_405

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17271/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/58847/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/58848/ Behat (Firefox - boost)

Launching automatic jobs for branch ~~MDL-82335~~

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17272/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/58849/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/58850/ Behat (Firefox - boost)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/58851/ Behat (Firefox - classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/58852/ App tests (stable app version)

Built on: Wed Nov 6 08:30:23 PM UTC 2024
Show
Launching automatic jobs for branch MDL-82335 _404 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17270/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/58845/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/58846/ Behat (Firefox - boost) Launching automatic jobs for branch MDL-82335 _405 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17271/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/58847/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/58848/ Behat (Firefox - boost) Launching automatic jobs for branch MDL-82335 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17272/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/58849/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/58850/ Behat (Firefox - boost) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/58851/ Behat (Firefox - classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/58852/ App tests (stable app version) Built on: Wed Nov 6 08:30:23 PM UTC 2024

Hi,

I am using Moodle 4.4.1+ (Build: 20240627)

After upgrading from 4.4 I am not able to access my question banks of any quiz.

It says:

Exception - qbank_columnsortorder\column_manager::setup_property(): Return value must be of type array, null returned

Debug info:
Error code: generalexceptionmessage

Stack trace:

line 113 of /question/bank/columnsortorder/classes/column_manager.php: TypeError thrown
line 84 of /question/bank/columnsortorder/classes/column_manager.php: call to qbank_columnsortorder\column_manager->setup_property()
line 44 of /question/bank/columnsortorder/classes/plugin_feature.php: call to qbank_columnsortorder\column_manager->__construct()
line 312 of /question/classes/local/bank/view.php: call to qbank_columnsortorder\plugin_feature->get_column_manager()
line 276 of /question/classes/local/bank/view.php: call to core_question\local\bank\view->init_column_manager()
line 47 of /question/edit.php: call to core_question\local\bank\view->__construct()

Please help me to get rid of this asap.

Thousands of users are affected because of this.

- - Sort By Name
  - Sort By Date
  - Ascending
  - Descending
  - Thumbnails
  - List
  - Download All

Colsize.png
66 kB
29/Jun/24 5:46 PM
image-2024-07-02-00-07-42-846.png
381 kB
02/Jul/24 2:37 AM
MDL-82335.png
669 kB
07/Nov/24 4:29 PM
Question Bank Error.png
72 kB
29/Jun/24 1:45 PM
Test the code for doing an upgrade now with no corruption.png
573 kB
07/Nov/24 1:19 PM
Test the code to fix up corrupt sites.png
703 kB
07/Nov/24 1:19 PM

is a regression caused by

MDL-74054 Give teachers more flexibility to customise their own view of the question bank

Closed

Assignee:: Anupama Sarjoshi

Reporter:: Aditya Dubay

Peer reviewer:: Mahmoud Kassaei

Integrator:: Tim Hunt

Tester:: Ron Carl Alfon Yu

Participants:: Aditya Dubay, Anupama Sarjoshi, CiBoT, Dhanuka Waidyatillake, Huong Nguyen, Juerg Hoerner, Jun Pataleta, Mahmoud Kassaei, Ron Carl Alfon Yu, Tim Hunt

Votes:: 2 Vote for this issue

Watchers:: 10 Start watching this issue

Created:: 29/Jun/24 1:45 PM

Updated:: 5 days ago 3:14 AM

Resolved:: 08/Nov/24 3:56 PM

Estimated:

Not Specified

Remaining:

Logged:

7h 20m

Details

Test the code to fix up corrupt sites.

Test the code for doing an upgrade now with no corruption

Description

Attachments

Attachments

Issue Links

Activity

People

Dates

Time Tracking

Clockify