-
Improvement
-
Resolution: Fixed
-
Minor
-
4.5
-
MOODLE_405_STABLE
-
MOODLE_405_STABLE
-
- Covered by automated tests (PHPUnit)
In order for us to consider adding callback support to the 'count' aggregation method in MDL-82464, then we first need to evaluate all current columns of type column::TYPE_INTEGER|TYPE_FLOAT to ensure we don't inadvertently change their behaviour
Per the class documentation the type of the column defines two things:
- How the value of the first parameter to the callback is cast;
- The available aggregation options for the column
We have a lot of entity columns with code similar to this, which is using the column type purely to get the first parameter value cast (they often subsequently disable numeric aggregation options, which rather proves the point they do not represent numeric data)
Edit This is also required for upcoming work on report graphs and visualisation work, to ensure we can always accurately identify numeric columns (see also MDL-83738)
- blocks
-
MDL-82464 Implement callback support for column "count" aggregation method
-
- Development in progress
-
- has been marked as being related by
-
MDL-83738 Allow report aggregation types to define the type of data they return
-
- Closed
-
- Testing discovered
-
MDL-82467 Days taking course columns do not aggregate/sort correctly
-
- Closed
-