Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-82542

Question bank: remembering 'show questions from subcategories' as a user preference has been lost

XMLWordPrintable

    • MOODLE_403_STABLE, MOODLE_404_STABLE
    • MOODLE_404_STABLE, MOODLE_405_STABLE
    • MDL-82542-404
    • MDL-82542-405
    • MDL-82542-master
    • Hide

      Test scenario: This is also covered by behat tests in question/bank/managecategories/tests/behat/question_categories.feature

      Main branch:

      1. Login as admin.
      2. Create a course.
      3. Create a teacher account and enrol to the course.
      4. Navigate to course question bank.
      5. Create a default course question bank if needed. (Main only)
      6. Create a sub category under the course category.
      7. Create a question under sub the category
      8. Go to Course question bank
      9. Uncheck the "Also show questions from subcategories" if it is checked.
      10. Click Apply filters.
      11. Verify that you do not see any questions.
      12. Tick the check box "Also show questions from subcategories"
      13. Click Apply filters
      14. Verify that the question appear in the question bank
      15. Create quiz activity in the course
      16. Go to Quiz -> Question bank
      17. Create a sub category under the Default for Quiz category.
      18. Create a question under sub the category
      19. Go to Quiz -> Questions tab
      20. Click Add from question bank
      21. Wait for modal to load completely.
      22. Verify that the "Also show questions from subcategories" is checked
      23. Verify that the question appear in the question bank
      24. Go to question bank in the quiz
      25. Verify that the "Also show questions from subcategories" is checked
      26. Verify that the question appear in the question bank
      27. Login as teacher
      28. Go to Course question bank
      29. Verify that the "Also show questions from subcategories" is un-checked
      30. Verify We should not see any questions.

      M4.4 and M4.5:

      1.  Login as admin.
      2. Create a course
      3. Create a sub category under the course category.
      4. Create a question under sub the category
      5. Go to Course question bank
      6. We should not see any question.
      7. Tick the check box "Also show questions from subcategories"
      8. Click Apply filters
      9. We should see the question appear in the question bank
      10. Create another quiz in the course
      11. Go to Quiz -> Questions tab
      12. Click Add from question bank
      13. Wait for modal to load completely.
      14. Verify We should see "Also show questions from subcategories" is checked
      15. Verify We should see the question appear in the question bank
      16. Go to question bank in the quiz
      17. Verify We should see "Also show questions from subcategories" is checked
      18. Verify We should see the question appear in the question bank
      19. Login as teacher
      20. Go to Course question bank
      21. Verify We should not see any question.
      Show
      Test scenario: This is also covered by behat tests in question/bank/managecategories/tests/behat/question_categories.feature Main branch: Login as admin. Create a course. Create a teacher account and enrol to the course. Navigate to course question bank. Create a default course question bank if needed. (Main only) Create a sub category under the course category. Create a question under sub the category Go to Course question bank Uncheck the "Also show questions from subcategories" if it is checked. Click Apply filters. Verify that you do not see any questions. Tick the check box "Also show questions from subcategories" Click Apply filters Verify that the question appear in the question bank Create quiz activity in the course Go to Quiz -> Question bank Create a sub category under the Default for Quiz category. Create a question under sub the category Go to Quiz -> Questions tab Click Add from question bank Wait for modal to load completely. Verify that the "Also show questions from subcategories" is checked Verify that the question appear in the question bank Go to question bank in the quiz Verify that the "Also show questions from subcategories" is checked Verify that the question appear in the question bank Login as teacher Go to Course question bank Verify that the "Also show questions from subcategories" is un-checked Verify We should not see any questions. M4.4 and M4.5:  Login as admin. Create a course Create a sub category under the course category. Create a question under sub the category Go to Course question bank We should not see any question. Tick the check box "Also show questions from subcategories" Click Apply filters We should see the question appear in the question bank Create another quiz in the course Go to Quiz -> Questions tab Click Add from question bank Wait for modal to load completely. Verify  We should see "Also show questions from subcategories" is checked Verify  We should see the question appear in the question bank Go to question bank in the quiz Verify  We should see "Also show questions from subcategories" is checked Verify  We should see the question appear in the question bank Login as teacher Go to Course question bank Verify  We should not see any question.
    • Hide

      Code verified against automated checks.

      Checked MDL-82542 using repository: https://github.com/NashTechOpenUniversity/moodle.git

      More information about this report

      Built on: Thu Jan 9 10:29:46 AM UTC 2025

      Show
      Code verified against automated checks. Checked MDL-82542 using repository: https://github.com/NashTechOpenUniversity/moodle.git MOODLE_404_STABLE (0 errors / 0 warnings) [branch: MDL-82542-404 | CI Job ] MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-82542-405 | CI Job ] main (0 errors / 0 warnings) [branch: MDL-82542-master | CI Job ] More information about this report Built on: Thu Jan 9 10:29:46 AM UTC 2025
    • Hide

      Launching automatic jobs for branch MDL-82542-404

      Launching automatic jobs for branch MDL-82542-405

      Launching automatic jobs for branch MDL-82542-master

      Built on: Thu Jan 9 05:40:37 UTC 2025

      Show
      Launching automatic jobs for branch MDL-82542 -404 https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60830/ Behat (NonJS - boost and classic / --tags @core_question,@mod_quiz,@quiz,@qbank) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60831/ Behat (Firefox - boost / --tags @core_question,@mod_quiz,@quiz,@qbank) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60832/ Behat (Firefox - classic / --tags @core_question,@mod_quiz,@quiz,@qbank) Launching automatic jobs for branch MDL-82542 -405 https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60833/ Behat (NonJS - boost and classic / --tags @core_question,@mod_quiz,@quiz,@qbank) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60834/ Behat (Firefox - boost / --tags @core_question,@mod_quiz,@quiz,@qbank) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60835/ Behat (Firefox - classic / --tags @core_question,@mod_quiz,@quiz,@qbank) Launching automatic jobs for branch MDL-82542 -master https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60836/ Behat (NonJS - boost and classic / --tags @core_question,@mod_quiz,@quiz,@qbank) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60837/ Behat (Firefox - boost / --tags @core_question,@mod_quiz,@quiz,@qbank) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60838/ Behat (Firefox - classic / --tags @core_question,@mod_quiz,@quiz,@qbank) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60839/ App tests (stable app version) / --tags @core_question,@mod_quiz,@quiz,@qbank) Built on: Thu Jan 9 05:40:37 UTC 2025

      Context

      It comes from the message https://moodle.org/mod/forum/discuss.php?d=460386#p1848797

      I create this ticket to cover one buggy behavior from the new filtering system from the question bank:

      Issue

      The checkbox to show question in subcategories was a user preference at least on Moodle 4.1.

      1. So that if you logout and login or change to another course and to its question bank, you still keep that preference (enabled or disabled, as you checked/unchecked last time).
      2. Now on Moodle 4.3 (at least), this checkbox seems that should work as the question category filter, kept during the user navigation, but it does not either. If you mark this checkbox, after some clicks, like going to the next page or back, the checkbox is lost. Also if you reload the page, or if you come back from adding a new question. However, the choosen question category is properly kept.
      3. We do think that this checkbox should work as before, as a user preference. We actually have a similar funcionality on the filtering options from the logs of the tasks: if you provide some filtering, you can log out and log in again and that filtering is kept for you, as a user preference.
      4. All this makes a lot of more clicks than in Moodle 4.1, at least, to do the same.

      What is asked

      Keep the checkbox to show questions from subcategories as a user preference, as it was on Moodle 4.1 (at least).

        1. (1) 11 Passed -- (Main)MDL-82542.png
          (1) 11 Passed -- (Main)MDL-82542.png
          94 kB
        2. (1) 14 Passed -- (Main)MDL-82542.png
          (1) 14 Passed -- (Main)MDL-82542.png
          130 kB
        3. (1) 23 Passed -- (Main)MDL-82542.png
          (1) 23 Passed -- (Main)MDL-82542.png
          78 kB
        4. (1) 26 Passed -- (Main)MDL-82542.png
          (1) 26 Passed -- (Main)MDL-82542.png
          123 kB
        5. (1) 30 Passed -- (Main)MDL-82542.png
          (1) 30 Passed -- (Main)MDL-82542.png
          92 kB
        6. (2) 15 Passed -- (405)MDL-82542.png
          (2) 15 Passed -- (405)MDL-82542.png
          76 kB
        7. (2) 18 Passed -- (405)MDL-82542.png
          (2) 18 Passed -- (405)MDL-82542.png
          124 kB
        8. (2) 21 Passed -- (405)MDL-82542.png
          (2) 21 Passed -- (405)MDL-82542.png
          88 kB

            vuvanhieu143 Hieu Vu
            jpahullo Jordi Pujol-Ahulló
            Tim Hunt Tim Hunt
            Jun Pataleta Jun Pataleta
            Kim Jared Lucas Kim Jared Lucas
            Votes:
            20 Vote for this issue
            Watchers:
            22 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 5 hours, 42 minutes
                5h 42m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.