Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-82589

Improve which page is linked to from the "Failed task max delay" notification

XMLWordPrintable

    • Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Minor Minor
    • 5.0
    • 4.5
    • Tasks
    • MOODLE_405_STABLE
    • MOODLE_500_STABLE
    • Hide

      Pre-requisites

      1. Install https://tracker.moodle.org/secure/attachment/148307/moodle-tool_testtasks79131.zip from MDL-79131
      2. Execute the following: 

        $ php admin/tool/testtasks79131/cli/queue_adhoc_task.php

      Test

      1. Log in as admin
      2. Navigate to Server > Tasks > Ad hoc tasks in site administration
      3. Press Run all for the fail_adhoc_task task
      4. Press Run again after the task fails
      5. Execute the following DB query: 

        SELECT * FROM moodle.m_task_adhoc WHERE component = 'tool_testtasks79131'

      6. Keep pressing Run again until the faildelay value from the above query reaches 86400
      7. Open the notification you've received regarding "Task failed" message
      8. Press View full notification
      9. Press the See task link in the message body
      10. Confirm it links to the Task logs page pre-filtered with the Fail adhoc task
      11. Go back to the notification
      12. Press Go to: Task logs in the message footer
      13. Confirm it links to the Task logs page pre-filtered with the Fail adhoc task
      Show
      Pre-requisites Install https://tracker.moodle.org/secure/attachment/148307/moodle-tool_testtasks79131.zip from MDL-79131 Execute the following: $ php admin/tool/testtasks79131/cli/queue_adhoc_task.php Test Log in as admin Navigate to Server > Tasks > Ad hoc tasks in site administration Press Run all for the fail_adhoc_task task Press Run again after the task fails Execute the following DB query: SELECT * FROM moodle.m_task_adhoc WHERE component = 'tool_testtasks79131' Keep pressing Run again until the faildelay value from the above query reaches 86400 Open the notification you've received regarding "Task failed" message Press View full notification Press the See task link in the message body Confirm it links to the Task logs page pre-filtered with the Fail adhoc task Go back to the notification Press Go to: Task logs in the message footer Confirm it links to the Task logs page pre-filtered with the Fail adhoc task
    • Hide

      Code verified against automated checks.

      Checked MDL-82589 using repository: https://github.com/paulholden/moodle/

      More information about this report

      Built on: Wed 13 Nov 2024 09:20:14 AM UTC

      Show
      Code verified against automated checks. Checked MDL-82589 using repository: https://github.com/paulholden/moodle/ main (0 errors / 0 warnings) [branch: MDL-82589 | CI Job ] More information about this report Built on: Wed 13 Nov 2024 09:20:14 AM UTC
    • Hide

      Launching automatic jobs for branch MDL-82589

      Built on: Tue Nov 12 12:30:16 AM UTC 2024

      Show
      Launching automatic jobs for branch MDL-82589 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17314/ PHPUnit (sqlsrv) --> unrelated https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/58997/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59067/ Behat (Firefox - boost) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/58999/ Behat (Firefox - classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59000/ App tests (stable app version) Built on: Tue Nov 12 12:30:16 AM UTC 2024

      We have a task logs report that can immediately filter for a specific task (e.g. the one that has reached the "max delay" threshold at which admins are notified from MDL-79131):

      http://localhost:8000/admin/tasklogs.php?filter=tool_testtasks79131%5Ctask%5Cfail_adhoc_task

      This will improve admins experience and immediately look at the logs of each failed task to aid diagnosis

      There is also a problem in the current linked page from report_status because it breaks our General rules for inter-component communications - specifically that core cannot depend on a plugin. In this case, it's entirely possible the admin has uninstalled report_status and we are emailing them a broken link

        1. (1) 10 Passed -- (Main)MDL-82589.png
          (1) 10 Passed -- (Main)MDL-82589.png
          125 kB
        2. (1) 13 Passed -- (Main)MDL-82589.png
          (1) 13 Passed -- (Main)MDL-82589.png
          115 kB
        3. MDL-82589-1.png
          MDL-82589-1.png
          109 kB
        4. MDL-82589-2.png
          MDL-82589-2.png
          208 kB

            pholden Paul Holden
            pholden Paul Holden
            Pedro Jordao Pedro Jordao
            Andrew Lyons Andrew Lyons
            Kim Jared Lucas Kim Jared Lucas
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 17 minutes
                17m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.