Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-82607

filternavigationwithsystemcontext config setting should be on by default

XMLWordPrintable

      Steps to reproduce:

      1. Go to Admin -> Plugins -> Filters -> Manager filters
      2. Change any one filter to 'Applies to' 'Content and headings'

      Unexpected result: Your Moodle site gets about 33% slower.

      Then spend a day profiling, etc. to discover that navigationlib.php is causing many calls to filter_get_active_in_context, I eventually found this setting in the code, which led me to MDL-67428, and the discovery that we were not alone in our pain.

      I can see why, at the time when MDL-67428 was first implemented, it was prudent to default the setting to off.

      However, it is now tried and tested, and pretty much essential to have this on if you are using 'Applies to' 'Content and headings', and it is irrelevant and does not harm if you are not.

      So, I am making this issue to chagne the default for new Moodle sites.

            timhunt Tim Hunt
            timhunt Tim Hunt
            Paul Holden Paul Holden
            Huong Nguyen Huong Nguyen
            Kim Jared Lucas Kim Jared Lucas
            Votes:
            1 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 24 minutes
                24m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.