-
Improvement
-
Resolution: Fixed
-
Minor
-
4.3.3, 4.4.1
-
MOODLE_403_STABLE, MOODLE_404_STABLE
-
MOODLE_405_STABLE
-
- Go to Admin -> Plugins -> Filter -> Common filter settings.
- Verify that 'Filter navigation with system context' is shown as having Default: Yes.
Steps to reproduce:
- Go to Admin -> Plugins -> Filters -> Manager filters
- Change any one filter to 'Applies to' 'Content and headings'
Unexpected result: Your Moodle site gets about 33% slower.
Then spend a day profiling, etc. to discover that navigationlib.php is causing many calls to filter_get_active_in_context, I eventually found this setting in the code, which led me to MDL-67428, and the discovery that we were not alone in our pain.
I can see why, at the time when MDL-67428 was first implemented, it was prudent to default the setting to off.
However, it is now tried and tested, and pretty much essential to have this on if you are using 'Applies to' 'Content and headings', and it is irrelevant and does not harm if you are not.
So, I am making this issue to chagne the default for new Moodle sites.
- has a non-specific relationship to
-
MDL-67428 Performance issues with filters applied to course/category titles in navigation
- Closed