Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-82658

forum reply_handler does not use course file size limit when forum maxbytes is set to 0

    • Icon: Bug Bug
    • Resolution: Unresolved
    • Icon: Minor Minor
    • None
    • 4.1.11
    • Forum

      Recently I checked the incoming message handling for moodle forums and my mail got rejected because it had a S/MIME signature attached:
      Sie haben vor kurzem eine E-Mail "Re: EduIT-E-Learning: Ankündigung aus
      Testkurs" versendet. Diese konnte leider nicht zugestellt werden.

      Die Gründe hierfür stehen hier unten.

      Die E-Mail 'Re: EduIT-E-Learning: Ankündigung aus Testkurs' konnte nicht
      verarbeitet werden. Folgender Fehler ist aufgetreten: 'Ihre Antwort kann
      nicht gepostet werden, weil die Gesamtgröße der Anhänge (10.9 KB)
      größer ist als die maximal erlaubte Größe für das Forum (0 Bytes).'.
       

      Execute scheduled task: Eingehende E-Mail-Abholung (tool_messageinbound\task\pickup_task)
      ... started 10:47:02. Current memory use 30.1 MB.
      Connecting to localhost as moodle@example.com...
      Connection established.
      Searching for Unseen, Unflagged email in the folder 'INBOX'
      Found 1 messages to parse. Parsing...

      • Parsing message 45907
        • Subject:    Re: EduIT-E-Learning: Ankündigung aus Testkurs
        • From:    pruem@hdm-stuttgart.de
        • Recipient:    moodle+AAAAAAAAAAIAAAAAAAAAGAAAAAAABAkWeGkX+r56Wk27P63Y@example.com
        • Processing the message as user 24 (admin-pruem).
        • Validation completed. Fetching rest of message content.
          --> Passing to Inbound Message handler \mod_forum\message\inbound\reply_handler
          --> Note: Post subject matched discussion name. Optimising from Re: EduIT-E-Learning: Ankündigung aus Testkurs to Re: Ankündigung aus Testkurs
          --> Processing leere-seite-5x4-hdm-logo.pdf as an attachment.
          --> Attaching leere-seite-5x4-hdm-logo.pdf to /760/user/draft/854490061/leere-seite-5x4-hdm-logo.pdf
          --> User attached 11141 bytes of files when only 0 where allowed. Rejecting e-mail.
          -> The Inbound Message handler threw an exception. Unable to process this message. The user has been informed.
          --> Ihre Antwort kann nicht gepostet werden, weil die Gesamtgröße der Anhänge  (10.9 KB) größer ist als die maximal erlaubte Größe für das Forum (0 Bytes).
          ---> Notification sent to pruem@example.com.
        • Returning to the original user.
          ... used 32 dbqueries
          ... used 2.1379630565643 seconds
          Scheduled task complete: Eingehende E-Mail-Abholung (tool_messageinbound\task\pickup_task)

       

      The Attachment size for the forum was set to the course limit (e.g. 100MB), after I changed this to a specific limit (i.e. 10MB) the mail got processed.

       

      MariaDB [moodle]> select * from mdl_forum where course=4300\G
      *************************** 1. row ***************************
                         id: 11821
                     course: 4300
                       type: news
                       name: Forum "Ankündigungen"
                      intro: Ankündigungen und Nachrichten
                introformat: 1
                    duedate: 0
                 cutoffdate: 0
                   assessed: 0
            assesstimestart: 0
           assesstimefinish: 0
                      scale: 0
                grade_forum: 0
         grade_forum_notify: 0
                   maxbytes: 0
             maxattachments: 1
             forcesubscribe: 1
               trackingtype: 1
                    rsstype: 0
                rssarticles: 0
               timemodified: 1691499149
                  warnafter: 0
                 blockafter: 0
                blockperiod: 0
      completiondiscussions: 0
          completionreplies: 0
            completionposts: 1
           displaywordcount: 0
        lockdiscussionafter: 0
      1 row in set (0,001 sec)

      MariaDB [moodle]> select * from mdl_forum where course=4300\G
      *************************** 1. row ***************************
                         id: 11821
                     course: 4300
                       type: news
                       name: Forum "Ankündigungen"
                      intro: Ankündigungen und Nachrichten
                introformat: 1
                    duedate: 0
                 cutoffdate: 0
                   assessed: 0
            assesstimestart: 0
           assesstimefinish: 0
                      scale: 0
                grade_forum: 0
         grade_forum_notify: 0
                   maxbytes: 10485760
             maxattachments: 3
             forcesubscribe: 1
               trackingtype: 1
                    rsstype: 0
                rssarticles: 0
               timemodified: 1722416975
                  warnafter: 0
                 blockafter: 0
                blockperiod: 0
      completiondiscussions: 0
          completionreplies: 0
            completionposts: 1
           displaywordcount: 0
        lockdiscussionafter: 0
      1 row in set (0,001 sec)

      MariaDB [moodle]>

       

      It looks like the reply_handler only checks the forum settings directly from the database and ignores the course settings when maxbytes is set to zero. In the Interface the "0"-Value is shown as "Course limits (100MB)".

            pholden Paul Holden
            pruem David Prüm
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.