Loading...

XML

Word

Printable

Type: Bug
Resolution: Unresolved
Priority: Minor
Fix Version/s: None
Affects Version/s: 4.4.1
Component/s: SCORM
Labels:
- ci
- triaged

Affected Branches:
MOODLE_404_STABLE
Pull from Repository:
https://github.com/DegrangeM/moodle.git
Pull 4.5 Branch:
MDL-82703-405_scorm_averagegrade
Pull 4.5 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_405_STABLE...DegrangeM:moodle:MDL-82703-405_scorm_averagegrade
Pull 5.0 Branch:
MDL-82703-500_scorm_averagegrade
Pull 5.0 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_500_STABLE...DegrangeM:moodle:MDL-82703-500_scorm_averagegrade
Pull Main Branch:
main
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/main...DegrangeM:moodle:main
Testing Instructions:
Hide

Create a scorm activity with the scorm in attachment.

In the activity settings, set Grade > Grading method to "Average grade".

Start an attempt, the first item should be opened automatically and you should get a 50/100 score. Open the second item and you should get a 0/100 score.

Go in reports and check that the score of your attempt is 25/100.

Start an other attempt (check the checkbox), and only open the first item (which is opened automatically). Don't open the second item.

Go in reports and check that the score of the second attempt is 25/100.
Show
Create a scorm activity with the scorm in attachment. In the activity settings, set Grade > Grading method to "Average grade". Start an attempt, the first item should be opened automatically and you should get a 50/100 score. Open the second item and you should get a 0/100 score. Go in reports and check that the score of your attempt is 25/100. Start an other attempt (check the checkbox), and only open the first item (which is opened automatically). Don't open the second item. Go in reports and check that the score of the second attempt is 25/100.
Pre-check results:
Hide

Code verified against automated checks.

Checked MDL-82703 using repository: https://github.com/DegrangeM/moodle.git

MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-82703-405_scorm_averagegrade | CI Job]

MOODLE_500_STABLE (0 errors / 0 warnings) [branch: MDL-82703-500_scorm_averagegrade | CI Job]

main (0 errors / 0 warnings) [branch: main | CI Job]

_{More information about this report}

Built on: Thu Apr 17 02:58:30 UTC 2025
Show
Code verified against automated checks. Checked MDL-82703 using repository: https://github.com/DegrangeM/moodle.git MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-82703-405_scorm_averagegrade | CI Job ] MOODLE_500_STABLE (0 errors / 0 warnings) [branch: MDL-82703-500_scorm_averagegrade | CI Job ] main (0 errors / 0 warnings) [branch: main | CI Job ] More information about this report Built on: Thu Apr 17 02:58:30 UTC 2025
Automated test results:
Hide

Launching automatic jobs for branch MDL-82703-405_scorm_averagegrade

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/19060/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65171/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65172/ Behat (Firefox - boost)

Launching automatic jobs for branch MDL-82703-500_scorm_averagegrade

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/19061/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65173/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65174/ Behat (Firefox - boost)

Launching automatic jobs for branch main

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/19062/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65175/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65176/ Behat (Firefox - boost)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65177/ Behat (Firefox - classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65178/ App tests (stable app version)

Built on: Thu Apr 17 04:30:22 UTC 2025
Show
Launching automatic jobs for branch MDL-82703 -405_scorm_averagegrade https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/19060/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65171/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65172/ Behat (Firefox - boost) Launching automatic jobs for branch MDL-82703 -500_scorm_averagegrade https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/19061/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65173/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65174/ Behat (Firefox - boost) Launching automatic jobs for branch main https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/19062/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65175/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65176/ Behat (Firefox - boost) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65177/ Behat (Firefox - classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/65178/ App tests (stable app version) Built on: Thu Apr 17 04:30:22 UTC 2025

Bug description

Scorm ignore item with 0 score when calculating activity grade when set to "average grade".

How to reproduce the bug

Create a scorm activity with a scorm file with 2 items with grading method set to "average grade".
Get 0/100 at the first item and 50/100 at the second item.
Check the scorm given by Moodle.

Expected result

The student should get 25/100.

Current result

The student get 50/100.

Possible origin of the bug ?

I am not sure (as I am not a scorm expert), but I am wondering if on this line :
https://github.com/moodle/moodle/blob/main/mod/scorm/locallib.php#L744
Shouldn't

$scorm->type

be replaced with

$sco->scormtype

(as this is what we see later in the code) ?

Other possible issue ?

This should be an other issue but I am putting this here as it's very related and it could save time : if a student answer to the first item but answer to the second item (and get 50/100), it also get 50/100 to the activity. I think it should count the first item as 0/100 and give him a 0/100.

Related issue

~~MDL-52941~~ but it's been closed.

- - Sort By Name
  - Sort By Date
  - Ascending
  - Descending
  - Thumbnails
  - List
  - Download All

2024-08-04_23-56-49.png
22 kB
05/Aug/24 6:44 AM
2024-08-04_23-57-27.png
7 kB
05/Aug/24 6:44 AM
82703 peer review - after patch.png
96 kB
27/Mar/25 5:29 PM
82703 peer review - before patch.png
95 kB
27/Mar/25 5:29 PM
bug_moodle_scorm.zip
6 kB
06/Aug/24 1:09 AM
chrome_2024-08-04_23-58-32.png
6 kB
05/Aug/24 6:44 AM
chrome_2024-08-04_23-59-28.png
39 kB
05/Aug/24 6:44 AM

Assignee:: DegrangeM

Reporter:: DegrangeM

Peer reviewer:: Andrew Gosali

Participants:: Andrew Gosali, CiBoT, Dan Marsden, DegrangeM

Votes:: 1 Vote for this issue

Watchers:: 7 Start watching this issue

Created:: 05/Aug/24 6:43 AM

Updated:: 1 week ago 12:30 PM

Estimated:

Remaining:

Logged:

1h 45m

Details

Description

Bug description

How to reproduce the bug

Expected result

Current result

Possible origin of the bug ?

Other possible issue ?

Related issue

Attachments

Attachments

Activity

People

Dates

Time Tracking

Clockify