Loading...

XML

Word

Printable

Type: Bug
Resolution: Fixed
Priority: Minor
Fix Version/s: 4.4.6, 4.5.2
Affects Version/s: 4.4, 4.5
Component/s: Questions, Quiz
Labels:

Affected Branches:
MOODLE_404_STABLE, MOODLE_405_STABLE
Fixed Branches:
MOODLE_404_STABLE, MOODLE_405_STABLE
Epic Link:
Quiz and Question bank in Moodle 5.0
Pull from Repository:
https://github.com/cwarwicker/moodle
Pull 4.4 Branch:
~~MDL-82769~~_404
Pull 4.4 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_404_STABLE...cwarwicker:moodle:MDL-82769_404
Pull 4.5 Branch:
~~MDL-82769~~_405
Pull 4.5 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_405_STABLE...cwarwicker:moodle:MDL-82769_405
Pull Main Branch:
~~MDL-82769~~_main
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/main...cwarwicker:moodle:MDL-82769_main
Testing Instructions:
Hide

Install Moodle 4.1

Create a course with a quiz

Add a question to the question bank

Add a Random Question to the quiz using that question bank

Upgrade to Moodle 4.4/4.5/5

Edit the Random Question and confirm it now works

View the Random Question and confirm it now works

Preview the quiz and confirm it now works
Show
Install Moodle 4.1 Create a course with a quiz Add a question to the question bank Add a Random Question to the quiz using that question bank Upgrade to Moodle 4.4/4.5/5 Edit the Random Question and confirm it now works View the Random Question and confirm it now works Preview the quiz and confirm it now works
Pre-check results:
Hide

Code verified against automated checks.

Checked ~~MDL-82769~~ using repository: https://github.com/cwarwicker/moodle

MOODLE_404_STABLE (0 errors / 0 warnings) [branch: MDL-82769_404 | CI Job]

MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-82769_405 | CI Job]

main (0 errors / 0 warnings) [branch: MDL-82769_main | CI Job]

_{More information about this report}

Built on: Mon Jan 6 02:18:15 PM UTC 2025
Show
Code verified against automated checks. Checked MDL-82769 using repository: https://github.com/cwarwicker/moodle MOODLE_404_STABLE (0 errors / 0 warnings) [branch: MDL-82769_404 | CI Job ] MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-82769_405 | CI Job ] main (0 errors / 0 warnings) [branch: MDL-82769_main | CI Job ] More information about this report Built on: Mon Jan 6 02:18:15 PM UTC 2025
Automated test results:
Hide

Launching automatic jobs for branch ~~MDL-82769~~_404

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17820/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60700/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60701/ Behat (Firefox - boost)

Launching automatic jobs for branch ~~MDL-82769~~_405

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17821/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60702/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60703/ Behat (Firefox - boost)

Launching automatic jobs for branch ~~MDL-82769~~_main

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17822/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60704/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60705/ Behat (Firefox - boost)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60706/ Behat (Firefox - classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60707/ App tests (stable app version)

Built on: Tue Jan 7 02:30:27 PM UTC 2025
Show
Launching automatic jobs for branch MDL-82769 _404 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17820/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60700/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60701/ Behat (Firefox - boost) Launching automatic jobs for branch MDL-82769 _405 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17821/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60702/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60703/ Behat (Firefox - boost) Launching automatic jobs for branch MDL-82769 _main https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17822/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60704/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60705/ Behat (Firefox - boost) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60706/ Behat (Firefox - classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/60707/ App tests (stable app version) Built on: Tue Jan 7 02:30:27 PM UTC 2025

To reproduce

Create a 4.1 site
Create a course with a quiz
Add a random question to the quiz (I made a new category when I added the question, and there were no questions in the category)
Upgrade to latest master
Browse to the quiz
Press the cog next to the random question created in step 3.
An exception is thrown:

Exception - qbank_managecategories\category_condition::validate_category_param(): Argument #1 ($categoryandcontext) must be of type string, null given, called in [dirroot]/mod/quiz/classes/question/bank/custom_view.php on line 73

The problem appears to be here where the filtercondition is obtained directly from the DB, rather than being converted on the fly to the new format by convert_legacy_set_reference_filter_condition. Then code a bit further down assumes the filter condition is in the new format.

- - Sort By Name
  - Sort By Date
  - Ascending
  - Descending
  - Thumbnails
  - List
  - Download All

MDL-82769.png
762 kB
09/Jan/25 2:18 PM

duplicates

MDL-80466 Random questions restored from 3.9 backup shows error in the edit quiz screen

Open

has a non-specific relationship to

MDL-79708 Random questions from empty categories with non-empty sub-categories throwing "not enough questions in category" error

Closed

MDL-72321 Better searching/filtering in the question bank, so more flexible randomisation in quizzes

Closed

is duplicated by

MDL-80158 Quiz: cannot edit the setting of random questions after they have been added to the quiz

Closed

MDL-82780 Question Bank showing error

Closed

Assignee:: CMR

Reporter:: cameron1729

Peer reviewer:: Mark Johnson

Integrator:: Tim Hunt

Tester:: Ron Carl Alfon Yu

Participants:: cameron1729, CiBoT, CMR, CS, Jake Dallimore, Joe Davison, Jun Pataleta, Mark Johnson, Maurício Severo da Silva, Ron Carl Alfon Yu, Tim Hunt, Ulandi, Ulrik McArdle

Votes:: 18 Vote for this issue

Watchers:: 29 Start watching this issue

Created:: 12/Aug/24 4:59 PM

Updated:: 04/Feb/25 1:50 PM

Resolved:: 09/Jan/25 10:39 PM

Estimated:

Remaining:

Logged:

1d 10m

Details

Description

Attachments

Attachments

Issue Links

Activity

People

Dates

Time Tracking

Clockify