Loading...

XML

Word

Printable

Type: Bug
Resolution: Fixed
Priority: Minor
Fix Version/s: 4.4.6, 4.5.2
Affects Version/s: 4.3.6, 4.4.1
Component/s: Quiz
Labels:

Affected Branches:
MOODLE_403_STABLE, MOODLE_404_STABLE
Fixed Branches:
MOODLE_404_STABLE, MOODLE_405_STABLE
Epic Link:
Quiz and Question bank in Moodle 5.0
Pull from Repository:
https://github.com/cwarwicker/moodle.git
Pull 4.4 Branch:
MDL-82722_404
Pull 4.4 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_404_STABLE...cwarwicker:moodle:MDL-82722_404
Pull 4.5 Branch:
MDL-82722_405
Pull 4.5 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_405_STABLE...cwarwicker:moodle:MDL-82722_405
Pull Main Branch:
MDL-82722_main
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/main...cwarwicker:moodle:MDL-82722_main
Testing Instructions:
Hide

Moodle 4.4/4.5

Add a question to the course question bank

Add a question to the system question bank

Create a course

Create a quiz on the course

Create 1 random question using the course question bank category

Check the `questionscontextid` field in the DB `mdl_question_set_references` table

Edit the random question and change the category to the system one

Check the DB table again and confirm the `questionscontextid` changed

Edit the random question and change the category back to its original one

Check the DB table again and confirm the `questionscontextid` is back to its original value

Moodle 5

Create a course

Create 2 question banks on the course (or 1 extra one if the default is already created) (For example I'll call them A and B)

Add one question to each of the 2 question banks

Create a quiz on the course

Create 1 random question using the A question bank

Check the `questionscontextid` field in the DB `mdl_question_set_references` table

Edit the random question and change to use the B question bank instead

Check the DB table again and confirm the `questionscontextid` changed

Edit the random question and change the question back to its original one

Check the DB table again and confirm the `questionscontextid` is back to its original value
Show
Moodle 4.4/4.5 Add a question to the course question bank Add a question to the system question bank Create a course Create a quiz on the course Create 1 random question using the course question bank category Check the `questionscontextid` field in the DB `mdl_question_set_references` table Edit the random question and change the category to the system one Check the DB table again and confirm the `questionscontextid` changed Edit the random question and change the category back to its original one Check the DB table again and confirm the `questionscontextid` is back to its original value Moodle 5 Create a course Create 2 question banks on the course (or 1 extra one if the default is already created) (For example I'll call them A and B) Add one question to each of the 2 question banks Create a quiz on the course Create 1 random question using the A question bank Check the `questionscontextid` field in the DB `mdl_question_set_references` table Edit the random question and change to use the B question bank instead Check the DB table again and confirm the `questionscontextid` changed Edit the random question and change the question back to its original one Check the DB table again and confirm the `questionscontextid` is back to its original value
Pre-check results:
Hide

Code verified against automated checks.

Checked ~~MDL-82772~~ using repository: https://github.com/cwarwicker/moodle.git

MOODLE_404_STABLE (0 errors / 0 warnings) [branch: MDL-82722_404 | CI Job]

MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-82722_405 | CI Job]

main (0 errors / 0 warnings) [branch: MDL-82722_main | CI Job]

_{More information about this report}

Built on: Wed Jan 15 01:31:49 PM UTC 2025
Show
Code verified against automated checks. Checked MDL-82772 using repository: https://github.com/cwarwicker/moodle.git MOODLE_404_STABLE (0 errors / 0 warnings) [branch: MDL-82722_404 | CI Job ] MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-82722_405 | CI Job ] main (0 errors / 0 warnings) [branch: MDL-82722_main | CI Job ] More information about this report Built on: Wed Jan 15 01:31:49 PM UTC 2025
Automated test results:
Hide

Launching automatic jobs for branch MDL-82722_404

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17937/ PHPUnit (sqlsrv / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61182/ Behat (NonJS - boost and classic / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61183/ Behat (Firefox - boost / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61184/ Behat (Firefox - classic / complete)

Launching automatic jobs for branch MDL-82722_405

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17938/ PHPUnit (sqlsrv / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61185/ Behat (NonJS - boost and classic / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61186/ Behat (Firefox - boost / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61187/ Behat (Firefox - classic / complete)

Launching automatic jobs for branch MDL-82722_main

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17939/ PHPUnit (sqlsrv / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61188/ Behat (NonJS - boost and classic / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61189/ Behat (Firefox - boost / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61190/ Behat (Firefox - classic / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61191/ App tests (stable app version) / complete)

Built on: Wed Jan 15 13:59:58 UTC 2025
Show
Launching automatic jobs for branch MDL-82722 _404 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17937/ PHPUnit (sqlsrv / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61182/ Behat (NonJS - boost and classic / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61183/ Behat (Firefox - boost / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61184/ Behat (Firefox - classic / complete) Launching automatic jobs for branch MDL-82722 _405 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17938/ PHPUnit (sqlsrv / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61185/ Behat (NonJS - boost and classic / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61186/ Behat (Firefox - boost / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61187/ Behat (Firefox - classic / complete) Launching automatic jobs for branch MDL-82722 _main https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17939/ PHPUnit (sqlsrv / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61188/ Behat (NonJS - boost and classic / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61189/ Behat (Firefox - boost / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61190/ Behat (Firefox - classic / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/61191/ App tests (stable app version) / complete) Built on: Wed Jan 15 13:59:58 UTC 2025

To reproduce

Create a quiz with a random question, set the category to the default category for the quiz
Check the mdl_question_set_references table, taking note of the "questionscontextid" column
Edit the random question, changing the category to "Top for system" and save
Look at the mdl_question_set_references table
Note that the "questionscontextid" column has not updated - it will still show the same context ID as before

I believe this was bug was introduced by ~~MDL-72321~~ because (at least in 4.1) the "questionscontextid" column updates when changing the category for a random question.

- - Sort By Name
  - Sort By Date
  - Ascending
  - Descending
  - Thumbnails
  - List
  - Download All

(2) 1 Passed -- (Main)MDL-82772.png
36 kB
22/Jan/25 2:39 PM
(2) 2 Passed -- (Main)MDL-82772.png
36 kB
22/Jan/25 2:39 PM
(2) 3 Passed -- (Main)MDL-82772.png
35 kB
22/Jan/25 2:39 PM

has been marked as being related by

MDL-85166 Question category move does not update questionscontextid in question_set_references, breaking backup/restore

Open

is a regression caused by

MDL-72321 Better searching/filtering in the question bank, so more flexible randomisation in quizzes

Closed

Assignee:: CMR

Reporter:: cameron1729

Peer reviewer:: Mark Johnson

Integrator:: Tim Hunt

Tester:: Kim Jared Lucas

Participants:: cameron1729, CiBoT, CMR, Huong Nguyen, Jake Dallimore, Kim Jared Lucas, Mark Johnson, Tim Hunt

Votes:: 1 Vote for this issue

Watchers:: 10 Start watching this issue

Created:: 12/Aug/24 7:48 PM

Updated:: 5 days ago 6:56 PM

Resolved:: 24/Jan/25 1:06 AM

Estimated:

Not Specified

Remaining:

Logged:

1h 20m

Details

Description

Attachments

Attachments

Issue Links

Activity

People

Dates

Time Tracking

Clockify