Loading...

XML

Word

Printable

Type: Bug
Resolution: Unresolved
Priority: Minor
Fix Version/s: None
Affects Version/s: 4.4
Component/s: Questions
Labels:
- ci
- partner
- partner-eld

Affected Branches:
MOODLE_404_STABLE
Pull from Repository:
https://github.com/justinhunt/moodle
Pull 4.1 Branch:
MDL-82797_401_STABLE
Pull 4.1 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_401_STABLE...justinhunt:moodle:MDL-82797_401_STABLE?expand=1
Pull 4.3 Branch:
MDL-82797_403_STABLE
Pull 4.3 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_403_STABLE...justinhunt:moodle:MDL-82797_403_STABLE?expand=1
Pull 4.4 Branch:
MDL-82797_404_STABLE
Pull 4.4 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_404_STABLE...justinhunt:moodle:MDL-82797_404_STABLE?expand=1
Pull 4.5 Branch:
MDL-82797_405_STABLE
Pull 4.5 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_405_STABLE...justinhunt:moodle:MDL-82797_405_STABLE?expand=1
Pull Main Branch:
MDL-82797_main
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/main...justinhunt:moodle:MDL-82797_main?expand=1
Testing Instructions:
Hide

The issue manifests when two question types that support Gift import are installed. Specifically they implement the function "import_from_gift." Other import types could also throw this error, but I have not seen any.

In Moodle 4.3 / 4.4 / 4.5 / main the ordering type question is installed by default. This implements import_from_gift. So it is only necessary to install another. Essay Auto Grade also implements import_from_gift. So install that.
https://moodle.org/plugins/qtype_essayautograde

For Moodle 4.3 and 4.1 you will also need to install the ordering question type which was not in core at that time.
https://moodle.org/plugins/qtype_ordering

Then:

Create a course

Go the question bank

Create a multichoice question

From the question bank export questions to GIFT format

From the question bank import those questions with GIFT format

Prior to this fix - there will be an error message immediately
Post this fix - the questions will imported successfully
Show
The issue manifests when two question types that support Gift import are installed. Specifically they implement the function "import_from_gift." Other import types could also throw this error, but I have not seen any. In Moodle 4.3 / 4.4 / 4.5 / main the ordering type question is installed by default. This implements import_from_gift. So it is only necessary to install another. Essay Auto Grade also implements import_from_gift. So install that. https://moodle.org/plugins/qtype_essayautograde For Moodle 4.3 and 4.1 you will also need to install the ordering question type which was not in core at that time. https://moodle.org/plugins/qtype_ordering Then: Create a course Go the question bank Create a multichoice question From the question bank export questions to GIFT format From the question bank import those questions with GIFT format Prior to this fix - there will be an error message immediately Post this fix - the questions will imported successfully

When you import an Ordering type question to Moodle 4.4 using the GIFT format it throws the following error:

Exception - qtype_ordering::import_from_gift(): Argument #2 ($question) must be of type ?stdClass, bool given, called in [dirroot]/question/format.php on line 315

More information about this error
Debug info:
Error code: generalexceptionmessage×Dismiss this notification
Stack trace:
line 311 of /question/type/ordering/questiontype.php: TypeError thrown
line 315 of /question/format.php: call to qtype_ordering->import_from_gift()
line 291 of /question/format/gift/format.php: call to qformat_default->try_importing_using_qtypes()
line 734 of /question/format.php: call to qformat_gift->readquestion()
line 353 of /question/format.php: call to qformat_default->readquestions()
line 127 of /question/bank/importquestions/import.php: call to qformat_default->importprocess()

Steps to replicate:
Create a course
Go to the Question bank
Create an Ordering type question
Export the question bank in Gift format
delete the question
Import the freshly created GIFT format export
Fails

Works in other formats so Moodle XML in the question edit dropdown imports without issue.

Assignee:: Justin Hunt

Reporter:: Derick Turner

Participants:: Christophe Labetoulle, CiBoT, Derick Turner, Joe, Justin Hunt, Ron Carl Alfon Yu, Tim Hunt

Votes:: 3 Vote for this issue

Watchers:: 8 Start watching this issue

Created:: 14/Aug/24 11:52 PM

Updated:: 13/Oct/24 10:20 AM

Details

Description

Attachments

Activity

People

Dates

Clockify