Loading...

XML

Word

Printable

Type: Bug
Resolution: Fixed
Priority: Minor
Fix Version/s: 4.1.13, 4.2.10, 4.3.7, 4.4.3
Affects Version/s: 4.1.12, 4.2.9, 4.3.6, 4.4 regressions, 4.4.2
Component/s: Database SQL/XMLDB
Labels:

Affected Branches:
MOODLE_401_STABLE, MOODLE_402_STABLE, MOODLE_403_STABLE, MOODLE_404_STABLE
Fixed Branches:
MOODLE_401_STABLE, MOODLE_402_STABLE, MOODLE_403_STABLE, MOODLE_404_STABLE
Pull from Repository:
https://github.com/paulholden/moodle/
Pull 4.1 Branch:
~~MDL-82802~~-401
Pull 4.1 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_401_STABLE...paulholden:MDL-82802-401
Pull 4.3 Branch:
~~MDL-82802~~-403
Pull 4.3 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_403_STABLE...paulholden:MDL-82802-403
Pull 4.4 Branch:
~~MDL-82802~~-404
Pull 4.4 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_404_STABLE...paulholden:MDL-82802-404
Pull Main Branch:
~~MDL-82802~~
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/main...paulholden:MDL-82802
Testing Instructions:
Hide

Ensure testing on MySQL

Log in as admin

Navigate to Development > XMLDB editor in site administration

Press Load for the mod/h5pactivity/db table row

Press mod/h5pactivity/db

Press New table from MySQL

Create table: h5p

After table: h5pactivity

Press Create

Confirm there is no exception/error

Confirm you see the following in the Comment field:

h5p table retrofitted from MySQL

Confirm that the changes are written to the install file, or you get a message saying (either is fine):

There are changes in this file but they cannot be saved
Show
Ensure testing on MySQL Log in as admin Navigate to Development > XMLDB editor in site administration Press Load for the mod/h5pactivity/db table row Press mod/h5pactivity/db Press New table from MySQL Create table: h5p After table: h5pactivity Press Create Confirm there is no exception/error Confirm you see the following in the Comment field: h5p table retrofitted from MySQL Confirm that the changes are written to the install file, or you get a message saying (either is fine): There are changes in this file but they cannot be saved

The parameter cleaning here from MDL-82395 was too harsh, and leads to the following rather confusing exception when trying to reference tables containing numbers (e.g. the various h5p_* tables):

A required parameter (name) was missing

More information about this error

Debug info:

Error code: missingparam

Stack trace:

    line 574 of /lib/classes/param.php: core\exception\moodle_exception thrown

    line 452 of /lib/classes/param.php: call to core\param->get_request_parameter()

    line 650 of /lib/moodlelib.php: call to core\param->required_param()

    line 114 of /admin/tool/xmldb/actions/edit_table/edit_table.class.php: call to required_param()

    line 193 of /admin/tool/xmldb/actions/XMLDBAction.class.php: call to edit_table->invoke()

    line 184 of /admin/tool/xmldb/actions/new_table_from_mysql/new_table_from_mysql.class.php: call to XMLDBAction->launch()

    line 67 of /admin/tool/xmldb/index.php: call to new_table_from_mysql->invoke()

- - Sort By Name
  - Sort By Date
  - Ascending
  - Descending
  - Thumbnails
  - List
  - Download All

MDL-82802_Step8-9-10.png
195 kB
22/Aug/24 10:22 PM
MDL-82802.png
174 kB
29/Aug/24 2:22 PM
xmldberror.png
53 kB
29/Aug/24 11:48 AM

has been marked as being related by

MDL-82853 PR only: Library upgrade PR, final deprecation PR, other PR

Closed

Assignee:: Paul Holden

Reporter:: Paul Holden

Peer reviewer:: Raquel Ortega

Integrator:: Jun Pataleta

Tester:: Ron Carl Alfon Yu

Participants:: CiBoT, Jun Pataleta, Paul Holden, Raquel Ortega, Ron Carl Alfon Yu

Votes:: 0 Vote for this issue

Watchers:: 4 Start watching this issue

Created:: 15/Aug/24 6:50 PM

Updated:: 30/Aug/24 11:49 AM

Resolved:: 29/Aug/24 8:16 PM

Estimated:

Not Specified

Remaining:

Logged:

2h 47m

Details

Description

Attachments

Attachments

Issue Links

Activity

People

Dates

Time Tracking

Clockify