Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-82857

Form elements should not be removed from mod_assign_grading_options_form

XMLWordPrintable

    • MOODLE_405_STABLE
    • MOODLE_405_STABLE
    • MDL-82857-main
    • Hide

      General test

      1. Login as admin
      2. Create a course.
      3. Create an assignment activity in the course.
        1. Enable Marking workflow and Marker allocation in the assignment.
      4. Go to the submissions page (View all submissions)
        1. confirm that the Options sections still exist below the submissions table.
        2. confirm the following options can be found: 'Assignment per page', 'Filter', 'Marker filter', 'Quick grading', 'Show only active enrolments' and 'Download submissions in folders'.
        3. confirm that the available options work as expected.

      Deprecation

      1. Run the following command:
        git grep mod_assign_grading_options_form
      2. Confirm that the only locations are:
        1. The class file itself
        2. the upgrade notes
        3. A comment reference in mod/assign/classes/form/grading_options_temp_form.php
      Show
      General test Login as admin Create a course. Create an assignment activity in the course. Enable Marking workflow and Marker allocation in the assignment. Go to the submissions page (View all submissions) confirm that the Options sections still exist below the submissions table. confirm the following options can be found: 'Assignment per page', 'Filter', 'Marker filter', 'Quick grading', 'Show only active enrolments' and 'Download submissions in folders'. confirm that the available options work as expected. Deprecation Run the following command: git grep mod_assign_grading_options_form Confirm that the only locations are: The class file itself the upgrade notes A comment reference in mod/assign/classes/form/grading_options_temp_form.php
    • 1
    • Team Alpha - Sprint 1 I3-2024

      The assignment improvements propose relocating the current items within the grading options section to various parts of the UI on the assignment submissions page. These items are currently part of the mod_assign_grading_options_form class as form elements. As part of the migration process, starting with the workflow filter in MDL-82508, these elements have been removed from the mod_assign_grading_options_form class. However, although it's unlikely, this class could potentially be used by external code, making the "aggressive" removal of these form elements a possible source of unwanted behavior elsewhere.

      To ensure that there are no risks of introducing any issues, we should:

      1. Revert the removal of the form elements in the mod_assign_grading_options_form class.
      2. Introduce a new temporary class as a copy of mod_assign_grading_options_form specifically for use within the assignment submissions page and to resume the gradual migration of its form elements. Once the migration is complete, this class will be removed.
      3. Deprecate the mod_assign_grading_options_form class once the temporary class is introduced, as it will no longer be used in core.

            Geshoski Mihail Geshoski
            Geshoski Mihail Geshoski
            Jake Dallimore Jake Dallimore
            Shamim Rezaie Shamim Rezaie
            Ron Carl Alfon Yu Ron Carl Alfon Yu
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 3 hours, 2 minutes
                3h 2m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.