Setup In order to test this, it's easier to see the result if we introduce artificial delays in order to observe the loading icon in effect Apply the following patch: $ git diff diff --git a/lib/table/classes/external/dynamic/get.php b/lib/table/classes/external/dynamic/get.php index 32fbce7e5e0..f61541b304b 100644 --- a/lib/table/classes/external/dynamic/get.php +++ b/lib/table/classes/external/dynamic/get.php @@ -214,6 +214,8 @@ class get extends external_api { throw new \UnexpectedValueException("The filter specified ({$filtersetclass}) is invalid."); } + sleep(2); + $filterset = new $filtersetclass(); $filterset->set_join_type($jointype); foreach ($filters as $rawfilter) { diff --git a/reportbuilder/classes/output/column_aggregation_editable.php b/reportbuilder/classes/output/column_aggregation_editable.php index 1b42f83c287..5434cfb6709 100644 --- a/reportbuilder/classes/output/column_aggregation_editable.php +++ b/reportbuilder/classes/output/column_aggregation_editable.php @@ -75,6 +75,7 @@ class column_aggregation_editable extends inplace_editable { $column = new column($columnid); $report = $column->get_report(); + sleep(2); external_api::validate_context($report->get_context()); permission::require_can_edit_report($report); Test Log in as admin Navigate to Reports from user menu Create new report from Users report source Include default setup: Yes Set User > Username aggregation to Count Confirm the icon next to the Count element shows a rotating spinner Confirm the inner table element shows a larger rotating spinner as it reloads (after the editable component has completed)