Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-82913

Simplify the select filter type when it contains upto two options

XMLWordPrintable

    • MOODLE_500_STABLE
    • Hide
      1. Log in as admin
      2. Navigate to Server > Tasks > Task logs in site administration
      3. Open Filters
      4. Confirm the Type filter contains a single select element, with three options:
        • Is any value
        • Ad-hoc
        • Scheduled
      5. Confirm that changing/applying the Type filter works as expected
      6. Navigate to Users > Accounts > Browse list of users in site administration
      7. Open Filters
      8. Confirm the Country filter contains two select elements
        • The first containing "Is any value", "Is/not equal to"
        • The second containing a list of countries
      9. Confirm that changing/applying the Country filter works as expected
      Show
      Log in as admin Navigate to Server > Tasks > Task logs in site administration Open Filters Confirm the Type filter contains a single select element, with three options: Is any value Ad-hoc Scheduled Confirm that changing/applying the Type filter works as expected Navigate to Users > Accounts > Browse list of users in site administration Open Filters Confirm the Country filter contains two select elements The first containing "Is any value", "Is/not equal to" The second containing a list of countries Confirm that changing/applying the Country filter works as expected
    • Hide

      Code verified against automated checks.

      Checked MDL-82913 using repository: https://github.com/paulholden/moodle.git

      More information about this report

      Built on: Fri 22 Nov 2024 03:48:32 PM UTC

      Show
      Code verified against automated checks. Checked MDL-82913 using repository: https://github.com/paulholden/moodle.git main (0 errors / 0 warnings) [branch: MDL-82913 | CI Job ] More information about this report Built on: Fri 22 Nov 2024 03:48:32 PM UTC
    • Hide

      Launching automatic jobs for branch MDL-82913

      Built on: Fri Nov 22 03:40:27 PM UTC 2024

      Show
      Launching automatic jobs for branch MDL-82913 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17496/ PHPUnit (sqlsrv / --testsuite core_reportbuilder_testsuite) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59600/ Behat (NonJS - boost and classic / --tags @core_reportbuilder) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59601/ Behat (Firefox - boost / --tags @core_reportbuilder) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59602/ Behat (Firefox - classic / --tags @core_reportbuilder) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59603/ App tests (stable app version) / --tags @core_reportbuilder) Built on: Fri Nov 22 03:40:27 PM UTC 2024

      There are a couple filters which are clunky to use because you have a split select for a filter which only has 2 options:

      So you have to select 'Is equal to' and then select the type, or the type you don't want.

      It would be much better with filters like this if the options we in a single select, eg:

      This also applies to other filters like Result = success / Result = failure

      Ideally the report builder engine does this for free when it detects that the number of options for a filter is exactly 2. There should not need to be much effort on the report dev.

       

       

       

        1. image-2024-08-28-12-21-57-035.png
          image-2024-08-28-12-21-57-035.png
          10 kB
        2. image-2024-08-28-12-24-28-230.png
          image-2024-08-28-12-24-28-230.png
          8 kB
        3. MDL-82913.png
          MDL-82913.png
          969 kB

            pholden Paul Holden
            brendanheywood Brendan Heywood
            Brendan Heywood Brendan Heywood
            David Carrillo David Carrillo
            Ron Carl Alfon Yu Ron Carl Alfon Yu
            Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 hour, 7 minutes
                1h 7m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.